Comments

John Luo · John Luo · commit 2b8034b3e606 · 2020-06-16T15:58:12.000-07:00
diff --git a/src/Servers/Kestrel/Core/src/Middleware/HttpsConnectionMiddleware.cs b/src/Servers/Kestrel/Core/src/Middleware/HttpsConnectionMiddleware.cs
@@ -310,7 +310,8 @@ private static bool IsWindowsVersionIncompatible()
             if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
             {
                 var enableHttp2OnWindows81 = AppContext.TryGetSwitch(EnableWindows81Http2, out var enabled) && enabled;
-                if (Environment.OSVersion.Version < new Version(6, 3)
+                if (Environment.OSVersion.Version < new Version(6, 3) // Missing ALPN support
+                    // Win8.1 and 2012 R2 don't support the right cipher configuration by default.
                     || (Environment.OSVersion.Version < new Version(10, 0) && !enableHttp2OnWindows81))
                 {
                     return true;

Original file line number	Diff line number	Diff line change
`@@ -310,7 +310,8 @@ private static bool IsWindowsVersionIncompatible()`
`310`	`310`	`if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))`
`311`	`311`	`{`
`312`	`312`	`var enableHttp2OnWindows81 = AppContext.TryGetSwitch(EnableWindows81Http2, out var enabled) && enabled;`
`313`		`- if (Environment.OSVersion.Version < new Version(6, 3)`
	`313`	`+ if (Environment.OSVersion.Version < new Version(6, 3) // Missing ALPN support`
	`314`	`+ // Win8.1 and 2012 R2 don't support the right cipher configuration by default.`
`314`	`315`	`\|\| (Environment.OSVersion.Version < new Version(10, 0) && !enableHttp2OnWindows81))`
`315`	`316`	`{`
`316`	`317`	`return true;`