Feedback

Author: benaadams

src/Middleware/HostFiltering/src/HostFilteringMiddleware.cs

@@ -160,7 +160,7 @@ private bool CheckHost(HttpContext context, IList<StringSegment> allowedHosts)
         {
             var host = context.Request.Headers[HeaderNames.Host].ToString();
 
-            if (0u >= (uint)host.Length)
+            if (host.Length == 0)
             {
                 return IsEmptyHostAllowed(context);
             }

src/Middleware/HostFiltering/test/HostFilteringMiddlewareTests.cs

@@ -97,37 +97,6 @@ public async Task AllowsEmptyHost(bool allowed, int status)
             Assert.Equal(status, (int)response.StatusCode);
         }
 
-        [Fact]
-        public async Task WhitespaceHostRejected()
-        {
-            var builder = new WebHostBuilder()
-                .ConfigureServices(services =>
-                {
-                    services.AddHostFiltering(options =>
-                    {
-                        options.AllowEmptyHosts = true;
-                        options.AllowedHosts.Add("Localhost");
-                    });
-                })
-                .Configure(app =>
-                {
-                    app.Use((ctx, next) =>
-                    {
-                        ctx.Request.Headers[HeaderNames.Host] = " ";
-                        return next();
-                    });
-                    app.UseHostFiltering();
-                    app.Run(c =>
-                    {
-                        return Task.CompletedTask;
-                    });
-                    app.Run(c => Task.CompletedTask);
-                });
-            var server = new TestServer(builder);
-            var response = await server.CreateClient().GetAsync("/");
-            Assert.Equal(400, (int)response.StatusCode);
-        }
-
         [Theory]
         [InlineData("localHost", "localhost")]
         [InlineData("localHost", "*")] // Any - Used by HttpSys