more fixups

Author: BrennanConroy

src/SignalR/server/Core/src/SerializedHubMessage.cs

@@ -70,11 +70,8 @@ public ReadOnlyMemory<byte> GetSerializedMessage(IHubProtocol protocol)
             }
         }
 
-        /// <summary>
-        /// Gets all serialized hub messages for all protocols used on this <see cref="SerializedHubMessage"/> instance.
-        /// </summary>
-        /// <returns>An <see cref="IEnumerable{T}"/> of already serialized hub messages for each protocol.</returns>
-        public IReadOnlyList<SerializedMessage> GetAllSerializations()
+        // Used for unit testing.
+        internal IReadOnlyList<SerializedMessage> GetAllSerializations()
         {
             // Even if this is only used in tests, let's do it right.
             lock (_lock)

src/SignalR/server/StackExchangeRedis/src/Internal/DefaultHubMessageSerializer.cs

@@ -25,15 +25,15 @@ public DefaultHubMessageSerializer(IHubProtocolResolver hubProtocolResolver, ILi
             }
         }
 
-        public SerializedHubMessage SerializeMessage(HubMessage message)
+        public IReadOnlyList<SerializedMessage> SerializeMessage(HubMessage message)
         {
             var list = new List<SerializedMessage>(_hubProtocols.Count);
             foreach (var protocol in _hubProtocols)
             {
                 list.Add(new SerializedMessage(protocol.Name, protocol.GetMessageBytes(message)));
             }
 
-            return new SerializedHubMessage(list);
+            return list;
         }
     }
 }

src/SignalR/server/StackExchangeRedis/src/Internal/RedisProtocol.cs

@@ -190,12 +190,11 @@ private void WriteHubMessage(Stream stream, HubMessage message)
             }
             else
             {
-                var serializedHubMessage = _messageSerializer.SerializeMessage(message);
-                var serializedMessages = serializedHubMessage.GetAllSerializations();
+                var serializedHubMessages = _messageSerializer.SerializeMessage(message);
 
-                MessagePackBinary.WriteMapHeader(stream, serializedMessages.Count);
+                MessagePackBinary.WriteMapHeader(stream, serializedHubMessages.Count);
 
-                foreach (var serializedMessage in serializedMessages)
+                foreach (var serializedMessage in serializedHubMessages)
                 {
                     MessagePackBinary.WriteString(stream, serializedMessage.ProtocolName);
 

src/SignalR/server/StackExchangeRedis/test/DefaultHubMessageSerializerTests.cs

@@ -27,11 +27,9 @@ public void SerializeMessages(string testName)
             var serializer = new DefaultHubMessageSerializer(resolver, protocolNames, hubSupportedProtocols: null);
             var serializedHubMessage = serializer.SerializeMessage(_testMessage);
 
-            var serializedMessages = serializedHubMessage.GetAllSerializations();
-
             var allBytes = new List<byte>();
-            Assert.Equal(testData.SerializedCount, serializedMessages.Count);
-            foreach (var message in serializedMessages)
+            Assert.Equal(testData.SerializedCount, serializedHubMessage.Count);
+            foreach (var message in serializedHubMessage)
             {
                 allBytes.AddRange(message.Serialized.ToArray());
             }