Fix subscription callbacks when unsubscribe

hermanho · hermanho · commit 31d2ad89720a · 2019-10-24T03:15:53.000+08:00
Fix subscription _callbacks array is re-assign when unsubscribe in AuthorizeService.js in React template
diff --git a/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/React-CSharp/ClientApp/src/components/api-authorization/AuthorizeService.js b/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/React-CSharp/ClientApp/src/components/api-authorization/AuthorizeService.js
@@ -148,7 +148,7 @@ export class AuthorizeService {
             throw new Error(`Found an invalid number of subscriptions ${subscriptionIndex.length}`);
         }
 
-        this._callbacks = this._callbacks.splice(subscriptionIndex[0].index, 1);
+        this._callbacks.splice(subscriptionIndex[0].index, 1);
     }
 
     notifySubscribers() {

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ export class AuthorizeService {`
`148`	`148`	throw new Error(`Found an invalid number of subscriptions ${subscriptionIndex.length}`);
`149`	`149`	`}`
`150`	`150`
`151`		`- this._callbacks = this._callbacks.splice(subscriptionIndex[0].index, 1);`
	`151`	`+ this._callbacks.splice(subscriptionIndex[0].index, 1);`
`152`	`152`	`}`
`153`	`153`
`154`	`154`	`notifySubscribers() {`