Skip to content

Commit 383a272

Browse files
authored
Quarantine falky test ServerEventTest.EventDuringBatchRendering_CanTriggerDOMEvents (#24691)
* Quarantine falky test ServerEventTest.EventDuringBatchRendering_CanTriggerDOMEvents Blazor's E2E testing uses a much shorter timeout after a test failure. This test run had several test failures, but most of these appear to be the result of an incredibly short timeot. This PR quarantines the one test that appears to be a genuine failure and also increases the timeout duration for after test failure. * Quarantine ServerExecutionTests.ServerGlobalizationTest.CanSetCultureAndParseCultureSensitiveNumbersAndDates
1 parent 39f18c0 commit 383a272

File tree

6 files changed

+41
-11
lines changed

6 files changed

+41
-11
lines changed
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
// Copyright (c) .NET Foundation. All rights reserved.
2+
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
3+
4+
using BasicTestApp;
5+
using Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures;
6+
using Microsoft.AspNetCore.Components.E2ETest.Tests;
7+
using Microsoft.AspNetCore.E2ETesting;
8+
using Microsoft.AspNetCore.Testing;
9+
using Xunit;
10+
using Xunit.Abstractions;
11+
12+
namespace Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests
13+
{
14+
public class ServerEventTest : EventTest
15+
{
16+
public ServerEventTest(BrowserFixture browserFixture, ToggleExecutionModeServerFixture<Program> serverFixture, ITestOutputHelper output)
17+
: base(browserFixture, serverFixture.WithServerExecution(), output)
18+
{
19+
}
20+
21+
[Fact]
22+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24688")]
23+
public override void EventDuringBatchRendering_CanTriggerDOMEvents()
24+
{
25+
base.EventDuringBatchRendering_CanTriggerDOMEvents();
26+
}
27+
}
28+
}

src/Components/test/E2ETest/ServerExecutionTests/ServerGlobalizationTest.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
using Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures;
77
using Microsoft.AspNetCore.Components.E2ETests.Tests;
88
using Microsoft.AspNetCore.E2ETesting;
9+
using Microsoft.AspNetCore.Testing;
910
using OpenQA.Selenium;
1011
using OpenQA.Selenium.Support.UI;
1112
using TestServer;
@@ -33,6 +34,15 @@ protected override void InitializeAsyncCore()
3334
Browser.Exists(By.Id("culture-selector"));
3435
}
3536

37+
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24692")]
38+
[Theory]
39+
[InlineData("en-US")]
40+
[InlineData("fr-FR")]
41+
public override void CanSetCultureAndParseCultureSensitiveNumbersAndDates(string culture)
42+
{
43+
base.CanSetCultureAndParseCultureSensitiveNumbersAndDates(culture);
44+
}
45+
3646
protected override void SetCulture(string culture)
3747
{
3848
var selector = new SelectElement(Browser.FindElement(By.Id("culture-selector")));

src/Components/test/E2ETest/ServerExecutionTests/TestSubclasses.cs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,6 @@ public ServerEventBubblingTest(BrowserFixture browserFixture, ToggleExecutionMod
2525
}
2626
}
2727

28-
public class ServerEventTest : EventTest
29-
{
30-
public ServerEventTest(BrowserFixture browserFixture, ToggleExecutionModeServerFixture<Program> serverFixture, ITestOutputHelper output)
31-
: base(browserFixture, serverFixture.WithServerExecution(), output)
32-
{
33-
}
34-
}
35-
3628
public class ServerInteropTest : InteropTest
3729
{
3830
public ServerInteropTest(BrowserFixture browserFixture, ToggleExecutionModeServerFixture<Program> serverFixture, ITestOutputHelper output)

src/Components/test/E2ETest/Tests/EventTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ public void InteractiveElementWithDisabledAttributeDoesNotRespondToMouseEvents(s
258258
}
259259

260260
[Fact]
261-
public void EventDuringBatchRendering_CanTriggerDOMEvents()
261+
public virtual void EventDuringBatchRendering_CanTriggerDOMEvents()
262262
{
263263
Browser.MountTestComponent<EventDuringBatchRendering>();
264264

src/Components/test/E2ETest/Tests/GlobalizationTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public GlobalizationTest(BrowserFixture browserFixture, TServerFixture serverFix
2626
[Theory]
2727
[InlineData("en-US")]
2828
[InlineData("fr-FR")]
29-
public void CanSetCultureAndParseCultureSensitiveNumbersAndDates(string culture)
29+
public virtual void CanSetCultureAndParseCultureSensitiveNumbersAndDates(string culture)
3030
{
3131
var cultureInfo = CultureInfo.GetCultureInfo(culture);
3232
SetCulture(culture);

src/Shared/E2ETesting/E2ETestOptions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ static E2ETestOptions()
5555

5656
public string ScreenShotsPath { get; set; }
5757

58-
public double DefaultAfterFailureWaitTimeoutInSeconds { get; set; } = 3;
58+
public double DefaultAfterFailureWaitTimeoutInSeconds { get; set; } = 10;
5959

6060
public bool SauceTest { get; set; }
6161

0 commit comments

Comments
 (0)