Update BrowserManager.cs

HaoK · HaoK · commit 3cccb3cffa53 · 2021-03-10T20:18:50.000-08:00
diff --git a/src/Shared/BrowserTesting/src/BrowserManager.cs b/src/Shared/BrowserTesting/src/BrowserManager.cs
@@ -48,11 +48,9 @@ private async Task InitializeAsync()
             async Task InitializeCore()
             {
                 // Work around weird driverExecutable lookup logic
-                var helixDirectory = Environment.GetEnvironmentVariable("HELIX_WORKITEM_ROOT");
-                if (string.IsNullOrEmpty(helixDirectory)) 
+                var driverPath = Environment.GetEnvironmentVariable("PLAYWRIGHT_DRIVER_PATH");
+                if (string.IsNullOrEmpty(driverPath)) 
                 {
-                    var driverPath = Path.Combine(helixDirectory,
-                        RuntimeInformation.IsOSPlatform(OSPlatform.OSX) || RuntimeInformation.IsOSPlatform(OSPlatform.Linux) ? "playwright.sh" : "playwright.cmd");
                     Playwright = await PlaywrightSharp.Playwright.CreateAsync(_loggerFactory, driverExecutablePath: driverPath /*, debug: "pw:api"*/);
                 }
                 else

Original file line number	Diff line number	Diff line change
`@@ -48,11 +48,9 @@ private async Task InitializeAsync()`
`48`	`48`	`async Task InitializeCore()`
`49`	`49`	`{`
`50`	`50`	`// Work around weird driverExecutable lookup logic`
`51`		`- var helixDirectory = Environment.GetEnvironmentVariable("HELIX_WORKITEM_ROOT");`
`52`		`- if (string.IsNullOrEmpty(helixDirectory))`
	`51`	`+ var driverPath = Environment.GetEnvironmentVariable("PLAYWRIGHT_DRIVER_PATH");`
	`52`	`+ if (string.IsNullOrEmpty(driverPath))`
`53`	`53`	`{`
`54`		`- var driverPath = Path.Combine(helixDirectory,`
`55`		`- RuntimeInformation.IsOSPlatform(OSPlatform.OSX) \|\| RuntimeInformation.IsOSPlatform(OSPlatform.Linux) ? "playwright.sh" : "playwright.cmd");`
`56`	`54`	`Playwright = await PlaywrightSharp.Playwright.CreateAsync(_loggerFactory, driverExecutablePath: driverPath /, debug: "pw:api"/);`
`57`	`55`	`}`
`58`	`56`	`else`