Skip to content

Commit 44c150b

Browse files
committed
!revert! Always test against latest Fx
- unconditionally test against just-built Microsoft.AspNetCore.App.Runtime - `<Copy/>` shared Fx assemblies into work item root
1 parent 817ade1 commit 44c150b

File tree

1 file changed

+23
-0
lines changed

1 file changed

+23
-0
lines changed

eng/targets/Helix.targets

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,11 @@
3535
<HelixPreCommand Include="call RunPowershell.cmd InstallNode.ps1 $(NodeVersion) || exit /b 1" />
3636
</ItemGroup>
3737

38+
<!-- Heavy hammer: Run every test using shared Fx bits. -->
39+
<PropertyGroup>
40+
<TestDependsOnAspNetRuntime>true</TestDependsOnAspNetRuntime>
41+
</PropertyGroup>
42+
3843
<!-- $(TestDependsOnAspNetRuntime) implies $(TestDependsOnAspNetPackages). Separate for the App.UnitTests case. -->
3944
<PropertyGroup Condition=" $(TestDependsOnAspNetRuntime) AND !$(TestDependsOnAspNetPackages) ">
4045
<TestDependsOnAspNetPackages>true</TestDependsOnAspNetPackages>
@@ -171,6 +176,24 @@
171176
<ConvertToAbsolutePath Paths="$(PublishDir)">
172177
<Output TaskParameter="AbsolutePaths" PropertyName="PublishAbsoluteDir" />
173178
</ConvertToAbsolutePath>
179+
180+
<!-- Another heavy hammer: Overwrite assemblies from work item payload with those found in shared Fx. -->
181+
<ItemGroup>
182+
<_FilesFromSharedFx Include="$(LocalDotNetRoot)shared\$(SharedFxName)\$(SharedFxVersion)\*.dll" />
183+
<_FilesFromPublish Include="$(PublishAbsoluteDir)*.dll" />
184+
</ItemGroup>
185+
<JoinItems Left="@(_FilesFromSharedFx)" Right="@(_FilesFromPublish)"
186+
LeftKey="Filename" RightKey="Filename"
187+
ItemSpecToUse="Left">
188+
<Output TaskParameter="JoinResult" ItemName="_FilesToOverwrite" />
189+
</JoinItems>
190+
<Copy SourceFiles="@(_FilesToOverwrite)"
191+
DestinationFolder="$(PublishAbsoluteDir)"
192+
OverwriteReadOnlyFiles="$(OverwriteReadOnlyFiles)"
193+
Retries="$(CopyRetryCount)"
194+
RetryDelayMilliseconds="$(CopyRetryDelayMilliseconds)"
195+
SkipUnchangedFiles="$(SkipCopyUnchangedFiles)" />
196+
174197
<ItemGroup>
175198
<HelixWorkItem Include="$(HelixTestName)">
176199
<PayloadDirectory>$(PublishAbsoluteDir)</PayloadDirectory>

0 commit comments

Comments
 (0)