PR Cleanup

Author: Tratcher

src/Servers/HttpSys/src/HttpSysOptions.cs

@@ -95,7 +95,7 @@ public string RequestQueueName
         /// <summary>
         /// Gets or sets the maximum number of concurrent connections to accept, -1 for infinite, or null to
         /// use the machine wide setting from the registry. The default value is null.
-        /// This settings do not apply when attaching to an existing queue.
+        /// This settings does not apply when attaching to an existing queue.
         /// </summary>
         public long? MaxConnections
         {
@@ -118,7 +118,7 @@ public long? MaxConnections
 
         /// <summary>
         /// Gets or sets the maximum number of requests that will be queued up in Http.Sys.
-        /// This settings do not apply when attaching to an existing queue.
+        /// This settings does not apply when attaching to an existing queue.
         /// </summary>
         public long RequestQueueLimit
         {
@@ -133,7 +133,7 @@ public long RequestQueueLimit
                     throw new ArgumentOutOfRangeException(nameof(value), value, "The value must be greater than zero.");
                 }
 
-                if (_requestQueue != null && _requestQueue.Created)
+                if (_requestQueue != null)
                 {
                     _requestQueue.SetLengthLimit(_requestQueueLength);
                 }
@@ -174,7 +174,7 @@ public long? MaxRequestBodySize
         /// Gets or sets a value that controls how http.sys reacts when rejecting requests due to throttling conditions - like when the request
         /// queue limit is reached. The default in http.sys is "Basic" which means http.sys is just resetting the TCP connection. IIS uses Limited
         /// as its default behavior which will result in sending back a 503 - Service Unavailable back to the client.
-        /// These settings do not apply when attaching to an existing queue.
+        /// This settings does not apply when attaching to an existing queue.
         /// </summary>
         public Http503VerbosityLevel Http503Verbosity
         {

src/Servers/HttpSys/src/NativeInterop/RequestQueue.cs

@@ -2,6 +2,7 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
+using System.Diagnostics;
 using System.Runtime.InteropServices;
 using System.Threading;
 using Microsoft.AspNetCore.HttpSys.Internal;
@@ -42,7 +43,7 @@ internal RequestQueue(UrlGroup urlGroup, string requestQueueName, RequestQueueMo
 
             if (_mode == RequestQueueMode.CreateOrAttach && statusCode == UnsafeNclNativeMethods.ErrorCodes.ERROR_ALREADY_EXISTS)
             {
-                // Tried to create, but it already exist so attach to it instead.
+                // Tried to create, but it already exists so attach to it instead.
                 Created = false;
                 flags = HttpApiTypes.HTTP_CREATE_REQUEST_QUEUE_FLAG.OpenExisting;
                 statusCode = HttpApi.HttpCreateRequestQueue(
@@ -87,7 +88,7 @@ internal RequestQueue(UrlGroup urlGroup, string requestQueueName, RequestQueueMo
         }
 
         /// <summary>
-        /// Set true if we created queue instead of attaching to existing
+        /// True if this instace created the queue instead of attaching to an existing one.
         /// </summary>
         internal bool Created { get; }
 
@@ -96,6 +97,7 @@ internal RequestQueue(UrlGroup urlGroup, string requestQueueName, RequestQueueMo
 
         internal unsafe void AttachToUrlGroup()
         {
+            Debug.Assert(Created);
             CheckDisposed();
             // Set the association between request queue and url group. After this, requests for registered urls will 
             // get delivered to this request queue.
@@ -112,6 +114,7 @@ internal unsafe void AttachToUrlGroup()
 
         internal unsafe void DetachFromUrlGroup()
         {
+            Debug.Assert(Created);
             CheckDisposed();
             // Break the association between request queue and url group. After this, requests for registered urls 
             // will get 503s.
@@ -132,6 +135,7 @@ internal unsafe void DetachFromUrlGroup()
         // The listener must be active for this to work.
         internal unsafe void SetLengthLimit(long length)
         {
+            Debug.Assert(Created);
             CheckDisposed();
 
             var result = HttpApi.HttpSetRequestQueueProperty(Handle,
@@ -147,6 +151,7 @@ internal unsafe void SetLengthLimit(long length)
         // The listener must be active for this to work.
         internal unsafe void SetRejectionVerbosity(Http503VerbosityLevel verbosity)
         {
+            Debug.Assert(Created);
             CheckDisposed();
 
             var result = HttpApi.HttpSetRequestQueueProperty(Handle,

src/Servers/HttpSys/src/RequestProcessing/Request.cs

@@ -11,8 +11,6 @@
 using System.Security.Principal;
 using System.Threading;
 using System.Threading.Tasks;
-using Microsoft.AspNetCore.Builder;
-using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.HttpSys.Internal;
 
 namespace Microsoft.AspNetCore.Server.HttpSys