Skip to content

Commit 4f5bf16

Browse files
authored
Show debugger attach message (#21483)
Also spruce up branding
1 parent 9e412f4 commit 4f5bf16

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/Components/Web.JS/dist/Release/blazor.webassembly.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Components/Web.JS/src/Platform/Mono/MonoDebugger.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,22 +10,22 @@ export function hasDebuggingEnabled() {
1010
}
1111

1212
export function attachDebuggerHotkey(resourceLoader: WebAssemblyResourceLoader) {
13+
hasReferencedPdbs = !!resourceLoader.bootConfig.resources.pdb;
14+
1315
// Use the combination shift+alt+D because it isn't used by the major browsers
1416
// for anything else by default
1517
const altKeyName = navigator.platform.match(/^Mac/i) ? 'Cmd' : 'Alt';
1618
if (hasDebuggingEnabled()) {
1719
console.info(`Debugging hotkey: Shift+${altKeyName}+D (when application has focus)`);
1820
}
1921

20-
hasReferencedPdbs = !!resourceLoader.bootConfig.resources.pdb;
21-
2222
// Even if debugging isn't enabled, we register the hotkey so we can report why it's not enabled
2323
document.addEventListener('keydown', evt => {
2424
if (evt.shiftKey && (evt.metaKey || evt.altKey) && evt.code === 'KeyD') {
2525
if (!hasReferencedPdbs) {
2626
console.error('Cannot start debugging, because the application was not compiled with debugging enabled.');
2727
} else if (!currentBrowserIsChrome) {
28-
console.error('Currently, only Edge(Chromium) or Chrome is supported for debugging.');
28+
console.error('Currently, only Microsoft Edge (80+), or Google Chrome, are supported for debugging.');
2929
} else {
3030
launchDebugger();
3131
}

src/Components/WebAssembly/DebugProxy/src/TargetPickerUi.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ Ensure your browser is running with debugging enabled.
5858
{GetLaunchChromeInstructions(targetApplicationUrl)}
5959
</p>
6060
<p>
61-
<h4>If you are using Microsoft Edge (Chromium) for your development, follow these instructions:</h4>
61+
<h4>If you are using Microsoft Edge (80+) for your development, follow these instructions:</h4>
6262
{GetLaunchEdgeInstructions(targetApplicationUrl)}
6363
</p>
6464
<strong>This should launch a new browser window with debugging enabled..</p>

0 commit comments

Comments
 (0)