Skip to content

Commit 5b6d1a3

Browse files
committed
!fixup! Undo a couple of earlier fixes
- remove a duplicate `$()` setting - correct the one remaining versioned `#if` define - did not make it `#if NETCOREAPP` because benchmarks test numerous .NET Core TFMs
1 parent 6ba1916 commit 5b6d1a3

File tree

3 files changed

+2
-5
lines changed

3 files changed

+2
-5
lines changed

src/ProjectTemplates/Directory.Build.props

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory)..\, Directory.Build.props))\Directory.Build.props" />
33

44
<PropertyGroup>
5-
<!-- TODO: Remove this when alls parts of aspnetcore switched to the net5.0 TFM. -->
6-
<DefaultNetCoreTargetFramework>net5.0</DefaultNetCoreTargetFramework>
7-
85
<!-- The .csproj files in this folder do not actually produce .dll's. They are only present to produce .nupkgs and enable Visual Studio support -->
96
<IsProjectReferenceProvider>false</IsProjectReferenceProvider>
107
<HasReferenceAssembly>false</HasReferenceAssembly>

src/ProjectTemplates/build.cmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
@ECHO OFF
22
SET RepoRoot=%~dp0..\..
3-
%RepoRoot%\build.cmd -projects %~dp0*\*.*proj -ForceCoreMsbuild "/p:EnforceE2ETestPrerequisites=true" %*
3+
%RepoRoot%\build.cmd -projects %~dp0*\*.*proj "/p:EnforceE2ETestPrerequisites=true" %*

src/Shared/BenchmarkRunner/DefaultCoreConfig.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public DefaultCoreConfig()
3434
.WithToolchain(CsProjCoreToolchain.From(new NetCoreAppSettings("netcoreapp3.0", null, ".NET Core 3.0")))
3535
#elif NETCOREAPP3_1
3636
.WithToolchain(CsProjCoreToolchain.From(new NetCoreAppSettings("netcoreapp3.1", null, ".NET Core 3.1")))
37-
#elif NET5_0
37+
#elif NETCOREAPP5_0
3838
.WithToolchain(CsProjCoreToolchain.From(new NetCoreAppSettings("net5.0", null, ".NET Core 5.0")))
3939
#else
4040
#error Target frameworks need to be updated.

0 commit comments

Comments
 (0)