bit more feedback

jkotalik · jkotalik · commit 5f8258ca2ede · 2019-03-05T15:48:13.000-08:00
diff --git a/src/Servers/Kestrel/Core/src/Internal/Http/Http1OutputProducer.cs b/src/Servers/Kestrel/Core/src/Internal/Http/Http1OutputProducer.cs
@@ -217,7 +217,7 @@ public void Advance(int bytes)
                 {
                     if (bytes >= 0)
                     {
-                        if (_currentSegment.Length < _position + bytes)
+                        if (_currentSegment.Length - bytes < _position)
                         {
                             throw new ArgumentOutOfRangeException("Can't advance past buffer size.");
                         }
@@ -227,7 +227,7 @@ public void Advance(int bytes)
                 }
                 else if (_autoChunk)
                 {
-                    if (bytes + _advancedBytesForChunk > _currentChunkMemory.Length - BeginChunkLengthMax - EndChunkLength)
+                    if (_advancedBytesForChunk > _currentChunkMemory.Length - BeginChunkLengthMax - EndChunkLength - bytes)
                     {
                         throw new ArgumentOutOfRangeException("Can't advance past buffer size.");
                     }

Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,7 @@ public void Advance(int bytes)`
`217`	`217`	`{`
`218`	`218`	`if (bytes >= 0)`
`219`	`219`	`{`
`220`		`- if (_currentSegment.Length < _position + bytes)`
	`220`	`+ if (_currentSegment.Length - bytes < _position)`
`221`	`221`	`{`
`222`	`222`	`throw new ArgumentOutOfRangeException("Can't advance past buffer size.");`
`223`	`223`	`}`
`@@ -227,7 +227,7 @@ public void Advance(int bytes)`
`227`	`227`	`}`
`228`	`228`	`else if (_autoChunk)`
`229`	`229`	`{`
`230`		`- if (bytes + _advancedBytesForChunk > _currentChunkMemory.Length - BeginChunkLengthMax - EndChunkLength)`
	`230`	`+ if (_advancedBytesForChunk > _currentChunkMemory.Length - BeginChunkLengthMax - EndChunkLength - bytes)`
`231`	`231`	`{`
`232`	`232`	`throw new ArgumentOutOfRangeException("Can't advance past buffer size.");`
`233`	`233`	`}`