Skip to content

Commit 6269162

Browse files
committed
Rename setting
1 parent 9889f80 commit 6269162

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

src/Servers/Kestrel/Core/ref/Microsoft.AspNetCore.Server.Kestrel.Core.netcoreapp.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ internal BadHttpRequestException() { }
7070
public partial class Http2Limits
7171
{
7272
public Http2Limits() { }
73-
public bool EnableResponseHeaderCompression { [System.Runtime.CompilerServices.CompilerGeneratedAttribute] get { throw null; } [System.Runtime.CompilerServices.CompilerGeneratedAttribute] set { } }
73+
public bool AllowResponseHeaderCompression { [System.Runtime.CompilerServices.CompilerGeneratedAttribute] get { throw null; } [System.Runtime.CompilerServices.CompilerGeneratedAttribute] set { } }
7474
public int HeaderTableSize { get { throw null; } set { } }
7575
public int InitialConnectionWindowSize { get { throw null; } set { } }
7676
public int InitialStreamWindowSize { get { throw null; } set { } }

src/Servers/Kestrel/Core/src/Http2Limits.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,13 +143,13 @@ public int InitialStreamWindowSize
143143
}
144144

145145
/// <summary>
146-
/// Gets or sets a value that controls whether dynamic compression of response headers is enabled.
147-
/// For more information about security considerations of HPack dynamic header compression, visit
146+
/// Gets or sets a value that controls whether dynamic compression of response headers is allowed.
147+
/// For more information about the security considerations of HPack dynamic header compression, visit
148148
/// https://tools.ietf.org/html/rfc7541#section-7.
149149
/// </summary>
150150
/// <remarks>
151151
/// Defaults to true.
152152
/// </remarks>
153-
public bool EnableResponseHeaderCompression { get; set; } = true;
153+
public bool AllowResponseHeaderCompression { get; set; } = true;
154154
}
155155
}

src/Servers/Kestrel/Core/src/Internal/Http2/Http2FrameWriter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public Http2FrameWriter(
7171
_outgoingFrame = new Http2Frame();
7272
_headerEncodingBuffer = new byte[_maxFrameSize];
7373

74-
_hpackEncoder = new HPackEncoder(!serviceContext.ServerOptions.Limits.Http2.EnableResponseHeaderCompression);
74+
_hpackEncoder = new HPackEncoder(!serviceContext.ServerOptions.Limits.Http2.AllowResponseHeaderCompression);
7575
}
7676

7777
public void UpdateMaxHeaderTableSize(uint maxHeaderTableSize)

src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1909,7 +1909,7 @@ await ExpectAsync(Http2FrameType.HEADERS,
19091909
[Fact]
19101910
public async Task HEADERS_DisableDynamicHeaderCompression_HeadersNotCompressed()
19111911
{
1912-
_serviceContext.ServerOptions.Limits.Http2.EnableResponseHeaderCompression = false;
1912+
_serviceContext.ServerOptions.Limits.Http2.AllowResponseHeaderCompression = false;
19131913

19141914
await InitializeConnectionAsync(_noopApplication);
19151915

0 commit comments

Comments
 (0)