Remove 2.x workaround for BindModel_ReturnsModel_IfAttemptedValueIsValid_FrenchThirtyTwoThousandPointOne failure

John Luo · John Luo · commit 67b665208c94 · 2019-06-06T11:46:22.000-07:00
diff --git a/src/Mvc/Mvc.Core/test/ModelBinding/Binders/FloatingPointTypeModelBinderTestOfT.cs b/src/Mvc/Mvc.Core/test/ModelBinding/Binders/FloatingPointTypeModelBinderTestOfT.cs
@@ -342,8 +342,7 @@ public async Task BindModel_ReturnsModel_IfAttemptedValueIsValid_ThirtyTwoThousa
             Assert.True(bindingContext.ModelState.ContainsKey("theModelName"));
         }
 
-        [ConditionalTheory]
-        [OSSkipCondition(OperatingSystems.Linux, SkipReason = "https://github.com/aspnet/AspNetCore-Internal/issues/2626")]
+        [Theory]
         [MemberData(nameof(ConvertibleTypeData))]
         [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2626", FlakyOn.AzP.Linux)]
         public async Task BindModel_ReturnsModel_IfAttemptedValueIsValid_FrenchThirtyTwoThousandPointOne(Type destinationType)

Original file line number	Diff line number	Diff line change
`@@ -342,8 +342,7 @@ public async Task BindModel_ReturnsModel_IfAttemptedValueIsValid_ThirtyTwoThousa`
`342`	`342`	`Assert.True(bindingContext.ModelState.ContainsKey("theModelName"));`
`343`	`343`	`}`
`344`	`344`
`345`		`- [ConditionalTheory]`
`346`		`- [OSSkipCondition(OperatingSystems.Linux, SkipReason = "https://github.com/aspnet/AspNetCore-Internal/issues/2626")]`
	`345`	`+ [Theory]`
`347`	`346`	`[MemberData(nameof(ConvertibleTypeData))]`
`348`	`347`	`[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2626", FlakyOn.AzP.Linux)]`
`349`	`348`	`public async Task BindModel_ReturnsModel_IfAttemptedValueIsValid_FrenchThirtyTwoThousandPointOne(Type destinationType)`