Skip to content

Commit 6ad0d58

Browse files
author
John Luo
authored
Merge branch 'master' into johluo/remove-extensions-deps
2 parents cb5f656 + 3ec1676 commit 6ad0d58

File tree

130 files changed

+4497
-809
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

130 files changed

+4497
-809
lines changed

‎.azure/pipelines/ci.yml

Lines changed: 24 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ variables:
7171
# The following extra properties are not set when testing. Use with final build.[cmd,sh] of asset-producing jobs.
7272
- name: _PublishArgs
7373
value: /p:Publish=true
74+
/p:GenerateChecksums=true
7475
/p:DotNetPublishBlobFeedKey=$(dotnetfeed-storage-access-key-1)
7576
/p:DotNetPublishBlobFeedUrl=https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json
7677
/p:DotNetPublishToBlobFeed=$(_DotNetPublishToBlobFeed)
@@ -92,27 +93,28 @@ stages:
9293
displayName: Build
9394
jobs:
9495
# Code check
95-
- template: jobs/default-build.yml
96-
parameters:
97-
jobName: Code_check
98-
jobDisplayName: Code check
99-
agentOs: Windows
100-
steps:
101-
- ${{ if ne(variables['System.TeamProject'], 'public') }}:
102-
- task: PowerShell@2
103-
displayName: Setup Private Feeds Credentials
104-
inputs:
105-
filePath: $(Build.SourcesDirectory)/eng/common/SetupNugetSources.ps1
106-
arguments: -ConfigFile $(Build.SourcesDirectory)/NuGet.config -Password $Env:Token
107-
env:
108-
Token: $(dn-bot-dnceng-artifact-feeds-rw)
109-
- powershell: ./eng/scripts/CodeCheck.ps1 -ci $(_InternalRuntimeDownloadArgs)
110-
displayName: Run eng/scripts/CodeCheck.ps1
111-
artifacts:
112-
- name: Code_Check_Logs
113-
path: artifacts/log/
114-
publishOnError: true
115-
includeForks: true
96+
- ${{ if or(eq(variables['System.TeamProject'], 'public'), in(variables['Build.Reason'], 'PullRequest')) }}:
97+
- template: jobs/default-build.yml
98+
parameters:
99+
jobName: Code_check
100+
jobDisplayName: Code check
101+
agentOs: Windows
102+
steps:
103+
- ${{ if ne(variables['System.TeamProject'], 'public') }}:
104+
- task: PowerShell@2
105+
displayName: Setup Private Feeds Credentials
106+
inputs:
107+
filePath: $(Build.SourcesDirectory)/eng/common/SetupNugetSources.ps1
108+
arguments: -ConfigFile $(Build.SourcesDirectory)/NuGet.config -Password $Env:Token
109+
env:
110+
Token: $(dn-bot-dnceng-artifact-feeds-rw)
111+
- powershell: ./eng/scripts/CodeCheck.ps1 -ci $(_InternalRuntimeDownloadArgs)
112+
displayName: Run eng/scripts/CodeCheck.ps1
113+
artifacts:
114+
- name: Code_Check_Logs
115+
path: artifacts/log/
116+
publishOnError: true
117+
includeForks: true
116118

117119
# Build Windows (x64/x86)
118120
- template: jobs/default-build.yml
@@ -594,7 +596,7 @@ stages:
594596
parameters:
595597
condition: ne(variables['SkipTests'], 'true')
596598
jobName: MacOS_Test
597-
jobDisplayName: "Test: macOS 10.13"
599+
jobDisplayName: "Test: macOS 10.14"
598600
agentOs: macOS
599601
isTestingJob: true
600602
buildArgs: --all --test "/p:RunTemplateTests=false /p:SkipHelixReadyTests=true" $(_InternalRuntimeDownloadArgs)

‎CODE-OF-CONDUCT.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
# Code of Conduct
2+
3+
This project has adopted the code of conduct defined by the Contributor Covenant
4+
to clarify expected behavior in our community.
5+
6+
For more information, see the [.NET Foundation Code of Conduct](https://dotnetfoundation.org/code-of-conduct).

‎CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,4 +57,4 @@ Your pull request will now go through extensive checks by the subject matter exp
5757

5858
## Code of conduct
5959

60-
This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information, see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [[email protected]](mailto:[email protected]) with any additional questions or comments.
60+
See [CODE-OF-CONDUCT.md](./CODE-OF-CONDUCT.md)

‎Directory.Build.props

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,6 @@
189189

190190
<ArchiveExtension>.tar.gz</ArchiveExtension>
191191
<ArchiveExtension Condition="'$(TargetOsName)' == 'win'">.zip</ArchiveExtension>
192-
<ChecksumExtension>.sha512</ChecksumExtension>
193192
</PropertyGroup>
194193

195194
<Import Project="eng\Workarounds.props" />

‎README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Follow the [Getting Started](https://docs.microsoft.com/aspnet/core/getting-star
99

1010
Also check out the [.NET Homepage](https://www.microsoft.com/net) for released versions of .NET, getting started guides, and learning resources.
1111

12-
See the [Issue Management Policies](https://github.com/dotnet/aspnetcore/blob/anurse/issue-policies/docs/IssueManagementPolicies.md) document for more information on how we handle incoming issues.
12+
See the [Issue Management Policies](https://github.com/dotnet/aspnetcore/blob/master/docs/IssueManagementPolicies.md) document for more information on how we handle incoming issues.
1313

1414
## How to Engage, Contribute, and Give Feedback
1515

@@ -37,4 +37,4 @@ These are some other repos for related projects:
3737

3838
## Code of conduct
3939

40-
This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [[email protected]](mailto:[email protected]) with any additional questions or comments.
40+
See [CODE-OF-CONDUCT](./CODE-OF-CONDUCT.md)

‎eng/AfterSigning.targets

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
<Project>
2+
3+
<Import Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" Condition="'$(GenerateChecksums)' == 'true'" />
4+
5+
<PropertyGroup Condition="'$(GenerateChecksums)' == 'true'">
6+
<!-- The one use of ArtifactsDir in Publish.proj adds an additional slash, confusing itself. -->
7+
<ArtifactsDir Condition=" HasTrailingSlash('$(ArtifactsDir)') ">$(ArtifactsDir.Substring(0, $([MSBuild]::Subtract($(ArtifactsDir.Length), 1))))</ArtifactsDir>
8+
<!-- $(InstallersOutputPath) is not defined. Root Directory.Build.props is not imported. -->
9+
<InstallersOutputPath>$(ArtifactsDir)\installers\</InstallersOutputPath>
10+
</PropertyGroup>
11+
12+
<Target Name="PopulateGenerateChecksumItems"
13+
Condition="'$(GenerateChecksums)' == 'true'"
14+
AfterTargets="Build"
15+
BeforeTargets="GenerateChecksums" >
16+
17+
<ItemGroup>
18+
<InstallerFiles Include="$(InstallersOutputPath)**\*.msi" />
19+
<InstallerFiles Include="$(InstallersOutputPath)**\*.exe" />
20+
<InstallerFiles Include="$(InstallersOutputPath)**\*.zip" />
21+
<InstallerFiles Include="$(InstallersOutputPath)**\*.tar.gz" />
22+
<InstallerFiles Include="$(InstallersOutputPath)**\*.wixlib" />
23+
<InstallerFiles Include="$(InstallersOutputPath)**\*.rpm" />
24+
<GenerateChecksumItems Include="%(InstallerFiles.Identity)" >
25+
<DestinationPath>%(FullPath).sha512</DestinationPath>
26+
</GenerateChecksumItems>
27+
</ItemGroup>
28+
29+
</Target>
30+
31+
<Import Project="Sdk.targets" Sdk="Microsoft.DotNet.Arcade.Sdk" Condition="'$(GenerateChecksums)' == 'true'" />
32+
33+
</Project>

‎eng/Build.props

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,7 @@
152152
$(RepoRoot)src\SiteExtensions\LoggingAggregate\test\**\*.csproj;
153153
$(RepoRoot)src\Shared\**\*.*proj;
154154
$(RepoRoot)src\Tools\**\*.*proj;
155+
$(RepoRoot)src\Logging.AzureAppServices\**\src\*.csproj;
155156
$(RepoRoot)src\Middleware\**\*.csproj;
156157
$(RepoRoot)src\Razor\**\*.*proj;
157158
$(RepoRoot)src\Mvc\**\*.*proj;
@@ -191,6 +192,7 @@
191192
$(RepoRoot)src\Security\**\src\*.csproj;
192193
$(RepoRoot)src\SiteExtensions\**\src\*.csproj;
193194
$(RepoRoot)src\Tools\**\src\*.csproj;
195+
$(RepoRoot)src\Logging.AzureAppServices\**\src\*.csproj;
194196
$(RepoRoot)src\Middleware\**\src\*.csproj;
195197
$(RepoRoot)src\Razor\**\src\*.csproj;
196198
$(RepoRoot)src\Mvc\**\src\*.csproj;

‎eng/Dependencies.props

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ and are generated based on the last package release.
2929
<LatestPackageReference Include="Microsoft.CodeAnalysis.Razor" Version="$(MicrosoftCodeAnalysisRazorPackageVersion)" />
3030
<LatestPackageReference Include="Microsoft.CSharp" Version="$(MicrosoftCSharpPackageVersion)" />
3131
<LatestPackageReference Include="Microsoft.DotNet.GenAPI" Version="$(MicrosoftDotNetGenApiPackageVersion)" />
32-
<LatestPackageReference Include="Microsoft.DotNet.PlatformAbstractions" Version="$(MicrosoftDotNetPlatformAbstractionsPackageVersion)" />
3332
<LatestPackageReference Include="Microsoft.Extensions.Caching.Abstractions" Version="$(MicrosoftExtensionsCachingAbstractionsPackageVersion)" />
3433
<LatestPackageReference Include="Microsoft.Extensions.Caching.Memory" Version="$(MicrosoftExtensionsCachingMemoryPackageVersion)" />
3534
<LatestPackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="$(MicrosoftExtensionsConfigurationAbstractionsPackageVersion)" />
@@ -119,13 +118,11 @@ and are generated based on the last package release.
119118
<LatestPackageReference Include="Microsoft.EntityFrameworkCore" Version="$(MicrosoftEntityFrameworkCorePackageVersion)" />
120119
<LatestPackageReference Include="Microsoft.Extensions.Caching.SqlServer" Version="$(MicrosoftExtensionsCachingSqlServerPackageVersion)" />
121120
<LatestPackageReference Include="Microsoft.Extensions.Caching.StackExchangeRedis" Version="$(MicrosoftExtensionsCachingStackExchangeRedisPackageVersion)" />
122-
<LatestPackageReference Include="Microsoft.Extensions.Logging.AzureAppServices" Version="$(MicrosoftExtensionsLoggingAzureAppServicesPackageVersion)" />
123-
<LatestPackageReference Include="Microsoft.Extensions.Logging.Testing" Version="$(MicrosoftExtensionsLoggingTestingPackageVersion)" />
124121
<LatestPackageReference Include="Microsoft.IdentityModel.Clients.ActiveDirectory" Version="$(MicrosoftIdentityModelClientsActiveDirectoryPackageVersion)" />
125122
<LatestPackageReference Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" Version="$(MicrosoftIdentityModelProtocolsOpenIdConnectPackageVersion)" />
126123
<LatestPackageReference Include="Microsoft.IdentityModel.Protocols.WsFederation" Version="$(MicrosoftIdentityModelProtocolsWsFederationPackageVersion)" />
127124
<LatestPackageReference Include="Microsoft.Internal.AspNetCore.H2Spec.All" Version="$(MicrosoftInternalAspNetCoreH2SpecAllPackageVersion)" />
128-
<LatestPackageReference Include="Microsoft.Internal.Extensions.Refs" Version="$(MicrosoftInternalExtensionsRefsPackageVersion)" />
125+
<LatestPackageReference Include="Microsoft.Extensions.Internal.Transport" Version="$(MicrosoftExtensionsInternalTransportPackageVersion)" />
129126
<LatestPackageReference Include="Microsoft.NETCore.Windows.ApiSets" Version="$(MicrosoftNETCoreWindowsApiSetsPackageVersion)" />
130127
<LatestPackageReference Include="Microsoft.Owin.Security.Cookies" Version="$(MicrosoftOwinSecurityCookiesPackageVersion)" />
131128
<LatestPackageReference Include="Microsoft.Owin.Testing" Version="$(MicrosoftOwinTestingPackageVersion)" />

‎eng/ProjectReferences.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
<ProjectReferenceProvider Include="Microsoft.Extensions.ApiDescription.Server" ProjectPath="$(RepoRoot)src\Tools\Extensions.ApiDescription.Server\src\Microsoft.Extensions.ApiDescription.Server.csproj" />
3333
<ProjectReferenceProvider Include="Microsoft.AspNetCore.DeveloperCertificates.XPlat" ProjectPath="$(RepoRoot)src\Tools\FirstRunCertGenerator\src\Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj" />
3434
<ProjectReferenceProvider Include="GetDocument.Insider" ProjectPath="$(RepoRoot)src\Tools\GetDocumentInsider\src\GetDocumentInsider.csproj" />
35+
<ProjectReferenceProvider Include="Microsoft.Extensions.Logging.AzureAppServices" ProjectPath="$(RepoRoot)src\Logging.AzureAppServices\src\Microsoft.Extensions.Logging.AzureAppServices.csproj" />
3536
<ProjectReferenceProvider Include="Microsoft.AspNetCore.ConcurrencyLimiter" ProjectPath="$(RepoRoot)src\Middleware\ConcurrencyLimiter\src\Microsoft.AspNetCore.ConcurrencyLimiter.csproj" />
3637
<ProjectReferenceProvider Include="Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore" ProjectPath="$(RepoRoot)src\Middleware\Diagnostics.EntityFrameworkCore\src\Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.csproj" />
3738
<ProjectReferenceProvider Include="Microsoft.AspNetCore.HeaderPropagation" ProjectPath="$(RepoRoot)src\Middleware\HeaderPropagation\src\Microsoft.AspNetCore.HeaderPropagation.csproj" />

‎eng/Publishing.props

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project>
2-
<PropertyGroup Condition=" HasTrailingSlash('$(ArtifactsDir)') ">
2+
<PropertyGroup>
33
<!-- The one use of ArtifactsDir in Publish.proj adds an additional slash, confusing itself. -->
4-
<ArtifactsDir>$(ArtifactsDir.Substring(0, $([MSBuild]::Subtract($(ArtifactsDir.Length), 1))))</ArtifactsDir>
4+
<ArtifactsDir Condition=" HasTrailingSlash('$(ArtifactsDir)') ">$(ArtifactsDir.Substring(0, $([MSBuild]::Subtract($(ArtifactsDir.Length), 1))))</ArtifactsDir>
55

66
<PublishDependsOnTargets>$(PublishDependsOnTargets);_PublishInstallersAndChecksums</PublishDependsOnTargets>
77

@@ -50,12 +50,10 @@
5050
<!-- Do not push .nupkg files from Linux and macOS builds. They'll be packed up separately and signed on Windows. -->
5151
<ItemsToPushToBlobFeed Remove="@(ItemsToPushToBlobFeed)" Condition="'$(OS)' != 'Windows_NT'" />
5252

53-
<!-- Skip publishing checksums for now - the checksums for the .zip files don't match (https://github.com/dotnet/aspnetcore/issues/18792)
5453
<ItemsToPushToBlobFeed Include="@(_ChecksumsToPublish)">
5554
<PublishFlatContainer>true</PublishFlatContainer>
5655
<RelativeBlobPath>$(_UploadPathRoot)/Runtime/$(_PackageVersion)/%(Filename)%(Extension)</RelativeBlobPath>
5756
</ItemsToPushToBlobFeed>
58-
-->
5957

6058
<ItemsToPushToBlobFeed Include="@(_InstallersToPublish)">
6159
<IsShipping>true</IsShipping>

‎eng/SharedFramework.External.props

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,8 @@
1818
<SystemWindowsExtensionsPackageVersion>$(SystemWindowsExtensionsPackageVersion.Split('.')[0]).$(SystemWindowsExtensionsPackageVersion.Split('.')[1]).0</SystemWindowsExtensionsPackageVersion>
1919
</PropertyGroup>
2020

21-
2221
<ItemGroup>
23-
<!-- Dependencies from dotnet/extensions -->
22+
<!-- Dependencies from dotnet/runtime -->
2423
<ExternalAspNetCoreAppReference Include="Microsoft.Extensions.Caching.Abstractions" Version="$(MicrosoftExtensionsCachingAbstractionsPackageVersion)" />
2524
<ExternalAspNetCoreAppReference Include="Microsoft.Extensions.Caching.Memory" Version="$(MicrosoftExtensionsCachingMemoryPackageVersion)" />
2625
<ExternalAspNetCoreAppReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="$(MicrosoftExtensionsConfigurationAbstractionsPackageVersion)" />
@@ -54,8 +53,6 @@
5453
<ExternalAspNetCoreAppReference Include="Microsoft.Extensions.Options.DataAnnotations" Version="$(MicrosoftExtensionsOptionsDataAnnotationsPackageVersion)" />
5554
<ExternalAspNetCoreAppReference Include="Microsoft.Extensions.Options" Version="$(MicrosoftExtensionsOptionsPackageVersion)" />
5655
<ExternalAspNetCoreAppReference Include="Microsoft.Extensions.Primitives" Version="$(MicrosoftExtensionsPrimitivesPackageVersion)" />
57-
58-
<!-- Dependencies from dotnet/corefx -->
5956
<ExternalAspNetCoreAppReference Include="System.IO.Pipelines" Version="$(SystemIOPipelinesPackageVersion)" />
6057
<ExternalAspNetCoreAppReference Include="System.Security.Cryptography.Xml" Version="$(SystemSecurityCryptographyXmlPackageVersion)" />
6158

0 commit comments

Comments
 (0)