small cleanup

Author: jkotalik

src/Servers/Kestrel/Core/src/CoreStrings.resx

@@ -596,4 +596,7 @@ For more information on configuring HTTPS see https://go.microsoft.com/fwlink/?l
   <data name="ServerShutdownDuringConnectionInitialization" xml:space="preserve">
     <value>Server shutdown started during connection initialization.</value>
   </data>
+  <data name="StartAsyncBeforeGetMemory" xml:space="preserve">
+    <value>Cannot call GetMemory() until response has started. Call HttpResponse.StartAsync() before calling GetMemory().</value>
+  </data>
 </root>

src/Servers/Kestrel/Core/src/Internal/Http/HttpProtocol.cs

@@ -1286,8 +1286,7 @@ private void ThrowIfResponseNotStarted()
         {
             if (!HasResponseStarted)
             {
-                throw new InvalidOperationException("Cannot call GetMemory() until response has started. " +
-                    "Call HttpResponse.StartAsync() before calling GetMemory().");
+                throw new InvalidOperationException(CoreStrings.StartAsyncBeforeGetMemory);
             }
         }
 

src/Servers/Kestrel/Core/src/Properties/CoreStrings.Designer.cs

@@ -109,7 +109,7 @@ public async Task IgnoreNullHeaderValues(string headerName, StringValues headerV
                     {
                         context.Response.Headers.Add(headerName, headerValue);
 
-                        await context.Response.WriteResponseAsync("");
+                        await context.Response.WriteAsync("");
                     });
                 });
 
@@ -153,7 +153,7 @@ public async Task WriteAfterConnectionCloseNoops(ListenOptions listenOptions)
                     requestStarted.SetResult(null);
                     await connectionClosed.Task.DefaultTimeout();
                     httpContext.Response.ContentLength = 12;
-                    await httpContext.Response.WriteResponseAsync("hello, world");
+                    await httpContext.Response.WriteAsync("hello, world");
                     appCompleted.TrySetResult(null);
                 }
                 catch (Exception ex)
@@ -209,7 +209,7 @@ public async Task ThrowsOnWriteWithRequestAbortedTokenAfterRequestIsAborted(List
 
                 try
                 {
-                    await response.WriteResponseAsync(largeString, token: lifetime.RequestAborted);
+                    await response.WriteAsync(largeString, cancellationToken: lifetime.RequestAborted);
                 }
                 catch (Exception ex)
                 {

src/Servers/Kestrel/shared/test/HttpResponseWritingExtensions.cs

@@ -12,10 +12,6 @@
     <Content Include="$(KestrelSharedSourceRoot)test\TestCertificates\*.pfx" LinkBase="shared\TestCertificates" CopyToOutputDirectory="PreserveNewest" />
   </ItemGroup>
 
-  <ItemGroup>
-    <Compile Remove="C:\Users\jukotali\code\aspnetcore\src\Servers\Kestrel\shared\test\HttpResponseWritingExtensions.cs" />
-  </ItemGroup>
-
   <ItemGroup>
     <Reference Include="Microsoft.AspNetCore.Http.Abstractions" />
     <Reference Include="Microsoft.AspNetCore.Server.Kestrel" />