HeaderPropagation: reworded registration exception for clarity

Author: alefranz

src/Middleware/HeaderPropagation/src/HeaderPropagationMessageHandler.cs

@@ -48,8 +48,8 @@ protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage reques
             {
                 var message =
                     $"The {nameof(HeaderPropagationValues)}.{nameof(HeaderPropagationValues.Headers)} property has not been " +
-                    $"initialized. Register the header propagation middleware by adding 'app.{nameof(HeaderPropagationApplicationBuilderExtensions.UseHeaderPropagation)}() " +
-                    $"in the 'Configure(...)' method.";
+                    $"initialized. Register the header propagation middleware by adding 'app.{nameof(HeaderPropagationApplicationBuilderExtensions.UseHeaderPropagation)}()' " +
+                    $"in the 'Configure(...)' method. Also, do not use an HttpClient with header propagation outside of an incoming HTTP request.";
                 throw new InvalidOperationException(message);
             }
 

src/Middleware/HeaderPropagation/test/HeaderPropagationIntegrationTest.cs

@@ -64,10 +64,35 @@ public async Task HeaderPropagation_WithoutMiddleware_Throws()
             Assert.IsType<InvalidOperationException>(captured);
             Assert.Equal(
                 "The HeaderPropagationValues.Headers property has not been initialized. Register the header propagation middleware " +
-                "by adding 'app.UseHeaderPropagation() in the 'Configure(...)' method.",
+                "by adding 'app.UseHeaderPropagation()' in the 'Configure(...)' method. Also, do not use an HttpClient with header " +
+                "propagation outside of an incoming HTTP request.",
                 captured.Message);
         }
 
+        [Fact]
+        public async Task HeaderPropagation_OutsideOfIncomingRequest_Throws()
+        {
+            // Arrange
+            var services = new ServiceCollection();
+            services.AddHttpClient("test").AddHeaderPropagation();
+            services.AddHeaderPropagation(options =>
+            {
+                options.Headers.Add("X-TraceId");
+            });
+            var serviceProvider = services.BuildServiceProvider();
+
+            // Act
+            var client = serviceProvider.GetRequiredService<IHttpClientFactory>().CreateClient("test");
+            var exception = await Assert.ThrowsAsync<InvalidOperationException>(() => client.GetAsync("http://localhost/"));
+
+            // Assert
+            Assert.Equal(
+                "The HeaderPropagationValues.Headers property has not been initialized. Register the header propagation middleware " +
+                "by adding 'app.UseHeaderPropagation()' in the 'Configure(...)' method. Also, do not use an HttpClient with header " +
+                "propagation outside of an incoming HTTP request.",
+                exception.Message);
+        }
+
         [Fact]
         public async Task HeaderInRequest_AddCorrectValue()
         {