nits

Author: jkotalik

src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/StartupExceptionApplication.h

@@ -16,12 +16,12 @@ class StartupExceptionApplication : public InProcessApplicationBase
         HINSTANCE moduleInstance,
         BOOL disableLogs,
         HRESULT hr,
-        const std::vector<byte>& errorPageContent
+        std::vector<byte>&& errorPageContent
         )
         : m_disableLogs(disableLogs),
         m_HR(hr),
         m_moduleInstance(moduleInstance),
-        m_errorPageContent(errorPageContent),
+        m_errorPageContent(std::move(errorPageContent)),
         InProcessApplicationBase(pServer, pApplication)
     {
     }

src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/dllmain.cpp

@@ -129,7 +129,7 @@ CreateApplication(
             std::unique_ptr<InProcessOptions> options;
             THROW_IF_FAILED(InProcessOptions::Create(*pServer, pSite, *pHttpApplication, options));
             // Set the currently running application to a fake application that returns startup exceptions.
-            auto pErrorApplication = std::make_unique<StartupExceptionApplication>(*pServer, *pHttpApplication, g_hServerModule, options->QueryDisableStartUpErrorPage(), hr, g_errorPageContent);
+            auto pErrorApplication = std::make_unique<StartupExceptionApplication>(*pServer, *pHttpApplication, g_hServerModule, options->QueryDisableStartUpErrorPage(), hr, std::move(g_errorPageContent));
 
             RETURN_IF_FAILED(pErrorApplication->StartMonitoringAppOffline());
             *ppApplication = pErrorApplication.release();

src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/inprocessapplication.h

@@ -15,7 +15,6 @@ typedef BOOL(WINAPI * PFN_SHUTDOWN_HANDLER) (void* pvShutdownHandlerContext);
 typedef REQUEST_NOTIFICATION_STATUS(WINAPI * PFN_ASYNC_COMPLETION_HANDLER)(void *pvManagedHttpContext, HRESULT hrCompletionStatus, DWORD cbCompletion);
 typedef void(WINAPI * PFN_REQUESTS_DRAINED_HANDLER) (void* pvShutdownHandlerContext);
 
-
 #define DOTNETCORE_STARTUP_HOOK  L"DOTNET_STARTUP_HOOKS"
 #define ASPNETCORE_STARTUP_ASSEMBLY L"Microsoft.AspNetCore.Server.IIS"
 class IN_PROCESS_APPLICATION : public InProcessApplicationBase

src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/managedexports.cpp

@@ -511,8 +511,8 @@ EXTERN_C __MIDL_DECLSPEC_DLLEXPORT
 VOID
 http_set_startup_error_page_content(_In_ byte* errorPageContent, int length)
 {
-    g_errorPageContent.resize(g_errorPageContent.size() + length);
-    memcpy(&g_errorPageContent[g_errorPageContent.size() - length], errorPageContent, length);
+    g_errorPageContent.resize(length);
+    memcpy(&g_errorPageContent[length], errorPageContent, length);
 }
 
 // End of export