Use IsEditorRequired in Equality checks (#33553)

* Use IsEditorRequired in Equality checks

Author: pranavkm

src/Razor/Microsoft.AspNetCore.Razor.Language/src/BoundAttributeDescriptorComparer.cs

@@ -8,7 +8,7 @@
 
 namespace Microsoft.AspNetCore.Razor.Language
 {
-    internal class BoundAttributeDescriptorComparer : IEqualityComparer<BoundAttributeDescriptor>
+    internal sealed class BoundAttributeDescriptorComparer : IEqualityComparer<BoundAttributeDescriptor>
     {
         /// <summary>
         /// A default instance of the <see cref="BoundAttributeDescriptorComparer"/>.
@@ -19,7 +19,7 @@ private BoundAttributeDescriptorComparer()
         {
         }
 
-        public virtual bool Equals(BoundAttributeDescriptor descriptorX, BoundAttributeDescriptor descriptorY)
+        public bool Equals(BoundAttributeDescriptor descriptorX, BoundAttributeDescriptor descriptorY)
         {
             if (object.ReferenceEquals(descriptorX, descriptorY))
             {
@@ -37,6 +37,7 @@ public virtual bool Equals(BoundAttributeDescriptor descriptorX, BoundAttributeD
                 descriptorX.IsEnum == descriptorY.IsEnum &&
                 descriptorX.HasIndexer == descriptorY.HasIndexer &&
                 descriptorX.CaseSensitive == descriptorY.CaseSensitive &&
+                descriptorX.IsEditorRequired == descriptorY.IsEditorRequired &&
                 string.Equals(descriptorX.Name, descriptorY.Name, StringComparison.Ordinal) &&
                 string.Equals(descriptorX.IndexerNamePrefix, descriptorY.IndexerNamePrefix, StringComparison.Ordinal) &&
                 string.Equals(descriptorX.TypeName, descriptorY.TypeName, StringComparison.Ordinal) &&
@@ -48,7 +49,7 @@ public virtual bool Equals(BoundAttributeDescriptor descriptorX, BoundAttributeD
                     descriptorY.Metadata.OrderBy(propertyY => propertyY.Key, StringComparer.Ordinal));
         }
 
-        public virtual int GetHashCode(BoundAttributeDescriptor descriptor)
+        public int GetHashCode(BoundAttributeDescriptor descriptor)
         {
             if (descriptor == null)
             {
@@ -58,6 +59,7 @@ public virtual int GetHashCode(BoundAttributeDescriptor descriptor)
             var hash = HashCodeCombiner.Start();
             hash.Add(descriptor.Kind, StringComparer.Ordinal);
             hash.Add(descriptor.Name, StringComparer.Ordinal);
+            hash.Add(descriptor.IsEditorRequired);
 
             if (descriptor.BoundAttributeParameters != null)
             {

src/Razor/Microsoft.AspNetCore.Razor.Language/src/TagHelperDescriptorComparer.cs

@@ -8,7 +8,7 @@
 
 namespace Microsoft.AspNetCore.Razor.Language
 {
-    internal class TagHelperDescriptorComparer : IEqualityComparer<TagHelperDescriptor>
+    internal sealed class TagHelperDescriptorComparer : IEqualityComparer<TagHelperDescriptor>
     {
         /// <summary>
         /// A default instance of the <see cref="TagHelperDescriptorComparer"/>.
@@ -19,7 +19,7 @@ private TagHelperDescriptorComparer()
         {
         }
 
-        public virtual bool Equals(TagHelperDescriptor descriptorX, TagHelperDescriptor descriptorY)
+        public bool Equals(TagHelperDescriptor descriptorX, TagHelperDescriptor descriptorY)
         {
             if (object.ReferenceEquals(descriptorX, descriptorY))
             {
@@ -109,7 +109,7 @@ public virtual bool Equals(TagHelperDescriptor descriptorX, TagHelperDescriptor
         }
 
         /// <inheritdoc />
-        public virtual int GetHashCode(TagHelperDescriptor descriptor)
+        public int GetHashCode(TagHelperDescriptor descriptor)
         {
             if (descriptor == null)
             {