fb

Author: BrennanConroy

src/SignalR/clients/ts/signalr/src/EmptyNodeHttpClient.ts

@@ -0,0 +1,18 @@
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+// This is an empty implementation of the NodeHttpClient that will be included in browser builds so the output file will be smaller
+
+import { HttpClient, HttpResponse } from "./HttpClient";
+import { ILogger } from "./ILogger";
+
+export class NodeHttpClient extends HttpClient {
+    // @ts-ignore: Need ILogger to compile, but unused variables generate errors
+    public constructor(logger: ILogger) {
+        super();
+    }
+
+    public send(): Promise<HttpResponse> {
+        return Promise.reject(new Error("If using Node either provide an XmlHttpRequest polyfill or consume the cjs or esm script instead of the browser/signalr.js one."));
+    }
+}

src/SignalR/clients/ts/signalr/src/NodeHttpClient.ts

@@ -25,7 +25,7 @@ export class NodeHttpClient extends HttpClient {
     public constructor(logger: ILogger) {
         super();
         if (typeof requestModule === "undefined") {
-            throw new Error("error");
+            throw new Error("The 'request' module could not be loaded.");
         }
 
         this.logger = logger;

src/SignalR/clients/ts/signalr/src/empty.ts

@@ -41,7 +41,7 @@ module.exports = function (modulePath, browserBaseName, options) {
         resolve: {
             extensions: [".ts", ".js"],
             alias: {
-                "./NodeHttpClient": path.resolve(__dirname, "signalr/src/empty.ts"),
+                "./NodeHttpClient": path.resolve(__dirname, "signalr/src/EmptyNodeHttpClient.ts"),
                 ...options.alias,
             }
         },