fb

Author: BrennanConroy

src/SignalR/common/Http.Connections/ref/Microsoft.AspNetCore.Http.Connections.netcoreapp3.0.cs

@@ -98,11 +98,11 @@ public HttpConnectionContext(string id, System.IO.Pipelines.IDuplexPipe transpor
         public Microsoft.AspNetCore.Http.Connections.HttpTransportType TransportType { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } [System.Runtime.CompilerServices.CompilerGeneratedAttribute]set { } }
         public System.Security.Claims.ClaimsPrincipal User { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } [System.Runtime.CompilerServices.CompilerGeneratedAttribute]set { } }
         public System.Threading.SemaphoreSlim WriteLock { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
-        public bool ChangeState(Microsoft.AspNetCore.Http.Connections.Internal.HttpConnectionStatus from, Microsoft.AspNetCore.Http.Connections.Internal.HttpConnectionStatus to) { throw null; }
         [System.Diagnostics.DebuggerStepThroughAttribute]
         public System.Threading.Tasks.Task DisposeAsync(bool closeGracefully = false) { throw null; }
         public void OnHeartbeat(System.Action<object> action, object state) { }
         public void TickHeartbeat() { }
+        public bool TryChangeState(Microsoft.AspNetCore.Http.Connections.Internal.HttpConnectionStatus from, Microsoft.AspNetCore.Http.Connections.Internal.HttpConnectionStatus to) { throw null; }
     }
     public partial class HttpConnectionDispatcher
     {

src/SignalR/common/Http.Connections/src/Internal/HttpConnectionContext.cs

@@ -310,7 +310,7 @@ private async Task WaitOnTasks(Task applicationTask, Task transportTask, bool cl
             }
         }
 
-        public bool ChangeState(HttpConnectionStatus from, HttpConnectionStatus to)
+        public bool TryChangeState(HttpConnectionStatus from, HttpConnectionStatus to)
         {
             return Interlocked.CompareExchange(ref _status, (int)to, (int)from) == (int)from;
         }

src/SignalR/common/Http.Connections/src/Internal/HttpConnectionDispatcher.cs

@@ -235,7 +235,7 @@ private async Task ExecuteAsync(HttpContext context, ConnectionDelegate connecti
                     }
 
                     // Mark the connection as active
-                    connection.ChangeState(from: HttpConnectionStatus.Inactive, to: HttpConnectionStatus.Active);
+                    connection.TryChangeState(from: HttpConnectionStatus.Inactive, to: HttpConnectionStatus.Active);
 
                     // Raise OnConnected for new connections only since polls happen all the time
                     if (connection.ApplicationTask == null)
@@ -333,7 +333,7 @@ private async Task ExecuteAsync(HttpContext context, ConnectionDelegate connecti
 
                         // This is done outside a lock because the next poll might be waiting in the lock already and waiting for currentRequestTcs to complete
                         // A DELETE request could have set the status to Disposed. If that is the case we don't want to change the state ever.
-                        connection.ChangeState(from: HttpConnectionStatus.Active, to: HttpConnectionStatus.Inactive);
+                        connection.TryChangeState(from: HttpConnectionStatus.Active, to: HttpConnectionStatus.Inactive);
                     }
                 }
                 finally
@@ -373,7 +373,7 @@ private async Task DoPersistentConnection(ConnectionDelegate connectionDelegate,
                 }
 
                 // Mark the connection as active
-                connection.ChangeState(HttpConnectionStatus.Inactive, HttpConnectionStatus.Active);
+                connection.TryChangeState(HttpConnectionStatus.Inactive, HttpConnectionStatus.Active);
 
                 // Call into the end point passing the connection
                 connection.ApplicationTask = ExecuteApplication(connectionDelegate, connection);