Skip to content

Commit 7f9ebb2

Browse files
committed
Cleanup warnings
- avoid "CSC warning CS2008: No source files specified." building site extensions - correct warnings (as errors) about `RenderToStringResult` being obsolete - add Microsoft.AspNetCore.SpaServices.Tests to Middleware solution
1 parent e0cb686 commit 7f9ebb2

File tree

3 files changed

+24
-0
lines changed

3 files changed

+24
-0
lines changed

src/Middleware/Middleware.sln

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.AspNetCore.Server
299299
EndProject
300300
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.AspNetCore.SpaServices.Extensions.Tests", "SpaServices.Extensions\test\Microsoft.AspNetCore.SpaServices.Extensions.Tests.csproj", "{D0CB733B-4CE8-4F6C-BBB9-548EA1A96966}"
301301
EndProject
302+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.AspNetCore.SpaServices.Tests", "SpaServices\test\Microsoft.AspNetCore.SpaServices.Tests.csproj", "{8A9C1F6C-3A47-4868-AA95-3EBE0260F5A0}"
303+
EndProject
302304
Global
303305
GlobalSection(SolutionConfigurationPlatforms) = preSolution
304306
Debug|Any CPU = Debug|Any CPU
@@ -1641,6 +1643,18 @@ Global
16411643
{D0CB733B-4CE8-4F6C-BBB9-548EA1A96966}.Release|x64.Build.0 = Release|Any CPU
16421644
{D0CB733B-4CE8-4F6C-BBB9-548EA1A96966}.Release|x86.ActiveCfg = Release|Any CPU
16431645
{D0CB733B-4CE8-4F6C-BBB9-548EA1A96966}.Release|x86.Build.0 = Release|Any CPU
1646+
{8A9C1F6C-3A47-4868-AA95-3EBE0260F5A0}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
1647+
{8A9C1F6C-3A47-4868-AA95-3EBE0260F5A0}.Debug|Any CPU.Build.0 = Debug|Any CPU
1648+
{8A9C1F6C-3A47-4868-AA95-3EBE0260F5A0}.Debug|x64.ActiveCfg = Debug|Any CPU
1649+
{8A9C1F6C-3A47-4868-AA95-3EBE0260F5A0}.Debug|x64.Build.0 = Debug|Any CPU
1650+
{8A9C1F6C-3A47-4868-AA95-3EBE0260F5A0}.Debug|x86.ActiveCfg = Debug|Any CPU
1651+
{8A9C1F6C-3A47-4868-AA95-3EBE0260F5A0}.Debug|x86.Build.0 = Debug|Any CPU
1652+
{8A9C1F6C-3A47-4868-AA95-3EBE0260F5A0}.Release|Any CPU.ActiveCfg = Release|Any CPU
1653+
{8A9C1F6C-3A47-4868-AA95-3EBE0260F5A0}.Release|Any CPU.Build.0 = Release|Any CPU
1654+
{8A9C1F6C-3A47-4868-AA95-3EBE0260F5A0}.Release|x64.ActiveCfg = Release|Any CPU
1655+
{8A9C1F6C-3A47-4868-AA95-3EBE0260F5A0}.Release|x64.Build.0 = Release|Any CPU
1656+
{8A9C1F6C-3A47-4868-AA95-3EBE0260F5A0}.Release|x86.ActiveCfg = Release|Any CPU
1657+
{8A9C1F6C-3A47-4868-AA95-3EBE0260F5A0}.Release|x86.Build.0 = Release|Any CPU
16441658
EndGlobalSection
16451659
GlobalSection(SolutionProperties) = preSolution
16461660
HideSolutionNode = FALSE
@@ -1770,6 +1784,7 @@ Global
17701784
{46B4FE62-06A1-4D54-B3E8-D8B4B3560075} = {ACA6DDB9-7592-47CE-A740-D15BF307E9E0}
17711785
{92E11EBB-759E-4DA8-AB61-A9977D9F97D0} = {ACA6DDB9-7592-47CE-A740-D15BF307E9E0}
17721786
{D0CB733B-4CE8-4F6C-BBB9-548EA1A96966} = {D6FA4ABE-E685-4EDD-8B06-D8777E76B472}
1787+
{8A9C1F6C-3A47-4868-AA95-3EBE0260F5A0} = {D6FA4ABE-E685-4EDD-8B06-D8777E76B472}
17731788
EndGlobalSection
17741789
GlobalSection(ExtensibilityGlobals) = postSolution
17751790
SolutionGuid = {83786312-A93B-4BB4-AB06-7C6913A59AFA}

src/Middleware/SpaServices/test/RenderToStringResultTests.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,9 @@ public class RenderToStringResultTest
1515
public void HandlesNullGlobals()
1616
{
1717
// Arrange
18+
#pragma warning disable CS0618 // Type or member is obsolete
1819
var renderToStringResult = new RenderToStringResult();
20+
#pragma warning restore CS0618 // Type or member is obsolete
1921
renderToStringResult.Globals = null;
2022

2123
// Act
@@ -29,7 +31,9 @@ public void HandlesNullGlobals()
2931
public void HandlesGlobalsWithMultipleProperties()
3032
{
3133
// Arrange
34+
#pragma warning disable CS0618 // Type or member is obsolete
3235
var renderToStringResult = new RenderToStringResult();
36+
#pragma warning restore CS0618 // Type or member is obsolete
3337
renderToStringResult.Globals = ToJObject(new
3438
{
3539
FirstProperty = "first value",
@@ -49,7 +53,9 @@ public void HandlesGlobalsWithMultipleProperties()
4953
public void HandlesGlobalsWithCorrectStringEncoding()
5054
{
5155
// Arrange
56+
#pragma warning disable CS0618 // Type or member is obsolete
5257
var renderToStringResult = new RenderToStringResult();
58+
#pragma warning restore CS0618 // Type or member is obsolete
5359
renderToStringResult.Globals = ToJObject(new Dictionary<string, object>
5460
{
5561
{ "Va<l'u\"e", "</tag>\"'}\u260E" }

src/SiteExtensions/LoggingBranch/LB.csproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@
3131
</ProjectReference>
3232
</ItemGroup>
3333

34+
<!-- No code in this project to compile. -->
35+
<Target Name="Compile" />
36+
3437
<!-- Cannot assume this project and Microsoft.AspNetCore.AzureAppServices.HostingStartup have the same package version. -->
3538
<Target Name="_GetHostingStartupPackageReference" BeforeTargets="GenerateHostingStartupDeps">
3639
<!-- This target is defined in eng/targets/Packaging.targets and included in every C# and F# project. -->

0 commit comments

Comments
 (0)