PR feedback

Author: ryanbrandenburg

src/ProjectTemplates/test/GrpcTemplateTest.cs

@@ -44,7 +44,7 @@ public async Task GrpcTemplate()
                 using (var clientProcess = Project.StartBuiltClientAsync(serverProcess))
                 {
                     // Wait for the client to do its thing
-                    System.Threading.Thread.Sleep(100);
+                    await Task.Delay(100)
                     Assert.False(
                         clientProcess.Process.HasExited,
                         ErrorMessages.GetFailedProcessMessageOrEmpty("Run built client", Project, clientProcess.Process));
@@ -60,7 +60,7 @@ public async Task GrpcTemplate()
                 using (var clientProcess = Project.StartPublishedClientAsync())
                 {
                     // Wait for the client to do its thing
-                    System.Threading.Thread.Sleep(100);
+                    await Task.Delay(100)
                     Assert.False(
                         clientProcess.Process.HasExited,
                         ErrorMessages.GetFailedProcessMessageOrEmpty("Run built client", Project, clientProcess.Process));

src/ProjectTemplates/test/Helpers/AspNetProcess.cs

@@ -34,7 +34,7 @@ public AspNetProcess(
             string workingDirectory,
             string dllPath,
             IDictionary<string, string> environmentVariables,
-            bool useExec = true,
+            bool published = true,
             bool hasListeningUri = true)
         {
             _output = output;
@@ -54,7 +54,7 @@ public AspNetProcess(
 
             output.WriteLine("Running ASP.NET application...");
 
-            var arguments = useExec ? $"exec {dllPath}" : "run";
+            var arguments = published ? $"exec {dllPath}" : "run";
             Process = ProcessEx.Run(output, workingDirectory, DotNetMuxer.MuxerPathOrDefault(), arguments, envVars: environmentVariables);
             if(hasListeningUri)
             {
@@ -216,7 +216,7 @@ public override string ToString()
             {
                 if (!Process.HasExited)
                 {
-                    result += $"(Listening on {_listeningUri.OriginalString}) PID: {Process.Id}";
+                    result += $"(Listening on {ListeningUri.OriginalString}) PID: {Process.Id}";
                 }
                 else
                 {

src/ProjectTemplates/test/Helpers/Project.cs

@@ -19,6 +19,8 @@ namespace Templates.Test.Helpers
     [DebuggerDisplay("{ToString(),nq}")]
     public class Project
     {
+        private const string _urls = "http://127.0.0.1:0;https://127.0.0.1:0";
+
         public const string DefaultFramework = "netcoreapp3.0";
 
         public SemaphoreSlim DotNetNewLock { get; set; }
@@ -141,7 +143,7 @@ internal AspNetProcess StartBuiltServerAsync()
             };
 
             var projectDll = Path.Combine(TemplateServerDir, $"{ProjectName}.Server.dll");
-            return new AspNetProcess(Output, TemplateServerDir, projectDll, environment, useExec: false);
+            return new AspNetProcess(Output, TemplateServerDir, projectDll, environment, published: false);
         }
 
         internal AspNetProcess StartBuiltClientAsync(AspNetProcess serverProcess)
@@ -177,8 +179,6 @@ internal AspNetProcess StartPublishedClientAsync()
             return new AspNetProcess(Output, TemplateClientReleaseDir, projectDll, environment);
         }
 
-        private const string _urls = "http://127.0.0.1:0;https://127.0.0.1:0";
-
         internal AspNetProcess StartBuiltProjectAsync()
         {
             var environment = new Dictionary<string, string>

src/ProjectTemplates/test/RazorPagesTemplateTest.cs

@@ -24,7 +24,6 @@ public RazorPagesTemplateTest(ProjectFactoryFixture projectFactory, ITestOutputH
 
         public ITestOutputHelper Output { get; }
 
-
         [Fact]
         public async Task RazorPagesTemplate_NoAuthImplAsync()
         {