HttpSys GoAway #13356

Author: Tratcher

src/Servers/HttpSys/samples/SelfHostServer/SelfHostServer.csproj

@@ -1,10 +1,15 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
     <OutputType>Exe</OutputType>
     <ServerGarbageCollection>true</ServerGarbageCollection>
   </PropertyGroup>
+  
+  <PropertyGroup>
+    <!--Imitate IIS Express so we can use it's cert bindings-->
+    <PackageTags>214124cd-d05b-4309-9af9-9caa44b2b74a</PackageTags>
+  </PropertyGroup>
 
   <ItemGroup>
     <Reference Include="Microsoft.AspNetCore.Server.HttpSys" />

src/Servers/HttpSys/samples/SelfHostServer/Startup.cs

@@ -37,6 +37,8 @@ public static void Main(string[] args)
                 .UseHttpSys(options =>
                 {
                     options.UrlPrefixes.Add("http://localhost:5000");
+                    // This is a pre-configured IIS express port. See the PackageTags in the csproj.
+                    options.UrlPrefixes.Add("https://localhost:44319");
                     options.Authentication.Schemes = AuthenticationSchemes.None;
                     options.Authentication.AllowAnonymous = true;
                 })

src/Servers/HttpSys/src/NativeInterop/ComNetOS.cs

@@ -2,7 +2,6 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
-using Microsoft.Extensions.Internal;
 
 namespace Microsoft.AspNetCore.Server.HttpSys
 {
@@ -12,11 +11,18 @@ internal static class ComNetOS
         // Minimum support for Windows 7 is assumed.
         internal static readonly bool IsWin8orLater;
 
+        public static bool SupportsGoAway { get; }
+
         static ComNetOS()
         {
             var win8Version = new Version(6, 2);
 
             IsWin8orLater = (Environment.OSVersion.Version >= win8Version);
+
+            var win1019H2Version = new Version(10, 0, 18363);
+            // Win10 1909 (19H2) or later
+            SupportsGoAway = (Environment.OSVersion.Version >= win1019H2Version);
         }
+
     }
 }

src/Servers/HttpSys/src/RequestProcessing/Response.cs

@@ -4,7 +4,6 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
-using System.Globalization;
 using System.IO;
 using System.Runtime.InteropServices;
 using System.Threading;
@@ -417,6 +416,10 @@ internal HttpApiTypes.HTTP_FLAGS ComputeHeaders(long writeCount, bool endOfReque
                     Headers.Append(HttpKnownHeaderNames.Connection, Constants.Close);
                 }
                 flags = HttpApiTypes.HTTP_FLAGS.HTTP_SEND_RESPONSE_FLAG_DISCONNECT;
+                if (responseCloseSet && requestVersion >= Constants.V2 && ComNetOS.SupportsGoAway)
+                {
+                    flags |= HttpApiTypes.HTTP_FLAGS.HTTP_SEND_RESPONSE_FLAG_GOAWAY;
+                }
             }
 
             Headers.IsReadOnly = true;

src/Shared/HttpSys/NativeInterop/HttpApiTypes.cs

@@ -602,6 +602,7 @@ internal enum HTTP_FLAGS : uint
             HTTP_INITIALIZE_SERVER = 0x00000001,
             HTTP_INITIALIZE_CBT = 0x00000004,
             HTTP_SEND_RESPONSE_FLAG_OPAQUE = 0x00000040,
+            HTTP_SEND_RESPONSE_FLAG_GOAWAY = 0x00000100,
         }
 
         [Flags]