Check all links for templates

ryanbrandenburg · ryanbrandenburg · commit 86b9421bad1a · 2019-03-18T09:29:26.000-07:00
diff --git a/src/ProjectTemplates/test/EmptyWebTemplateTest.cs b/src/ProjectTemplates/test/EmptyWebTemplateTest.cs
@@ -1,6 +1,7 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
+using System.Threading.Tasks;
 using ProjectTemplates.Tests.Helpers;
 using Xunit;
 using Xunit.Abstractions;
@@ -19,15 +20,15 @@ public EmptyWebTemplateTest(ProjectFactoryFixture projectFactory, ITestOutputHel
         [Theory]
         [InlineData(null)]
         [InlineData("F#")]
-        public void EmptyWebTemplate(string languageOverride)
+        public async Task EmptyWebTemplate(string languageOverride)
         {
             Project.RunDotNetNew("web", language: languageOverride);
 
             foreach (var publish in new[] { false, true })
             {
                 using (var aspNetProcess = Project.StartAspNetProcess(publish))
                 {
-                    aspNetProcess.AssertOk("/");
+                    await aspNetProcess.AssertLinksWork("/");
                 }
             }
         }
diff --git a/src/ProjectTemplates/test/Helpers/AspNetProcess.cs b/src/ProjectTemplates/test/Helpers/AspNetProcess.cs
@@ -7,6 +7,9 @@
 using System.Linq;
 using System.Net;
 using System.Net.Http;
+using System.Threading.Tasks;
+using AngleSharp.Dom.Html;
+using AngleSharp.Parser.Html;
 using Microsoft.AspNetCore.Certificates.Generation;
 using Microsoft.Extensions.CommandLineUtils;
 using OpenQA.Selenium;
@@ -134,7 +137,37 @@ private Uri GetListeningUri(ITestOutputHelper output)
             return new Uri(listeningUrlString, UriKind.Absolute);
         }
 
-        public void AssertOk(string requestUrl)
+        public async Task AssertLinksWork(string requestUrl)
+        {
+            var request = new HttpRequestMessage(
+                HttpMethod.Get,
+                new Uri(_listeningUri, requestUrl));
+
+            var response = await _httpClient.SendAsync(request);
+
+            Assert.Equal(HttpStatusCode.OK, response.StatusCode);
+            var parser = new HtmlParser();
+            var html = await parser.ParseAsync(await response.Content.ReadAsStreamAsync());
+            foreach (IHtmlAnchorElement link in html.Links)
+            {
+                if(link.Protocol == "about:")
+                {
+                    AssertOk(link.PathName);
+                }
+                else
+                {
+                    var result = await _httpClient.GetAsync(link.Href);
+                    Assert.True(IsSuccessStatusCode(result), $"{link.Href} is a broken link!");
+                }
+            }
+        }
+
+        private bool IsSuccessStatusCode(HttpResponseMessage response)
+        {
+            return response.IsSuccessStatusCode || response.StatusCode == HttpStatusCode.Redirect;
+        }
+
+        private void AssertOk(string requestUrl)
             => AssertStatusCode(requestUrl, HttpStatusCode.OK);
 
         public void AssertNotFound(string requestUrl)
diff --git a/src/ProjectTemplates/test/MvcTemplateTest.cs b/src/ProjectTemplates/test/MvcTemplateTest.cs
@@ -1,6 +1,7 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
+using System.Threading.Tasks;
 using ProjectTemplates.Tests.Helpers;
 using Xunit;
 using Xunit.Abstractions;
@@ -19,7 +20,7 @@ public MvcTemplateTest(ProjectFactoryFixture projectFactory, ITestOutputHelper o
         [Theory]
         [InlineData(null)]
         [InlineData("F#")]
-        public void MvcTemplate_NoAuthImpl(string languageOverride)
+        public async Task MvcTemplate_NoAuthImpl(string languageOverride)
         {
             Project.RunDotNetNew("mvc", language: languageOverride);
 
@@ -40,16 +41,16 @@ public void MvcTemplate_NoAuthImpl(string languageOverride)
             {
                 using (var aspNetProcess = Project.StartAspNetProcess(publish))
                 {
-                    aspNetProcess.AssertOk("/");
-                    aspNetProcess.AssertOk("/Home/Privacy");
+                    await aspNetProcess.AssertLinksWork("/");
+                    await aspNetProcess.AssertLinksWork("/Home/Privacy");
                 }
             }
         }
 
         [Theory]
         [InlineData(true)]
         [InlineData(false)]
-        public void MvcTemplate_IndividualAuthImpl(bool useLocalDB)
+        public async Task MvcTemplate_IndividualAuthImpl(bool useLocalDB)
         {
             Project.RunDotNetNew("mvc", auth: "Individual", useLocalDB: useLocalDB);
 
@@ -71,9 +72,9 @@ public void MvcTemplate_IndividualAuthImpl(bool useLocalDB)
             {
                 using (var aspNetProcess = Project.StartAspNetProcess(publish))
                 {
-                    aspNetProcess.AssertOk("/");
-                    aspNetProcess.AssertOk("/Identity/Account/Login");
-                    aspNetProcess.AssertOk("/Home/Privacy");
+                    await aspNetProcess.AssertLinksWork("/");
+                    await aspNetProcess.AssertLinksWork("/Identity/Account/Login");
+                    await aspNetProcess.AssertLinksWork("/Home/Privacy");
                 }
             }
         }
diff --git a/src/ProjectTemplates/test/RazorPagesTemplateTest.cs b/src/ProjectTemplates/test/RazorPagesTemplateTest.cs
@@ -1,6 +1,7 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
+using System.Threading.Tasks;
 using Microsoft.AspNetCore.Testing.xunit;
 using ProjectTemplates.Tests.Helpers;
 using Xunit;
@@ -18,7 +19,7 @@ public RazorPagesTemplateTest(ProjectFactoryFixture projectFactory, ITestOutputH
         public Project Project { get; }
 
         [Fact]
-        private void RazorPagesTemplate_NoAuthImpl()
+        private async Task RazorPagesTemplate_NoAuthImpl()
         {
             Project.RunDotNetNew("razor");
 
@@ -35,16 +36,16 @@ private void RazorPagesTemplate_NoAuthImpl()
             {
                 using (var aspNetProcess = Project.StartAspNetProcess(publish))
                 {
-                    aspNetProcess.AssertOk("/");
-                    aspNetProcess.AssertOk("/Privacy");
+                    await aspNetProcess.AssertLinksWork("/");
+                    await aspNetProcess.AssertLinksWork("/Privacy");
                 }
             }
         }
 
         [Theory]
         [InlineData(false)]
         [InlineData(true)]
-        public void RazorPagesTemplate_IndividualAuthImpl( bool useLocalDB)
+        public async Task RazorPagesTemplate_IndividualAuthImpl( bool useLocalDB)
         {
             Project.RunDotNetNew("razor", auth: "Individual", useLocalDB: useLocalDB);
 
@@ -64,9 +65,9 @@ public void RazorPagesTemplate_IndividualAuthImpl( bool useLocalDB)
             {
                 using (var aspNetProcess = Project.StartAspNetProcess(publish))
                 {
-                    aspNetProcess.AssertOk("/");
-                    aspNetProcess.AssertOk("/Identity/Account/Login");
-                    aspNetProcess.AssertOk("/Privacy");
+                    await aspNetProcess.AssertLinksWork("/");
+                    await aspNetProcess.AssertLinksWork("/Identity/Account/Login");
+                    await aspNetProcess.AssertLinksWork("/Privacy");
                 }
             }
         }
diff --git a/src/ProjectTemplates/test/WebApiTemplateTest.cs b/src/ProjectTemplates/test/WebApiTemplateTest.cs
@@ -1,6 +1,7 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
+using System.Threading.Tasks;
 using ProjectTemplates.Tests.Helpers;
 using Xunit;
 using Xunit.Abstractions;
@@ -19,15 +20,15 @@ public WebApiTemplateTest(ProjectFactoryFixture factoryFixture, ITestOutputHelpe
         [Theory]
         [InlineData(null)]
         [InlineData("F#")]
-        public void WebApiTemplate(string languageOverride)
+        public async Task WebApiTemplate(string languageOverride)
         {
             Project.RunDotNetNew("webapi", language: languageOverride);
 
             foreach (var publish in new[] { false, true })
             {
                 using (var aspNetProcess = Project.StartAspNetProcess(publish))
                 {
-                    aspNetProcess.AssertOk("/api/values");
+                    await aspNetProcess.AssertLinksWork("/api/values");
                     aspNetProcess.AssertNotFound("/");
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`// Copyright (c) .NET Foundation. All rights reserved.`
`2`	`2`	`// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.`
`3`	`3`
	`4`	`+using System.Threading.Tasks;`
`4`	`5`	`using ProjectTemplates.Tests.Helpers;`
`5`	`6`	`using Xunit;`
`6`	`7`	`using Xunit.Abstractions;`
`@@ -19,15 +20,15 @@ public EmptyWebTemplateTest(ProjectFactoryFixture projectFactory, ITestOutputHel`
`19`	`20`	`[Theory]`
`20`	`21`	`[InlineData(null)]`
`21`	`22`	`[InlineData("F#")]`
`22`		`- public void EmptyWebTemplate(string languageOverride)`
	`23`	`+ public async Task EmptyWebTemplate(string languageOverride)`
`23`	`24`	`{`
`24`	`25`	`Project.RunDotNetNew("web", language: languageOverride);`
`25`	`26`
`26`	`27`	`foreach (var publish in new[] { false, true })`
`27`	`28`	`{`
`28`	`29`	`using (var aspNetProcess = Project.StartAspNetProcess(publish))`
`29`	`30`	`{`
`30`		`- aspNetProcess.AssertOk("/");`
	`31`	`+ await aspNetProcess.AssertLinksWork("/");`
`31`	`32`	`}`
`32`	`33`	`}`
`33`	`34`	`}`