Skip to content

Commit 8c658cc

Browse files
committed
Address feedback from review
1 parent d42effc commit 8c658cc

File tree

6 files changed

+590
-43
lines changed

6 files changed

+590
-43
lines changed

src/Http/Http.Extensions/gen/StaticRouteHandlerModel/Emitters/EmitterExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ public static bool IsSerializableJsonResponse(this EndpointResponse endpointResp
4343
EndpointParameterSource.BindAsync => endpointParameter.IsOptional ?
4444
endpointParameter.EmitHandlerArgument() :
4545
endpointParameter.Type.IsValueType && endpointParameter.GetBindAsyncReturnType()?.OriginalDefinition.SpecialType == SpecialType.System_Nullable_T
46-
? $"{endpointParameter.EmitHandlerArgument()}.Value"
47-
: $"{endpointParameter.EmitHandlerArgument()}!",
46+
? $"{endpointParameter.EmitHandlerArgument()}.HasValue ? {endpointParameter.EmitHandlerArgument()}.Value : default"
47+
: $"{endpointParameter.EmitHandlerArgument()}",
4848
EndpointParameterSource.Unknown => throw new NotImplementedException("Unreachable!"),
4949
_ => endpointParameter.EmitHandlerArgument()
5050
};

src/Http/Http.Extensions/gen/StaticRouteHandlerModel/Emitters/EndpointParameterEmitter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ internal static void EmitBindAsyncPreparation(this EndpointParameter endpointPar
294294

295295
if (!endpointParameter.IsOptional)
296296
{
297-
codeWriter.WriteLine($"if ((object?){endpointParameter.EmitHandlerArgument()} == null)");
297+
codeWriter.WriteLine($"if ({endpointParameter.EmitHandlerArgument()} == null)");
298298
codeWriter.StartBlock();
299299
codeWriter.WriteLine($@"logOrThrowExceptionHelper.RequiredParameterNotProvided({SymbolDisplay.FormatLiteral(endpointParameter.Type.ToDisplayString(SymbolDisplayFormat.CSharpShortErrorMessageFormat), true)}, {SymbolDisplay.FormatLiteral(endpointParameter.SymbolName, true)}, {SymbolDisplay.FormatLiteral(endpointParameter.ToMessageString(), true)});");
300300
codeWriter.WriteLine("wasParamCheckFailure = true;");

0 commit comments

Comments
 (0)