Update SDK to 8.0.100-rc.1.23381.2 (#49761)

* Update SDK to 8.0.100-rc.1.23381.2

* Respond to new code analysis warnings.
- CA2208: Instantiate argument exceptions correctly
- CA2249: Use 'string.Contains' instead of 'string.IndexOf' to improve readability

* WasmLinkerTest: Workaround incorrect settings in the project file

Issue when updating to build with rc1:
```
/Users/runner/work/1/s/.dotnet/sdk/8.0.100-rc.1.23381.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: wasm-tools [/Users/runner/work/1/s/src/Components/WebAssembly/testassets/WasmLinkerTest/WasmLinkerTest.csproj]
/Users/runner/work/1/s/.dotnet/sdk/8.0.100-rc.1.23381.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload restore [/Users/runner/work/1/s/src/Components/WebAssembly/testassets/WasmLinkerTest/WasmLinkerTest.csproj]
```

Explanation:

1. This project has `RuntimeIdentifier=browser-wasm`, which triggers the
   workload manifests for wasm
2. But the project is *not* using blazor sdk, or the wasm-sdk.
3. The condition at https://github.com/dotnet/emsdk/blob/5466de081d350d3214c1ae68b7fca6295109d5cf/eng/nuget/Microsoft.NET.Workload.Emscripten.Current.Manifest/WorkloadManifest.targets#L12

```xml
<UsingBrowserRuntimeWorkload Condition="'$(RunAOTCompilation)' == 'true' or '$(UsingMicrosoftNETSdkBlazorWebAssembly)' != 'true' or '$(UsingMicrosoftNETSdkWebAssembly)' != 'true'" >true</UsingBrowserRuntimeWorkload>
```

   .. means that if a `rid=browser-wasm` project is not using blazor sdk,
   or the wasm sdk, then it depends on the targets in the workload. And
   hence requires the workload.

Solution:
As a workaround set `UsingMicrosoftNETSdkWebAssembly=true` also
(`UsingMicrosoftNETSdkBlazorWebAssembly` is already set to true).

---------

Co-authored-by: Brennan <[email protected]>
Co-authored-by: Ankit Jain <[email protected]>

Author: 3 people

global.json

@@ -1,9 +1,9 @@
 {
   "sdk": {
-    "version": "8.0.100-preview.7.23360.1"
+    "version": "8.0.100-rc.1.23381.2"
   },
   "tools": {
-    "dotnet": "8.0.100-preview.7.23360.1",
+    "dotnet": "8.0.100-rc.1.23381.2",
     "runtimes": {
       "dotnet/x86": [
         "$(MicrosoftNETCoreBrowserDebugHostTransportVersion)"

src/Caching/SqlServer/src/SqlServerCache.cs

@@ -59,10 +59,12 @@ public SqlServerCache(IOptions<SqlServerCacheOptions> options)
         }
         if (cacheOptions.DefaultSlidingExpiration <= TimeSpan.Zero)
         {
+#pragma warning disable CA2208 // Instantiate argument exceptions correctly
             throw new ArgumentOutOfRangeException(
                 nameof(cacheOptions.DefaultSlidingExpiration),
                 cacheOptions.DefaultSlidingExpiration,
                 "The sliding expiration value must be positive.");
+#pragma warning restore CA2208 // Instantiate argument exceptions correctly
         }
 
         _systemClock = cacheOptions.SystemClock ?? new SystemClock();

src/Caching/StackExchangeRedis/src/RedisCache.cs

@@ -573,10 +573,12 @@ private async Task RefreshAsync(IDatabase cache, string key, DateTimeOffset? abs
     {
         if (options.AbsoluteExpiration.HasValue && options.AbsoluteExpiration <= creationTime)
         {
+#pragma warning disable CA2208 // Instantiate argument exceptions correctly
             throw new ArgumentOutOfRangeException(
                 nameof(DistributedCacheEntryOptions.AbsoluteExpiration),
                 options.AbsoluteExpiration.Value,
                 "The absolute expiration value must be in the future.");
+#pragma warning restore CA2208 // Instantiate argument exceptions correctly
         }
 
         if (options.AbsoluteExpirationRelativeToNow.HasValue)

src/Components/Components/src/Routing/TemplateSegment.cs

@@ -23,8 +23,7 @@ public TemplateSegment(string template, string segment, bool isParameter)
                 Value = segment[1..];
             }
 
-            var invalidCharacterIndex = Value.IndexOf('*');
-            if (invalidCharacterIndex != -1)
+            if (Value.Contains('*'))
             {
                 throw new InvalidOperationException($"Invalid template '{template}'. A catch-all parameter may only have '*' or '**' at the beginning of the segment.");
             }
@@ -93,7 +92,7 @@ public TemplateSegment(string template, string segment, bool isParameter)
 
             // Moving the check for this here instead of TemplateParser so we can allow catch-all.
             // We checked for '*' up above specifically for catch-all segments, this one checks for all others
-            if (Value.IndexOf('*') != -1)
+            if (Value.Contains('*'))
             {
                 throw new InvalidOperationException($"Invalid template '{template}'. The character '*' in parameter segment '{{{segment}}}' is not allowed.");
             }

src/Components/WebAssembly/testassets/WasmLinkerTest/WasmLinkerTest.csproj

@@ -5,6 +5,7 @@
     <SelfContained>true</SelfContained>
     <UseMonoRuntime>true</UseMonoRuntime>
     <UsingMicrosoftNETSdkBlazorWebAssembly>true</UsingMicrosoftNETSdkBlazorWebAssembly>
+    <UsingMicrosoftNETSdkWebAssembly>true</UsingMicrosoftNETSdkWebAssembly>
     <PublishTrimmed>true</PublishTrimmed>
   </PropertyGroup>
   <ItemGroup>

src/Http/Http/src/Internal/ResponseCookies.cs

@@ -122,20 +122,20 @@ public void Delete(string key, CookieOptions options)
         {
             rejectPredicate = (value, encKeyPlusEquals, opts) =>
                 value.StartsWith(encKeyPlusEquals, StringComparison.OrdinalIgnoreCase) &&
-                    value.IndexOf($"domain={opts.Domain}", StringComparison.OrdinalIgnoreCase) != -1 &&
-                    value.IndexOf($"path={opts.Path}", StringComparison.OrdinalIgnoreCase) != -1;
+                    value.Contains($"domain={opts.Domain}", StringComparison.OrdinalIgnoreCase) &&
+                    value.Contains($"path={opts.Path}", StringComparison.OrdinalIgnoreCase);
         }
         else if (domainHasValue)
         {
             rejectPredicate = (value, encKeyPlusEquals, opts) =>
                 value.StartsWith(encKeyPlusEquals, StringComparison.OrdinalIgnoreCase) &&
-                    value.IndexOf($"domain={opts.Domain}", StringComparison.OrdinalIgnoreCase) != -1;
+                    value.Contains($"domain={opts.Domain}", StringComparison.OrdinalIgnoreCase);
         }
         else if (pathHasValue)
         {
             rejectPredicate = (value, encKeyPlusEquals, opts) =>
                 value.StartsWith(encKeyPlusEquals, StringComparison.OrdinalIgnoreCase) &&
-                    value.IndexOf($"path={opts.Path}", StringComparison.OrdinalIgnoreCase) != -1;
+                    value.Contains($"path={opts.Path}", StringComparison.OrdinalIgnoreCase);
         }
         else
         {

src/Http/Routing/src/Patterns/RoutePatternParser.cs

@@ -441,7 +441,7 @@ private static bool IsValidLiteral(Context context, string literal)
         Debug.Assert(context != null);
         Debug.Assert(literal != null);
 
-        if (literal.IndexOf(QuestionMark) != -1)
+        if (literal.Contains(QuestionMark))
         {
             context.Error = Resources.FormatTemplateRoute_InvalidLiteral(literal);
             return false;

src/Logging.AzureAppServices/src/BatchingLoggerProvider.cs

@@ -39,11 +39,15 @@ internal BatchingLoggerProvider(IOptionsMonitor<BatchingLoggerOptions> options)
         var loggerOptions = options.CurrentValue;
         if (loggerOptions.BatchSize <= 0)
         {
+#pragma warning disable CA2208 // Instantiate argument exceptions correctly
             throw new ArgumentOutOfRangeException(nameof(loggerOptions.BatchSize), $"{nameof(loggerOptions.BatchSize)} must be a positive number.");
+#pragma warning restore CA2208 // Instantiate argument exceptions correctly
         }
         if (loggerOptions.FlushPeriod <= TimeSpan.Zero)
         {
+#pragma warning disable CA2208 // Instantiate argument exceptions correctly
             throw new ArgumentOutOfRangeException(nameof(loggerOptions.FlushPeriod), $"{nameof(loggerOptions.FlushPeriod)} must be longer than zero.");
+#pragma warning restore CA2208 // Instantiate argument exceptions correctly
         }
 
         _interval = loggerOptions.FlushPeriod;

src/Mvc/Mvc.Razor/src/ViewPath.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
 namespace Microsoft.AspNetCore.Mvc.Razor;
@@ -8,7 +8,7 @@ internal static class ViewPath
     public static string NormalizePath(string path)
     {
         var addLeadingSlash = path[0] != '\\' && path[0] != '/';
-        var transformSlashes = path.IndexOf('\\') != -1;
+        var transformSlashes = path.Contains('\\');
 
         if (!addLeadingSlash && !transformSlashes)
         {

src/Shared/ChunkingCookieManager/ChunkingCookieManager.cs

@@ -243,11 +243,11 @@ public void DeleteCookie(HttpContext context, string key, CookieOptions options)
         Func<string, bool> predicate = value => keys.Any(k => value.StartsWith(k, StringComparison.OrdinalIgnoreCase));
         if (domainHasValue)
         {
-            rejectPredicate = value => predicate(value) && value.IndexOf("domain=" + options.Domain, StringComparison.OrdinalIgnoreCase) != -1;
+            rejectPredicate = value => predicate(value) && value.Contains("domain=" + options.Domain, StringComparison.OrdinalIgnoreCase);
         }
         else if (pathHasValue)
         {
-            rejectPredicate = value => predicate(value) && value.IndexOf("path=" + options.Path, StringComparison.OrdinalIgnoreCase) != -1;
+            rejectPredicate = value => predicate(value) && value.Contains("path=" + options.Path, StringComparison.OrdinalIgnoreCase);
         }
         else
         {

src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs

@@ -26,7 +26,11 @@ public static CommandOption Option(this CommandLineApplication command, string t
         => command.Option(
             template,
             description,
-            template.IndexOf("<", StringComparison.Ordinal) != -1
+#if NETCOREAPP
+            template.Contains('<')
+#else
+            template.IndexOf('<') != -1
+#endif
                 ? template.EndsWith(">...", StringComparison.Ordinal) ? CommandOptionType.MultipleValue : CommandOptionType.SingleValue
                 : CommandOptionType.NoValue);