Fixing requestcookiecollection

Author: jkotalik

src/Http/Http/src/Internal/RequestCookieCollection.cs

@@ -46,11 +46,6 @@ public string? this[string key]
                     throw new ArgumentNullException(nameof(key));
                 }
 
-                if (Store == null)
-                {
-                    return null;
-                }
-
                 if (TryGetValue(key, out var value))
                 {
                     return value;
@@ -87,10 +82,6 @@ public int Count
         {
             get
             {
-                if (Store == null)
-                {
-                    return 0;
-                }
                 return Store.Count;
             }
         }
@@ -99,26 +90,18 @@ public ICollection<string> Keys
         {
             get
             {
-                if (Store == null)
-                {
-                    return EmptyKeys;
-                }
                 return Store.Keys;
             }
         }
 
         public bool ContainsKey(string key)
         {
-            if (Store == null)
-            {
-                return false;
-            }
             return Store.ContainsKey(key);
         }
 
         public bool TryGetValue(string key, [MaybeNullWhen(false)] out string? value)
         {
-            if (Store == null)
+            if (Store.Count == 0)
             {
                 value = null;
                 return false;
@@ -134,7 +117,7 @@ public bool TryGetValue(string key, [MaybeNullWhen(false)] out string? value)
         /// <returns>An <see cref="Enumerator" /> object that can be used to iterate through the collection.</returns>
         public Enumerator GetEnumerator()
         {
-            if (Store == null || Store.Count == 0)
+            if ( Store.Count == 0)
             {
                 // Non-boxed Enumerator
                 return EmptyEnumerator;
@@ -149,7 +132,7 @@ public Enumerator GetEnumerator()
         /// <returns>An <see cref="IEnumerator{T}" /> object that can be used to iterate through the collection.</returns>
         IEnumerator<KeyValuePair<string, string>> IEnumerable<KeyValuePair<string, string>>.GetEnumerator()
         {
-            if (Store == null || Store.Count == 0)
+            if (Store.Count == 0)
             {
                 // Non-boxed Enumerator
                 return EmptyIEnumeratorType;
@@ -164,7 +147,7 @@ IEnumerator<KeyValuePair<string, string>> IEnumerable<KeyValuePair<string, strin
         /// <returns>An <see cref="IEnumerator" /> object that can be used to iterate through the collection.</returns>
         IEnumerator IEnumerable.GetEnumerator()
         {
-            if (Store == null || Store.Count == 0)
+            if (Store.Count == 0)
             {
                 // Non-boxed Enumerator
                 return EmptyIEnumerator;

src/Shared/Dictionary/SmallCapacityDictionary.cs

@@ -5,6 +5,7 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
+using System.Linq;
 using System.Runtime.CompilerServices;
 
 namespace Microsoft.AspNetCore.Internal.Dictionary
@@ -95,6 +96,15 @@ public static SmallCapacityDictionary<TKey, TValue> FromArray(KeyValuePair<TKey,
             };
         }
 
+        /// <summary>
+        /// Creates a <see cref="SmallCapacityDictionary{TKey, TValue}"/>.
+        /// </summary>
+        /// <param name="from">Dictionary to copy from.</param>
+        public SmallCapacityDictionary(Dictionary<TKey, TValue> from)
+            : this(from.ToList(), from.Count, EqualityComparer<TKey>.Default)
+        {
+        }
+
         /// <summary>
         /// Creates a <see cref="SmallCapacityDictionary{TKey, TValue}"/>.
         /// </summary>