You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- use signalr.npmproj (not Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj) to get non-stable version
- add `_GetPackageVersionInfo` target to all `*.npmproj` projects
- make `_GetPackageVersionInfo` target work when `yarn` is not installed
- switch codesign-xplat.yml to use `dotnet msbuild`
- above change also fixes Code-sign jobs but they're slightly faster using `dotnet msbuild`
Copy file name to clipboardExpand all lines: eng/Publishing.props
+8-5Lines changed: 8 additions & 5 deletions
Original file line number
Diff line number
Diff line change
@@ -31,12 +31,15 @@
31
31
</ItemGroup>
32
32
33
33
<TargetName="_PublishInstallersAndChecksums">
34
-
<!--
35
-
This target is defined in eng/targets/Packaging.targets and included in every C# and F# project.
36
-
We use Microsoft.AspNetCore.DeveloperCertificates.XPlat because it is a nonshipping package, and we need a non-stable version string to use as our publish location.
37
-
If Microsoft.AspNetCore.DeveloperCertificates.XPlat ever becomes a shipping package, this logic will break, so be careful
34
+
<!--
35
+
This target is defined in eng/targets/Packaging.targets and Npm.Common.targets and included in every C#, F#,
36
+
and npm project. We use signalr.npmproj because it is a nonshipping package, we need a non-stable version
37
+
string to use as our publish location, and it is _not_ a C# or F# project. For now at least, C# and F#
38
+
projects should not be referenced when using desktop msbuild.
39
+
!!! If signalr.npmproj ever becomes a shipping package, this logic will break. !!!
0 commit comments