Ensure each test run gets a unique in-memory database

Nate McMaster · Nate McMaster · commit aaaecbf66aeb · 2019-02-22T18:01:30.000-08:00
diff --git a/src/Middleware/HealthChecks.EntityFrameworkCore/test/DbContextHealthCheckTest.cs b/src/Middleware/HealthChecks.EntityFrameworkCore/test/DbContextHealthCheckTest.cs
@@ -104,12 +104,14 @@ public async Task CheckAsync_CustomTest_Unhealthy()
             }
         }
 
+        private static int _testDbCounter;
+
         private static IServiceProvider CreateServices(
             Func<TestDbContext, CancellationToken, Task<bool>> testQuery = null,
             HealthStatus failureStatus = HealthStatus.Unhealthy)
         {
             var serviceCollection = new ServiceCollection();
-            serviceCollection.AddDbContext<TestDbContext>(o => o.UseInMemoryDatabase("Test"));
+            serviceCollection.AddDbContext<TestDbContext>(o => o.UseInMemoryDatabase("Test" + Interlocked.Increment(ref _testDbCounter)));
 
             var builder = serviceCollection.AddHealthChecks();
             builder.AddDbContextCheck<TestDbContext>("test", failureStatus, new[] { "tag1", "tag2", }, testQuery);

Original file line number	Diff line number	Diff line change
`@@ -104,12 +104,14 @@ public async Task CheckAsync_CustomTest_Unhealthy()`
`104`	`104`	`}`
`105`	`105`	`}`
`106`	`106`
	`107`	`+ private static int _testDbCounter;`
	`108`	`+`
`107`	`109`	`private static IServiceProvider CreateServices(`
`108`	`110`	`Func<TestDbContext, CancellationToken, Task<bool>> testQuery = null,`
`109`	`111`	`HealthStatus failureStatus = HealthStatus.Unhealthy)`
`110`	`112`	`{`
`111`	`113`	`var serviceCollection = new ServiceCollection();`
`112`		`- serviceCollection.AddDbContext<TestDbContext>(o => o.UseInMemoryDatabase("Test"));`
	`114`	`+ serviceCollection.AddDbContext<TestDbContext>(o => o.UseInMemoryDatabase("Test" + Interlocked.Increment(ref _testDbCounter)));`
`113`	`115`
`114`	`116`	`var builder = serviceCollection.AddHealthChecks();`
`115`	`117`	`builder.AddDbContextCheck<TestDbContext>("test", failureStatus, new[] { "tag1", "tag2", }, testQuery);`