Skip to content

Commit ab1347e

Browse files
Unskip OpenAPI tests (#14296)
1 parent 828f690 commit ab1347e

File tree

1 file changed

+2
-23
lines changed

1 file changed

+2
-23
lines changed

src/Tools/Microsoft.dotnet-openapi/test/OpenApiAddFileTests.cs

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ public void OpenApi_Add_File_EquivilentPaths()
134134
Assert.Single(openApiRefs);
135135
}
136136

137-
[Fact (Skip = "https://github.com/aspnet/AspNetCore/pull/13571/#issuecomment-531466801")]
137+
[Fact]
138138
public async Task OpenApi_Add_NSwagTypeScript()
139139
{
140140
var project = CreateBasicProject(withOpenApi: true);
@@ -155,20 +155,9 @@ public async Task OpenApi_Add_NSwagTypeScript()
155155
Assert.Contains("<PackageReference Include=\"NSwag.ApiDescription.Client\" Version=\"", content);
156156
Assert.Contains($"<OpenApiReference Include=\"{nswagJsonFile}\" CodeGenerator=\"NSwagTypeScript\" />", content);
157157
}
158-
159-
// Build project and make sure it compiles
160-
using var buildProc = ProcessEx.Run(_outputHelper, _tempDir.Root, "dotnet", "build");
161-
await buildProc.Exited;
162-
Assert.True(buildProc.ExitCode == 0, $"Build failed: {buildProc.Output}");
163-
164-
165-
// Run project and make sure it doesn't crash
166-
using var runProc = ProcessEx.Run(_outputHelper, _tempDir.Root, "dotnet", "run");
167-
Thread.Sleep(100);
168-
Assert.False(runProc.HasExited, $"Run failed with: {runProc.Output}");
169158
}
170159

171-
[Fact (Skip = "https://github.com/aspnet/AspNetCore/pull/13571/#issuecomment-531466801")]
160+
[Fact]
172161
public async Task OpenApi_Add_FromJson()
173162
{
174163
var project = CreateBasicProject(withOpenApi: true);
@@ -189,16 +178,6 @@ public async Task OpenApi_Add_FromJson()
189178
Assert.Contains("<PackageReference Include=\"NSwag.ApiDescription.Client\" Version=\"", content);
190179
Assert.Contains($"<OpenApiReference Include=\"{nswagJsonFile}\"", content);
191180
}
192-
193-
// Build project and make sure it compiles
194-
var buildProc = ProcessEx.Run(_outputHelper, _tempDir.Root, "dotnet", "build");
195-
await buildProc.Exited;
196-
Assert.True(buildProc.ExitCode == 0, $"Build failed: {buildProc.Output}");
197-
198-
// Run project and make sure it doesn't crash
199-
using var runProc = ProcessEx.Run(_outputHelper, _tempDir.Root, "dotnet", "run");
200-
Thread.Sleep(100);
201-
Assert.False(runProc.HasExited, $"Run failed with: {runProc.Output}");
202181
}
203182

204183
[Fact]

0 commit comments

Comments
 (0)