Skip to content

Commit abbd95a

Browse files
committed
Reduce build duplication in Helix jobs
- restore.cmd also don't work well with `-projects`; script unconditionally adds `-all` nit: remove default `-arch x64` option
1 parent 349797a commit abbd95a

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

.azure/pipelines/ci.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -633,11 +633,11 @@ stages:
633633
timeoutInMinutes: 180
634634
steps:
635635
# Build the shared framework
636-
- script: ./build.cmd -ci -nobl -all -pack -arch x64 /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
636+
- script: ./build.cmd -ci -nobl -all -pack /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
637637
displayName: Build shared fx
638-
- script: .\restore.cmd -ci -nobl /p:BuildInteropProjects=true
639-
displayName: Restore interop projects
640-
- script: .\build.cmd -ci -nobl -NoRestore -test -all -projects eng\helix\helix.proj /p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true /p:RunTemplateTests=true /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
638+
- script: ./build.cmd -ci -nobl -projects src/Grpc/**/*.csproj /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
639+
displayName: Build interop projects
640+
- script: ./build.cmd -ci -nobl -noBuild -test -all -projects eng\helix\helix.proj /p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true /p:RunTemplateTests=true /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
641641
displayName: Run build.cmd helix target
642642
env:
643643
HelixApiAccessToken: $(HelixApiAccessToken) # Needed for internal queues
@@ -657,11 +657,11 @@ stages:
657657
timeoutInMinutes: 180
658658
steps:
659659
# Build the shared framework
660-
- script: ./build.cmd -ci -nobl -all -pack -arch x64 /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
660+
- script: ./build.cmd -ci -nobl -all -pack /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
661661
displayName: Build shared fx
662-
- script: .\restore.cmd -ci -nobl /p:BuildInteropProjects=true
663-
displayName: Restore interop projects
664-
- script: .\build.cmd -ci -nobl -NoRestore -test -all -projects eng\helix\helix.proj /p:IsHelixJob=true /p:IsHelixDaily=true /p:BuildInteropProjects=true /p:RunTemplateTests=true /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
662+
- script: ./build.cmd -ci -nobl -projects src/Grpc/**/*.csproj /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
663+
displayName: Build interop projects
664+
- script: ./build.cmd -ci -nobl -noBuild -test -all -projects eng\helix\helix.proj /p:IsHelixJob=true /p:IsHelixDaily=true /p:BuildInteropProjects=true /p:RunTemplateTests=true /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
665665
displayName: Run build.cmd helix target
666666
env:
667667
HelixApiAccessToken: $(HelixApiAccessToken) # Needed for internal queues
@@ -682,9 +682,9 @@ stages:
682682
timeoutInMinutes: 180
683683
steps:
684684
# Build the shared framework
685-
- script: ./restore.sh -ci -nobl
685+
- script: ./restore.sh --ci --nobl
686686
displayName: Restore
687-
- script: ./build.sh -ci --nobl --arch arm64 -test --no-build-nodejs --all -projects $(Build.SourcesDirectory)/eng/helix/helix.proj /p:IsHelixJob=true /p:IsHelixDaily=true /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
687+
- script: ./build.sh --ci --nobl --arch arm64 --test --no-build-nodejs --all --projects $(Build.SourcesDirectory)/eng/helix/helix.proj /p:IsHelixJob=true /p:IsHelixDaily=true /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
688688
displayName: Run build.sh helix arm64 target
689689
env:
690690
HelixApiAccessToken: $(HelixApiAccessToken) # Needed for internal queues

.azure/pipelines/quarantined-tests.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@ jobs:
3131
timeoutInMinutes: 240
3232
steps:
3333
# Build the shared framework
34-
- script: ./build.cmd -ci -all -pack -arch x64 /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log /bl:artifacts/log/helix.build.x64.binlog
34+
- script: ./build.cmd -ci -all -pack /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log /bl:artifacts/log/helix.build.x64.binlog
3535
displayName: Build shared fx
36-
- script: .\restore.cmd -ci /p:BuildInteropProjects=true
37-
displayName: Restore interop projects
38-
- script: .\build.cmd -ci -NoRestore -test -noBuildJava -all -projects eng\helix\helix.proj /p:RunQuarantinedTests=true /p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true /p:RunTemplateTests=true /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log -bl
36+
- script: ./build.cmd -ci -nobl -projects src/Grpc/**/*.csproj /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
37+
displayName: Build interop projects
38+
- script: ./build.cmd -ci -noBuild -test -all -projects eng\helix\helix.proj /p:RunQuarantinedTests=true /p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true /p:RunTemplateTests=true /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
3939
displayName: Run build.cmd helix target
4040
env:
4141
HelixApiAccessToken: $(HelixApiAccessToken) # Needed for internal queues

eng/targets/Helix.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ Usage: dotnet msbuild /t:Helix src/MyTestProject.csproj
8383
</PropertyGroup>
8484
</Target>
8585

86-
<Target Name="_PublishHelixArchive" DependsOnTargets="Publish" >
86+
<Target Name="_PublishHelixArchive" DependsOnTargets="PublishOnly" >
8787
<ZipDirectory Condition="'$(HelixUseArchive)' == 'true'" SourceDirectory="$(PublishDir)" DestinationFile="$(PublishDir)../$(HelixTestName).zip" Overwrite="true" />
8888
<RemoveDir Condition="'$(HelixUseArchive)' == 'true'" Directories="$(PublishDir)" />
8989
</Target>

0 commit comments

Comments
 (0)