Skip to content

Commit aebb921

Browse files
author
John Luo
authored
Re-enable AssemblyTestLogTests (#19686)
1 parent 124a0b6 commit aebb921

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/Testing/test/AssemblyTestLogTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public class AssemblyTestLogTests : LoggedTest
1818
{
1919
private static readonly Assembly ThisAssembly = typeof(AssemblyTestLogTests).GetTypeInfo().Assembly;
2020
private static readonly string ThisAssemblyName = ThisAssembly.GetName().Name;
21-
private static readonly string TFM = new DirectoryInfo(AppContext.BaseDirectory).Name;
21+
private static readonly string TFM = ThisAssembly.GetCustomAttributes().OfType<TestOutputDirectoryAttribute>().FirstOrDefault().TargetFramework;
2222

2323
[Fact]
2424
public void FunctionalLogs_LogsPreservedFromNonQuarantinedTest()
@@ -76,7 +76,7 @@ public Task TestLogEscapesIllegalFileNames() =>
7676
}
7777
});
7878

79-
[Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/19683")]
79+
[Fact]
8080
public Task TestLogWritesToGlobalLogFile() =>
8181
RunTestLogFunctionalTest((tempDir) =>
8282
{
@@ -120,7 +120,7 @@ [OFFSET] [TestLifetime] [Information] Finished test FakeTestName in DURATION
120120
", testLogContent, ignoreLineEndingDifferences: true);
121121
});
122122

123-
[Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/19683")]
123+
[Fact]
124124
public Task TestLogTruncatesTestNameToAvoidLongPaths() =>
125125
RunTestLogFunctionalTest((tempDir) =>
126126
{
@@ -147,7 +147,7 @@ public Task TestLogTruncatesTestNameToAvoidLongPaths() =>
147147
Assert.Equal(longTestName.Substring(longTestName.Length - testFileName.Length / 2, testFileName.Length / 2), testFileName.Substring(testFileName.Length - testFileName.Length / 2, testFileName.Length / 2));
148148
});
149149

150-
[Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/19683")]
150+
[Fact]
151151
public Task TestLogEnumerateFilenamesToAvoidCollisions() =>
152152
RunTestLogFunctionalTest((tempDir) =>
153153
{

0 commit comments

Comments
 (0)