Use Count instead of Any() on List (#18022)

Author: Kahbazi

src/Middleware/Diagnostics.EntityFrameworkCore/src/DatabaseErrorPageMiddleware.cs

@@ -152,7 +152,7 @@ var pendingMigrations
                                         : context.Database.GetMigrations())
                                     .ToArray();
 
-                                if (pendingModelChanges || pendingMigrations.Any())
+                                if (pendingModelChanges || pendingMigrations.Length > 0)
                                 {
                                     var page = new DatabaseErrorPage
                                     {

src/Middleware/HealthChecks/src/HealthCheckOptions.cs

@@ -53,7 +53,7 @@ public IDictionary<HealthStatus, int> ResultStatusCodes
         private static IDictionary<HealthStatus, int> ValidateStatusCodesMapping(IDictionary<HealthStatus,int> mapping)
         {
             var missingHealthStatus = ((HealthStatus[])Enum.GetValues(typeof(HealthStatus))).Except(mapping.Keys).ToList();
-            if (missingHealthStatus.Any())
+            if (missingHealthStatus.Count > 0)
             {
                 var missing = string.Join(", ", missingHealthStatus.Select(status => $"{nameof(HealthStatus)}.{status}"));
                 var message =

src/Middleware/ResponseCompression/src/ResponseCompressionProvider.cs

@@ -93,7 +93,7 @@ public virtual ICompressionProvider GetCompressionProvider(HttpContext context)
                 return null;
             }
 
-            if (!StringWithQualityHeaderValue.TryParseList(accept, out var encodings) || !encodings.Any())
+            if (!StringWithQualityHeaderValue.TryParseList(accept, out var encodings) || encodings.Count == 0)
             {
                 _logger.NoAcceptEncoding();
                 return null;

src/Mvc/Mvc.Core/src/ApplicationModels/ApplicationModelFactory.cs

@@ -106,21 +106,21 @@ public static List<TResult> Flatten<TResult>(
                     attributeRoutingConfigurationErrors);
             }
 
-            if (attributeRoutingConfigurationErrors.Any())
+            if (attributeRoutingConfigurationErrors.Count > 0)
             {
                 var message = CreateAttributeRoutingAggregateErrorMessage(attributeRoutingConfigurationErrors.Values);
 
                 throw new InvalidOperationException(message);
             }
 
             var namedRoutedErrors = ValidateNamedAttributeRoutedActions(actionsByRouteName);
-            if (namedRoutedErrors.Any())
+            if (namedRoutedErrors.Count > 0)
             {
                 var message = CreateAttributeRoutingAggregateErrorMessage(namedRoutedErrors);
                 throw new InvalidOperationException(message);
             }
 
-            if (routeTemplateErrors.Any())
+            if (routeTemplateErrors.Count > 0)
             {
                 var message = CreateAttributeRoutingAggregateErrorMessage(routeTemplateErrors);
                 throw new InvalidOperationException(message);

src/Mvc/Mvc.Core/src/Infrastructure/FileResultExecutorBase.cs

@@ -260,7 +260,7 @@ private static PreconditionState GetEtagMatchState(
             PreconditionState matchFoundState,
             PreconditionState matchNotFoundState)
         {
-            if (etagHeader != null && etagHeader.Any())
+            if (etagHeader?.Count > 0)
             {
                 var state = matchNotFoundState;
                 foreach (var entityTag in etagHeader)

src/Mvc/Mvc.TagHelpers/src/TagHelperOutputExtensions.cs

@@ -277,7 +277,7 @@ public static void RemoveClass(
 
             listOfClasses.RemoveAll(x => x.Equals(encodedClassValue));
 
-            if (listOfClasses.Any())
+            if (listOfClasses.Count > 0)
             {
                 var joinedClasses = new HtmlString(string.Join(" ", listOfClasses));
                 tagHelperOutput.Attributes.SetAttribute(classAttribute.Name, joinedClasses);
@@ -428,4 +428,4 @@ public void WriteTo(TextWriter writer, HtmlEncoder encoder)
             }
         }
     }
-}
+}

src/Security/Authorization/Core/src/AuthorizationPolicy.cs

@@ -37,7 +37,7 @@ public AuthorizationPolicy(IEnumerable<IAuthorizationRequirement> requirements,
                 throw new ArgumentNullException(nameof(authenticationSchemes));
             }
 
-            if (requirements.Count() == 0)
+            if (!requirements.Any())
             {
                 throw new InvalidOperationException(Resources.Exception_AuthorizationPolicyEmpty);
             }
@@ -150,15 +150,15 @@ public static async Task<AuthorizationPolicy> CombineAsync(IAuthorizationPolicyP
                     }
 
                     var rolesSplit = authorizeDatum.Roles?.Split(',');
-                    if (rolesSplit != null && rolesSplit.Any())
+                    if (rolesSplit?.Length > 0)
                     {
                         var trimmedRolesSplit = rolesSplit.Where(r => !string.IsNullOrWhiteSpace(r)).Select(r => r.Trim());
                         policyBuilder.RequireRole(trimmedRolesSplit);
                         useDefaultPolicy = false;
                     }
 
                     var authTypesSplit = authorizeDatum.AuthenticationSchemes?.Split(',');
-                    if (authTypesSplit != null && authTypesSplit.Any())
+                    if (authTypesSplit?.Length > 0)
                     {
                         foreach (var authType in authTypesSplit)
                         {

src/Security/Authorization/Core/src/RolesAuthorizationRequirement.cs

@@ -25,7 +25,7 @@ public RolesAuthorizationRequirement(IEnumerable<string> allowedRoles)
                 throw new ArgumentNullException(nameof(allowedRoles));
             }
 
-            if (allowedRoles.Count() == 0)
+            if (!allowedRoles.Any())
             {
                 throw new InvalidOperationException(Resources.Exception_RoleRequirementEmpty);
             }

src/Security/Authorization/Policy/src/AuthorizationMiddleware.cs

@@ -68,7 +68,7 @@ public async Task Invoke(HttpContext context)
 
             if (authorizeResult.Challenged)
             {
-                if (policy.AuthenticationSchemes.Any())
+                if (policy.AuthenticationSchemes.Count > 0)
                 {
                     foreach (var scheme in policy.AuthenticationSchemes)
                     {
@@ -84,7 +84,7 @@ public async Task Invoke(HttpContext context)
             }
             else if (authorizeResult.Forbidden)
             {
-                if (policy.AuthenticationSchemes.Any())
+                if (policy.AuthenticationSchemes.Count > 0)
                 {
                     foreach (var scheme in policy.AuthenticationSchemes)
                     {

src/Shared/Buffers.MemoryPool/DiagnosticMemoryPool.cs

@@ -119,7 +119,7 @@ protected override void Dispose(bool disposing)
                         MemoryPoolThrowHelper.ThrowInvalidOperationException_DisposingPoolWithActiveBlocks(_totalBlocks - _blocks.Count, _totalBlocks, _blocks.ToArray());
                     }
 
-                    if (_blockAccessExceptions.Any())
+                    if (_blockAccessExceptions.Count > 0)
                     {
                         throw CreateAccessExceptions();
                     }
@@ -136,7 +136,7 @@ protected override void Dispose(bool disposing)
 
         private void SetAllBlocksReturned()
         {
-            if (_blockAccessExceptions.Any())
+            if (_blockAccessExceptions.Count > 0)
             {
                 _allBlocksReturned.SetException(CreateAccessExceptions());
             }

src/Shared/CertificateGeneration/CertificateManager.cs

@@ -752,7 +752,7 @@ public DetailedEnsureCertificateResult EnsureValidCertificateExists(
             result.ResultCode = EnsureCertificateResult.Succeeded;
 
             X509Certificate2 certificate = null;
-            if (certificates.Count() > 0)
+            if (certificates.Any())
             {
                 result.Diagnostics.Debug("Found valid certificates present on the machine.");
                 result.Diagnostics.Debug(result.Diagnostics.DescribeCertificates(certificates));

src/SignalR/server/Core/src/Internal/DefaultHubDispatcher.cs

@@ -489,7 +489,7 @@ private void InitializeHub(THub hub, HubConnectionContext connection)
         private Task<bool> IsHubMethodAuthorized(IServiceProvider provider, HubConnectionContext hubConnectionContext, IList<IAuthorizeData> policies, string hubMethodName, object[] hubMethodArguments)
         {
             // If there are no policies we don't need to run auth
-            if (!policies.Any())
+            if (policies.Count == 0)
             {
                 return TaskCache.True;
             }

src/SignalR/server/Core/src/Internal/TypedClientBuilder.cs

@@ -131,7 +131,7 @@ private static void BuildMethod(TypeBuilder type, MethodInfo interfaceMethodInfo
             var genericTypeNames =
                 paramTypes.Where(p => p.IsGenericParameter).Select(p => p.Name).Distinct().ToArray();
 
-            if (genericTypeNames.Any())
+            if (genericTypeNames.Length > 0)
             {
                 methodBuilder.DefineGenericParameters(genericTypeNames);
             }

src/Tools/Microsoft.dotnet-openapi/src/Commands/BaseCommand.cs

@@ -159,7 +159,7 @@ internal async Task AddOpenAPIReference(
             var items = project.GetItems(tagName);
             var fileItems = items.Where(i => string.Equals(GetFullPath(i.EvaluatedInclude), GetFullPath(sourceFile), StringComparison.Ordinal));
 
-            if (fileItems.Count() > 0)
+            if (fileItems.Any())
             {
                 Warning.Write($"One or more references to {sourceFile} already exist in '{project.FullPath}'. Duplicate references could lead to unexpected behavior.");
                 return;
@@ -376,7 +376,7 @@ private string GetFileNameFromResponse(IHttpResponseMessageWrapper response, str
             else
             {
                 var uri = new Uri(url);
-                if (uri.Segments.Count() > 0 && uri.Segments.Last() != "/")
+                if (uri.Segments.Any() && uri.Segments.Last() != "/")
                 {
                     var lastSegment = uri.Segments.Last();
                     if (!Path.HasExtension(lastSegment))