Skip to content

Commit c13ea52

Browse files
author
John Luo
committed
Feedback
1 parent 587b8dc commit c13ea52

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

eng/helix/vstest/runtests.cmd

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,11 @@ if errorlevel 1 (
4545

4646
set FLAKY_FILTER="Flaky:All=true|Flaky:Helix:All=true|Flaky:Helix:Queue:All=true|Flaky:Helix:Queue:%HELIX%=true"
4747
echo Running known-flaky tests.
48-
%DOTNET_ROOT%\dotnet vstest %target% --logger:trx;LogFileName=test-results.xml --TestCaseFilter:%FLAKY_FILTER%
48+
%DOTNET_ROOT%\dotnet vstest %target% --logger:trx --TestCaseFilter:%FLAKY_FILTER%
4949
if errorlevel 1 (
5050
echo Failure in flaky test 1>&2
5151
REM DO NOT EXIT and DO NOT SET EXIT_CODE to 1
5252
)
5353

54-
rem Normalize test result file name
55-
56-
ren TestResults\test-results*.xml test-results.xml
57-
5854
exit %exit_code%
5955

eng/helix/vstest/runtests.sh

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,14 +81,10 @@ if [ $nonflaky_exitcode != 0 ]; then
8181
fi
8282
FLAKY_FILTER="Flaky:All=true|Flaky:Helix:All=true|Flaky:Helix:Queue:All=true|Flaky:Helix:Queue:$HELIX=true"
8383
echo "Running known-flaky tests."
84-
$DOTNET_ROOT/dotnet vstest $1 '--logger:trx;LogFileName=test-results.xml' --TestCaseFilter:"$FLAKY_FILTER"
84+
$DOTNET_ROOT/dotnet vstest $1 --logger:trx --TestCaseFilter:"$FLAKY_FILTER"
8585
if [ $? != 0 ]; then
8686
echo "Flaky tests failed!" 1>&2
8787
# DO NOT EXIT
8888
fi
8989

90-
# Normalize test result file name
91-
92-
mv TestResults/test-results*.xml test-results.xml
93-
9490
exit $nonflaky_exitcode

0 commit comments

Comments
 (0)