Skip to content

Commit c5a1999

Browse files
[SignalR Java] Update to RxJava3 (#31426)
1 parent ed3a2b7 commit c5a1999

16 files changed

+43
-43
lines changed

src/SignalR/clients/java/signalr/core/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ group 'com.microsoft.signalr'
88
dependencies {
99
implementation 'com.google.code.gson:gson:2.8.5'
1010
implementation 'com.squareup.okhttp3:okhttp:3.11.0'
11-
api 'io.reactivex.rxjava2:rxjava:2.2.3'
11+
api 'io.reactivex.rxjava3:rxjava:3.0.11'
1212
implementation 'org.slf4j:slf4j-api:1.7.25'
1313
}
1414

src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/DefaultHttpClient.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
import java.util.concurrent.locks.Lock;
1414
import java.util.concurrent.locks.ReentrantLock;
1515

16-
import io.reactivex.Single;
17-
import io.reactivex.subjects.SingleSubject;
16+
import io.reactivex.rxjava3.core.Single;
17+
import io.reactivex.rxjava3.subjects.SingleSubject;
1818
import okhttp3.*;
1919
import okio.ByteString;
2020

src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/HttpClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import java.util.HashMap;
88
import java.util.Map;
99

10-
import io.reactivex.Single;
10+
import io.reactivex.rxjava3.core.Single;
1111

1212
class HttpRequest {
1313
private String method;

src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/HttpHubConnectionBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import java.util.HashMap;
77
import java.util.Map;
88

9-
import io.reactivex.Single;
9+
import io.reactivex.rxjava3.core.Single;
1010
import okhttp3.OkHttpClient;
1111

1212
/**

src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/HubConnection.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@
1919

2020
import com.google.gson.stream.JsonReader;
2121

22-
import io.reactivex.Completable;
23-
import io.reactivex.Observable;
24-
import io.reactivex.Single;
25-
import io.reactivex.subjects.*;
22+
import io.reactivex.rxjava3.core.Completable;
23+
import io.reactivex.rxjava3.core.Observable;
24+
import io.reactivex.rxjava3.core.Single;
25+
import io.reactivex.rxjava3.subjects.*;
2626
import okhttp3.OkHttpClient;
2727

2828
/**

src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/InvocationRequest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
import java.lang.reflect.Type;
77
import java.util.concurrent.CancellationException;
88

9-
import io.reactivex.subjects.ReplaySubject;
10-
import io.reactivex.subjects.Subject;
9+
import io.reactivex.rxjava3.subjects.ReplaySubject;
10+
import io.reactivex.rxjava3.subjects.Subject;
1111

1212
class InvocationRequest {
1313
private final Type returnType;

src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/LongPollingTransport.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
import org.slf4j.Logger;
1414
import org.slf4j.LoggerFactory;
1515

16-
import io.reactivex.Completable;
17-
import io.reactivex.Single;
18-
import io.reactivex.subjects.CompletableSubject;
16+
import io.reactivex.rxjava3.core.Completable;
17+
import io.reactivex.rxjava3.core.Single;
18+
import io.reactivex.rxjava3.subjects.CompletableSubject;
1919

2020
class LongPollingTransport implements Transport {
2121
private OnReceiveCallBack onReceiveCallBack;

src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/OkHttpWebSocketWrapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
import org.slf4j.Logger;
1212
import org.slf4j.LoggerFactory;
1313

14-
import io.reactivex.Completable;
15-
import io.reactivex.subjects.CompletableSubject;
14+
import io.reactivex.rxjava3.core.Completable;
15+
import io.reactivex.rxjava3.subjects.CompletableSubject;
1616
import okhttp3.Headers;
1717
import okhttp3.OkHttpClient;
1818
import okhttp3.Request;

src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/Transport.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
import java.nio.ByteBuffer;
77

8-
import io.reactivex.Completable;
8+
import io.reactivex.rxjava3.core.Completable;
99

1010
interface Transport {
1111
Completable start(String url);

src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/WebSocketTransport.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import org.slf4j.Logger;
1010
import org.slf4j.LoggerFactory;
1111

12-
import io.reactivex.Completable;
12+
import io.reactivex.rxjava3.core.Completable;
1313

1414
class WebSocketTransport implements Transport {
1515
private WebSocketWrapper webSocketClient;

src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/WebSocketWrapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
import java.nio.ByteBuffer;
77

8-
import io.reactivex.Completable;
8+
import io.reactivex.rxjava3.core.Completable;
99

1010
abstract class WebSocketWrapper {
1111
public abstract Completable start();

src/SignalR/clients/java/signalr/test/src/main/java/com/microsoft/signalr/HubConnectionTest.java

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@
1919
import org.junit.jupiter.api.Test;
2020

2121
import ch.qos.logback.classic.spi.ILoggingEvent;
22-
import io.reactivex.Completable;
23-
import io.reactivex.Observable;
24-
import io.reactivex.Single;
25-
import io.reactivex.disposables.Disposable;
26-
import io.reactivex.schedulers.Schedulers;
27-
import io.reactivex.subjects.CompletableSubject;
28-
import io.reactivex.subjects.PublishSubject;
29-
import io.reactivex.subjects.ReplaySubject;
30-
import io.reactivex.subjects.SingleSubject;
22+
import io.reactivex.rxjava3.core.Completable;
23+
import io.reactivex.rxjava3.core.Observable;
24+
import io.reactivex.rxjava3.core.Single;
25+
import io.reactivex.rxjava3.disposables.Disposable;
26+
import io.reactivex.rxjava3.schedulers.Schedulers;
27+
import io.reactivex.rxjava3.subjects.CompletableSubject;
28+
import io.reactivex.rxjava3.subjects.PublishSubject;
29+
import io.reactivex.rxjava3.subjects.ReplaySubject;
30+
import io.reactivex.rxjava3.subjects.SingleSubject;
3131

3232
class HubConnectionTest {
3333
private static final String RECORD_SEPARATOR = "\u001e";
@@ -1423,7 +1423,7 @@ public void invokeNoReturnValueWaitsForCompletion() {
14231423

14241424
mockTransport.receiveMessage("{\"type\":3,\"invocationId\":\"1\"}" + RECORD_SEPARATOR);
14251425

1426-
assertNull(result.timeout(30, TimeUnit.SECONDS).blockingGet());
1426+
assertTrue(result.blockingAwait(30, TimeUnit.SECONDS));
14271427
assertTrue(done.get());
14281428
}
14291429

@@ -1445,7 +1445,7 @@ public void invokeNoReturnValueWaitsForCompletionWithMessagePack() {
14451445

14461446
mockTransport.receiveMessage(ByteBuffer.wrap(new byte[] { 0x06, (byte) 0x94, 0x03, (byte) 0x80, (byte) 0xA1, 0x31, 0x02 }));
14471447

1448-
assertNull(result.timeout(30, TimeUnit.SECONDS).blockingGet());
1448+
assertTrue(result.blockingAwait(30, TimeUnit.SECONDS));
14491449
assertTrue(done.get());
14501450
}
14511451

@@ -1466,7 +1466,7 @@ public void invokeCompletedByCompletionMessageWithResult() {
14661466

14671467
mockTransport.receiveMessage("{\"type\":3,\"invocationId\":\"1\",\"result\":42}" + RECORD_SEPARATOR);
14681468

1469-
assertNull(result.timeout(30, TimeUnit.SECONDS).blockingGet());
1469+
assertTrue(result.blockingAwait(30, TimeUnit.SECONDS));
14701470
assertTrue(done.get());
14711471
}
14721472

@@ -1488,7 +1488,7 @@ public void invokeCompletedByCompletionMessageWithResultWithMessagePack() {
14881488

14891489
mockTransport.receiveMessage(ByteBuffer.wrap(new byte[] { 0x07, (byte) 0x95, 0x03, (byte) 0x80, (byte) 0xA1, 0x31, 0x03, 0x2A }));
14901490

1491-
assertNull(result.timeout(30, TimeUnit.SECONDS).blockingGet());
1491+
assertTrue(result.blockingAwait(30, TimeUnit.SECONDS));
14921492
assertTrue(done.get());
14931493
}
14941494

@@ -1529,7 +1529,7 @@ public void invokeNoReturnValueHandlesError() {
15291529

15301530
mockTransport.receiveMessage("{\"type\":3,\"invocationId\":\"1\",\"error\":\"There was an error\"}" + RECORD_SEPARATOR);
15311531

1532-
result.timeout(30, TimeUnit.SECONDS).blockingGet();
1532+
assertTrue(result.onErrorComplete().blockingAwait(30, TimeUnit.SECONDS));
15331533

15341534
AtomicReference<String> errorMessage = new AtomicReference<>();
15351535
result.doOnError(error -> {
@@ -1559,7 +1559,7 @@ public void invokeNoReturnValueHandlesErrorWithMessagePack() {
15591559
0x72, 0x65, 0x20, 0x77, 0x61, 0x73, 0x20, 0x61, 0x6E, 0x20, 0x65, 0x72, 0x72, 0x6F, 0x72 };
15601560
mockTransport.receiveMessage(ByteBuffer.wrap(completionMessageErrorBytes));
15611561

1562-
result.timeout(30, TimeUnit.SECONDS).blockingGet();
1562+
assertTrue(result.onErrorComplete().blockingAwait(30, TimeUnit.SECONDS));
15631563

15641564
AtomicReference<String> errorMessage = new AtomicReference<>();
15651565
result.doOnError(error -> {
@@ -3885,6 +3885,6 @@ public void hubConnectionCloseCallsStop() {
38853885
assertEquals(HubConnectionState.CONNECTED, hubConnection.getConnectionState());
38863886
}
38873887

3888-
close.timeout(30, TimeUnit.SECONDS).blockingGet();
3888+
assertTrue(close.blockingAwait(30, TimeUnit.SECONDS));
38893889
}
38903890
}

src/SignalR/clients/java/signalr/test/src/main/java/com/microsoft/signalr/LongPollingTransportTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515

1616
import org.junit.jupiter.api.Test;
1717

18-
import io.reactivex.Single;
19-
import io.reactivex.subjects.CompletableSubject;
18+
import io.reactivex.rxjava3.core.Single;
19+
import io.reactivex.rxjava3.subjects.CompletableSubject;
2020

2121
public class LongPollingTransportTest {
2222

src/SignalR/clients/java/signalr/test/src/main/java/com/microsoft/signalr/MockTransport.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
import java.nio.ByteBuffer;
77
import java.util.ArrayList;
88

9-
import io.reactivex.Completable;
10-
import io.reactivex.subjects.CompletableSubject;
11-
import io.reactivex.subjects.SingleSubject;
9+
import io.reactivex.rxjava3.core.Completable;
10+
import io.reactivex.rxjava3.subjects.CompletableSubject;
11+
import io.reactivex.rxjava3.subjects.SingleSubject;
1212

1313
class MockTransport implements Transport {
1414
private OnReceiveCallBack onReceiveCallBack;

src/SignalR/clients/java/signalr/test/src/main/java/com/microsoft/signalr/TestHttpClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import java.util.List;
99
import java.util.Map;
1010

11-
import io.reactivex.Single;
11+
import io.reactivex.rxjava3.core.Single;
1212

1313
class TestHttpClient extends HttpClient {
1414
private TestHttpRequestHandler handler;

src/SignalR/clients/java/signalr/test/src/main/java/com/microsoft/signalr/WebSocketTransportTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313

1414
import org.junit.jupiter.api.Test;
1515

16-
import io.reactivex.Completable;
17-
import io.reactivex.Single;
16+
import io.reactivex.rxjava3.core.Completable;
17+
import io.reactivex.rxjava3.core.Single;
1818

1919
class WebSocketTransportTest {
2020
@Test

0 commit comments

Comments
 (0)