Skip to content

Commit d35b770

Browse files
Fix unnanotated fallthroughs - C26819
1 parent 0959589 commit d35b770

File tree

4 files changed

+4
-1
lines changed

4 files changed

+4
-1
lines changed

src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/dllmain.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ BOOL WINAPI DllMain(HMODULE hModule,
5757
// this is a bug in IIS. To try to avoid AVs, we will set a global flag
5858
g_fInShutdown = TRUE;
5959
StaticCleanup();
60+
break;
6061
default:
6162
break;
6263
}

src/Servers/IIS/AspNetCoreModuleV2/DefaultRules.ruleset

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@
9999
<Rule Id="C26498" Action="Error" />
100100
<Rule Id="C26814" Action="None" /> <!-- The const variable 'variable' can be computed at compile time. Consider using constexpr -->
101101
<Rule Id="C26818" Action="None" /> <!-- Switch statement does not cover all cases. Consider adding a 'default' label -->
102-
<Rule Id="C26819" Action="None" /> <!-- Unannotated fallthrough -->
102+
<Rule Id="C26819" Action="Error" />
103103
<Rule Id="C26826" Action="None" /> <!-- Don't use C-style variable arguments -->
104104
<Rule Id="C26859" Action="None" /> <!-- Empty optional '<var>' is unwrapped, will throw exception. -->
105105
<Rule Id="C28020" Action="None" /> <!-- The expression 'expr' is not true at this call -->

src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/dllmain.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ BOOL APIENTRY DllMain(HMODULE hModule,
8585
IN_PROCESS_HANDLER::StaticTerminate();
8686
ALLOC_CACHE_HANDLER::StaticTerminate();
8787
DebugStop();
88+
break;
8889
default:
8990
break;
9091
}

src/Servers/IIS/AspNetCoreModuleV2/OutOfProcessRequestHandler/dllmain.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,7 @@ BOOL APIENTRY DllMain(HMODULE hModule,
223223
FORWARDING_HANDLER::StaticTerminate();
224224
ALLOC_CACHE_HANDLER::StaticTerminate();
225225
DebugStop();
226+
break;
226227
default:
227228
break;
228229
}

0 commit comments

Comments
 (0)