Avoid some allocations by checked IsEnabled first in MVC

Author: gfoidl

src/Mvc/Mvc.Razor/src/MvcRazorLoggerExtensions.cs

@@ -41,7 +41,8 @@ static MvcRazorLoggerExtensions()
             _viewCompilerEndCodeGeneration = LoggerMessage.Define<string, double>(
                 LogLevel.Debug,
                 new EventId(2, "ViewCompilerEndCodeGeneration"),
-                "Code generation for the Razor file at '{FilePath}' completed in {ElapsedMilliseconds}ms.");
+                "Code generation for the Razor file at '{FilePath}' completed in {ElapsedMilliseconds}ms.",
+                skipEnabledCheck: true);
 
             _viewCompilerLocatedCompiledView = LoggerMessage.Define<string>(
                 LogLevel.Debug,
@@ -98,7 +99,8 @@ static MvcRazorLoggerExtensions()
             _generatedCodeToAssemblyCompilationEnd = LoggerMessage.Define<string, double>(
                 LogLevel.Debug,
                 new EventId(2, "GeneratedCodeToAssemblyCompilationEnd"),
-                "Compilation of the generated code for the Razor file at '{FilePath}' completed in {ElapsedMilliseconds}ms.");
+                "Compilation of the generated code for the Razor file at '{FilePath}' completed in {ElapsedMilliseconds}ms.",
+                skipEnabledCheck: true);
 
             _tagHelperComponentInitialized = LoggerMessage.Define<string>(
                 LogLevel.Debug,
@@ -121,7 +123,7 @@ public static void ViewCompilerStartCodeGeneration(this ILogger logger, string f
         public static void ViewCompilerEndCodeGeneration(this ILogger logger, string filePath, long startTimestamp)
         {
             // Don't log if logging wasn't enabled at start of request as time will be wildly wrong.
-            if (startTimestamp != 0)
+            if (startTimestamp != 0 && logger.IsEnabled(LogLevel.Debug))
             {
                 var currentTimestamp = Stopwatch.GetTimestamp();
                 var elapsed = new TimeSpan((long)(TimestampToTicks * (currentTimestamp - startTimestamp)));
@@ -192,7 +194,7 @@ public static void TagHelperComponentProcessed(this ILogger logger, string compo
         public static void GeneratedCodeToAssemblyCompilationEnd(this ILogger logger, string filePath, long startTimestamp)
         {
             // Don't log if logging wasn't enabled at start of request as time will be wildly wrong.
-            if (startTimestamp != 0)
+            if (startTimestamp != 0 && logger.IsEnabled(LogLevel.Debug))
             {
                 var currentTimestamp = Stopwatch.GetTimestamp();
                 var elapsed = new TimeSpan((long)(TimestampToTicks * (currentTimestamp - startTimestamp)));

src/Mvc/Mvc.ViewFeatures/src/MvcViewFeaturesLoggerExtensions.cs

@@ -44,13 +44,15 @@ static MvcViewFeaturesLoggerExtensions()
             _viewComponentExecuting = LoggerMessage.Define<string, string[]>(
                 LogLevel.Debug,
                 new EventId(1, "ViewComponentExecuting"),
-                "Executing view component {ViewComponentName} with arguments ({Arguments}).");
+                "Executing view component {ViewComponentName} with arguments ({Arguments}).",
+                skipEnabledCheck: true);
 
             _viewComponentExecuted = LoggerMessage.Define<string, double, string>(
                 LogLevel.Debug,
                 new EventId(2, "ViewComponentExecuted"),
                 "Executed view component {ViewComponentName} in {ElapsedMilliseconds}ms and returned " +
-                "{ViewComponentResult}");
+                "{ViewComponentResult}",
+                skipEnabledCheck: true);
 
             _partialViewResultExecuting = LoggerMessage.Define<string>(
                 LogLevel.Information,
@@ -136,8 +138,11 @@ public static void ViewComponentExecuting(
             ViewComponentContext context,
             object[] arguments)
         {
-            var formattedArguments = GetFormattedArguments(arguments);
-            _viewComponentExecuting(logger, context.ViewComponentDescriptor.DisplayName, formattedArguments, null);
+            if (logger.IsEnabled(LogLevel.Debug))
+            {
+                var formattedArguments = GetFormattedArguments(arguments);
+                _viewComponentExecuting(logger, context.ViewComponentDescriptor.DisplayName, formattedArguments, null);
+            }
         }
 
         private static string[] GetFormattedArguments(object[] arguments)
@@ -163,12 +168,15 @@ public static void ViewComponentExecuted(
             object result)
         {
             // Don't log if logging wasn't enabled at start of request as time will be wildly wrong.
-            _viewComponentExecuted(
-                logger,
-                context.ViewComponentDescriptor.DisplayName,
-                timespan.TotalMilliseconds,
-                Convert.ToString(result, CultureInfo.InvariantCulture),
-                null);
+            if (logger.IsEnabled(LogLevel.Debug))
+            {
+                _viewComponentExecuted(
+                    logger,
+                    context.ViewComponentDescriptor.DisplayName,
+                    timespan.TotalMilliseconds,
+                    Convert.ToString(result, CultureInfo.InvariantCulture),
+                    null);
+            }
         }
 
         public static void PartialViewFound(