Make SocketConnectionFactory internal for now

halter73 · halter73 · commit db7f16cfba39 · 2019-10-03T17:01:48.000-07:00
diff --git a/src/Servers/Kestrel/Transport.Sockets/src/Client/SocketConnectionFactory.cs b/src/Servers/Kestrel/Transport.Sockets/src/Client/SocketConnectionFactory.cs
@@ -15,7 +15,7 @@
 
 namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.Client
 {
-    public class SocketConnectionFactory : IConnectionFactory, IAsyncDisposable
+    internal class SocketConnectionFactory : IConnectionFactory, IAsyncDisposable
     {
         private readonly SocketTransportOptions _options;
         private readonly MemoryPool<byte> _memoryPool;
diff --git a/src/Servers/Kestrel/Transport.Sockets/src/Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.csproj b/src/Servers/Kestrel/Transport.Sockets/src/Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.csproj
@@ -26,6 +26,10 @@
     <Reference Include="Microsoft.Extensions.Options" />
   </ItemGroup>
 
+  <ItemGroup>
+    <InternalsVisibleTo Include="http2cat" />
+  </ItemGroup>
+
   <ItemGroup>
     <EmbeddedResource Update="SocketsStrings.resx">
       <Generator></Generator>
diff --git a/src/Servers/Kestrel/samples/http2cat/http2cat.csproj b/src/Servers/Kestrel/samples/http2cat/http2cat.csproj
@@ -5,10 +5,6 @@
     <TargetFramework>netcoreapp5.0</TargetFramework>
   </PropertyGroup>
 
-  <ItemGroup>
-    <Compile Include="$(KestrelSharedSourceRoot)\DuplexPipe.cs" Link="Internal\DuplexPipe.cs" />
-  </ItemGroup>
-
   <ItemGroup>
     <Reference Include="Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets" />
     <Reference Include="Microsoft.AspNetCore.Server.Kestrel.Core" />

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`
`16`	`16`	`namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.Client`
`17`	`17`	`{`
`18`		`- public class SocketConnectionFactory : IConnectionFactory, IAsyncDisposable`
	`18`	`+ internal class SocketConnectionFactory : IConnectionFactory, IAsyncDisposable`
`19`	`19`	`{`
`20`	`20`	`private readonly SocketTransportOptions _options;`
`21`	`21`	`private readonly MemoryPool<byte> _memoryPool;`