Skip to content

Commit df33890

Browse files
[master] Update dependencies from aspnet/AspNetCore-Tooling (#18112)
* Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20200103.1 - Microsoft.AspNetCore.Mvc.Razor.Extensions - 5.0.0-alpha.1.20053.1 - Microsoft.AspNetCore.Razor.Language - 5.0.0-alpha.1.20053.1 - Microsoft.CodeAnalysis.Razor - 5.0.0-alpha.1.20053.1 - Microsoft.NET.Sdk.Razor - 5.0.0-alpha.1.20053.1 Dependency coherency updates - Microsoft.AspNetCore.Analyzer.Testing - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.AspNetCore.BenchmarkRunner.Sources - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.ActivatorUtilities.Sources - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Caching.Abstractions - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Caching.Memory - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Caching.SqlServer - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Caching.StackExchangeRedis - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.CommandLineUtils.Sources - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Abstractions - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.AzureKeyVault - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Binder - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.CommandLine - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.EnvironmentVariables - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.FileExtensions - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Ini - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Json - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.KeyPerFile - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.UserSecrets - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Xml - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.DependencyInjection.Abstractions - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.DependencyInjection - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.DiagnosticAdapter - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Diagnostics.HealthChecks - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.FileProviders.Abstractions - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.FileProviders.Composite - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.FileProviders.Embedded - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.FileProviders.Physical - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.FileSystemGlobbing - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.HashCodeCombiner.Sources - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Hosting.Abstractions - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Hosting - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.HostFactoryResolver.Sources - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Http - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Localization.Abstractions - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Localization - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.Abstractions - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.AzureAppServices - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.Configuration - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.Console - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.Debug - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.EventSource - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.EventLog - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.TraceSource - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.Testing - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.ObjectPool - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Options.ConfigurationExtensions - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Options.DataAnnotations - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Options - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.ParameterDefaultValue.Sources - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Primitives - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.TypeNameHelper.Sources - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.ValueStopwatch.Sources - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.WebEncoders - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Internal.Extensions.Refs - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.JSInterop - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Mono.WebAssembly.Interop - 5.0.0-preview3.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Internal.AspNetCore.Analyzers - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.AspNetCore.Testing - 5.0.0-alpha.1.20053.1 (parent: Microsoft.AspNetCore.Razor.Language) * fix up * refs Co-authored-by: Brennan <[email protected]>
1 parent e1bf38c commit df33890

File tree

9 files changed

+199
-255
lines changed

9 files changed

+199
-255
lines changed

eng/Version.Details.xml

Lines changed: 130 additions & 130 deletions
Large diffs are not rendered by default.

eng/Versions.props

Lines changed: 65 additions & 65 deletions
Large diffs are not rendered by default.

src/Mvc/Mvc.Localization/ref/Microsoft.AspNetCore.Mvc.Localization.netcoreapp.cs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ public HtmlLocalizer(Microsoft.Extensions.Localization.IStringLocalizer localize
1313
public virtual Microsoft.Extensions.Localization.LocalizedString GetString(string name, params object[] arguments) { throw null; }
1414
protected virtual Microsoft.AspNetCore.Mvc.Localization.LocalizedHtmlString ToHtmlString(Microsoft.Extensions.Localization.LocalizedString result) { throw null; }
1515
protected virtual Microsoft.AspNetCore.Mvc.Localization.LocalizedHtmlString ToHtmlString(Microsoft.Extensions.Localization.LocalizedString result, object[] arguments) { throw null; }
16-
[System.ObsoleteAttribute("This method is obsolete. Use `CurrentCulture` and `CurrentUICulture` instead.")]
17-
public virtual Microsoft.AspNetCore.Mvc.Localization.IHtmlLocalizer WithCulture(System.Globalization.CultureInfo culture) { throw null; }
1816
}
1917
public static partial class HtmlLocalizerExtensions
2018
{
@@ -36,8 +34,6 @@ public HtmlLocalizer(Microsoft.AspNetCore.Mvc.Localization.IHtmlLocalizerFactory
3634
public virtual System.Collections.Generic.IEnumerable<Microsoft.Extensions.Localization.LocalizedString> GetAllStrings(bool includeParentCultures) { throw null; }
3735
public virtual Microsoft.Extensions.Localization.LocalizedString GetString(string name) { throw null; }
3836
public virtual Microsoft.Extensions.Localization.LocalizedString GetString(string name, params object[] arguments) { throw null; }
39-
[System.ObsoleteAttribute("This method is obsolete. Use `CurrentCulture` and `CurrentUICulture` instead.")]
40-
public virtual Microsoft.AspNetCore.Mvc.Localization.IHtmlLocalizer WithCulture(System.Globalization.CultureInfo culture) { throw null; }
4137
}
4238
public partial interface IHtmlLocalizer
4339
{
@@ -46,8 +42,6 @@ public partial interface IHtmlLocalizer
4642
System.Collections.Generic.IEnumerable<Microsoft.Extensions.Localization.LocalizedString> GetAllStrings(bool includeParentCultures);
4743
Microsoft.Extensions.Localization.LocalizedString GetString(string name);
4844
Microsoft.Extensions.Localization.LocalizedString GetString(string name, params object[] arguments);
49-
[System.ObsoleteAttribute("This method is obsolete. Use `CurrentCulture` and `CurrentUICulture` instead.")]
50-
Microsoft.AspNetCore.Mvc.Localization.IHtmlLocalizer WithCulture(System.Globalization.CultureInfo culture);
5145
}
5246
public partial interface IHtmlLocalizerFactory
5347
{
@@ -79,8 +73,6 @@ public void Contextualize(Microsoft.AspNetCore.Mvc.Rendering.ViewContext viewCon
7973
public System.Collections.Generic.IEnumerable<Microsoft.Extensions.Localization.LocalizedString> GetAllStrings(bool includeParentCultures) { throw null; }
8074
public Microsoft.Extensions.Localization.LocalizedString GetString(string name) { throw null; }
8175
public Microsoft.Extensions.Localization.LocalizedString GetString(string name, params object[] values) { throw null; }
82-
[System.ObsoleteAttribute("This method is obsolete. Use `CurrentCulture` and `CurrentUICulture` instead.")]
83-
public Microsoft.AspNetCore.Mvc.Localization.IHtmlLocalizer WithCulture(System.Globalization.CultureInfo culture) { throw null; }
8476
}
8577
}
8678
namespace Microsoft.Extensions.DependencyInjection

src/Mvc/Mvc.Localization/src/HtmlLocalizer.cs

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
using System;
55
using System.Collections.Generic;
6-
using System.Globalization;
76
using Microsoft.Extensions.Localization;
87

98
namespace Microsoft.AspNetCore.Mvc.Localization
@@ -84,20 +83,6 @@ public virtual LocalizedString GetString(string name, params object[] arguments)
8483
public virtual IEnumerable<LocalizedString> GetAllStrings(bool includeParentCultures) =>
8584
_localizer.GetAllStrings(includeParentCultures);
8685

87-
/// <inheritdoc />
88-
[Obsolete("This method is obsolete. Use `CurrentCulture` and `CurrentUICulture` instead.")]
89-
public virtual IHtmlLocalizer WithCulture(CultureInfo culture)
90-
{
91-
if (culture == null)
92-
{
93-
throw new ArgumentNullException(nameof(culture));
94-
}
95-
96-
#pragma warning disable CS0618 // Type or member is obsolete
97-
return new HtmlLocalizer(_localizer.WithCulture(culture));
98-
#pragma warning restore CS0618 // Type or member is obsolete
99-
}
100-
10186
/// <summary>
10287
/// Creates a new <see cref="LocalizedHtmlString"/> for a <see cref="LocalizedString"/>.
10388
/// </summary>

src/Mvc/Mvc.Localization/src/HtmlLocalizerOfT.cs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -79,19 +79,5 @@ public virtual LocalizedString GetString(string name, params object[] arguments)
7979
/// <inheritdoc />
8080
public virtual IEnumerable<LocalizedString> GetAllStrings(bool includeParentCultures) =>
8181
_localizer.GetAllStrings(includeParentCultures);
82-
83-
/// <inheritdoc />
84-
[Obsolete("This method is obsolete. Use `CurrentCulture` and `CurrentUICulture` instead.")]
85-
public virtual IHtmlLocalizer WithCulture(CultureInfo culture)
86-
{
87-
if (culture == null)
88-
{
89-
throw new ArgumentNullException(nameof(culture));
90-
}
91-
92-
#pragma warning disable CS0618 // Type or member is obsolete
93-
return _localizer.WithCulture(culture);
94-
#pragma warning restore CS0618 // Type or member is obsolete
95-
}
9682
}
9783
}

src/Mvc/Mvc.Localization/src/IHtmlLocalizer.cs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,5 @@ public interface IHtmlLocalizer
5353
/// </param>
5454
/// <returns>The strings.</returns>
5555
IEnumerable<LocalizedString> GetAllStrings(bool includeParentCultures);
56-
57-
/// <summary>
58-
/// Creates a new <see cref="IHtmlLocalizer"/> for a specific <see cref="CultureInfo"/>.
59-
/// </summary>
60-
/// <param name="culture">The <see cref="CultureInfo"/> to use.</param>
61-
/// <returns>A culture-specific <see cref="IHtmlLocalizer"/>.</returns>
62-
[Obsolete("This method is obsolete. Use `CurrentCulture` and `CurrentUICulture` instead.")]
63-
IHtmlLocalizer WithCulture(CultureInfo culture);
6456
}
6557
}

src/Mvc/Mvc.Localization/src/ViewLocalizer.cs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,6 @@ public virtual LocalizedHtmlString this[string key]
7979
/// <inheritdoc />
8080
public LocalizedString GetString(string name, params object[] values) => _localizer.GetString(name, values);
8181

82-
/// <inheritdoc />
83-
[Obsolete("This method is obsolete. Use `CurrentCulture` and `CurrentUICulture` instead.")]
84-
85-
#pragma warning disable CS0618 // Type or member is obsolete
86-
public IHtmlLocalizer WithCulture(CultureInfo culture) => _localizer.WithCulture(culture);
87-
#pragma warning restore CS0618 // Type or member is obsolete
88-
8982
/// <inheritdoc />
9083
public IEnumerable<LocalizedString> GetAllStrings(bool includeParentCultures) =>
9184
_localizer.GetAllStrings(includeParentCultures);

src/Mvc/Mvc.Localization/test/HtmlLocalizerTest.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -207,14 +207,12 @@ public void HtmlLocalizer_Html_ReturnsLocalizedHtmlString()
207207
public void HtmlLocalizer_WithCulture_ReturnsLocalizedHtmlString()
208208
{
209209
// Arrange
210-
var stringLocalizer = new TestStringLocalizer();
210+
var stringLocalizer = new TestStringLocalizer(new CultureInfo("fr"));
211211

212212
var htmlLocalizer = new HtmlLocalizer(stringLocalizer);
213213

214214
// Act
215-
#pragma warning disable CS0618 // Type or member is obsolete
216-
var actualLocalizedHtmlString = htmlLocalizer.WithCulture(new CultureInfo("fr"))["John"];
217-
#pragma warning restore CS0618 // Type or member is obsolete
215+
var actualLocalizedHtmlString = htmlLocalizer["John"];
218216

219217
// Assert
220218
Assert.Equal("Bonjour John", actualLocalizedHtmlString.Value);

src/Mvc/Mvc.Localization/test/ViewLocalizerTest.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ public void ViewLocalizer_HtmlWithArguments_ReturnsLocalizedHtmlString()
266266
public void ViewLocalizer_WithCulture_ReturnsLocalizedHtmlString()
267267
{
268268
// Arrange
269-
var stringLocalizer = new TestStringLocalizer();
269+
var stringLocalizer = new TestStringLocalizer(new CultureInfo("fr"));
270270
var htmlLocalizer = new HtmlLocalizer(stringLocalizer);
271271
var hostingEnvironment = new Mock<IWebHostEnvironment>();
272272
hostingEnvironment.Setup(a => a.ApplicationName).Returns("TestApplication");
@@ -280,9 +280,7 @@ public void ViewLocalizer_WithCulture_ReturnsLocalizedHtmlString()
280280
viewLocalizer.Contextualize(viewContext);
281281

282282
// Act
283-
#pragma warning disable CS0618 // Type or member is obsolete
284-
var actualLocalizedString = viewLocalizer.WithCulture(new CultureInfo("fr"))["John"];
285-
#pragma warning restore CS0618 // Type or member is obsolete
283+
var actualLocalizedString = htmlLocalizer["John"];
286284

287285
// Assert
288286
Assert.Equal("Bonjour John", actualLocalizedString.Value);

0 commit comments

Comments
 (0)