Skip to content

Commit f5b6039

Browse files
author
N. Taylor Mullen
committed
Add docs for Microsoft.AspNetCore.Mvc.TagHelpers.
- Also obsoleted two unused members on `ImageTagHelper`. - Removed `NoWarn` for docs on `Microsoft.AspNetCore.Mvc.TagHelpers`. Addresses aspnet/Docs/#10593
1 parent 07dad89 commit f5b6039

22 files changed

+148
-19
lines changed

‎src/Mvc/Mvc.TagHelpers/ref/Microsoft.AspNetCore.Mvc.TagHelpers.netcoreapp3.0.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,10 +221,15 @@ public GlobbingUrlBuilder(Microsoft.Extensions.FileProviders.IFileProvider fileP
221221
[Microsoft.AspNetCore.Razor.TagHelpers.HtmlTargetElementAttribute("img", Attributes="asp-append-version,src", TagStructure=Microsoft.AspNetCore.Razor.TagHelpers.TagStructure.WithoutEndTag)]
222222
public partial class ImageTagHelper : Microsoft.AspNetCore.Mvc.Razor.TagHelpers.UrlResolutionTagHelper
223223
{
224+
[System.ObsoleteAttribute("This constructor is obsolete and will be removed in a future version.")]
224225
public ImageTagHelper(Microsoft.AspNetCore.Hosting.IWebHostEnvironment hostingEnvironment, Microsoft.AspNetCore.Mvc.Razor.Infrastructure.TagHelperMemoryCacheProvider cacheProvider, Microsoft.AspNetCore.Mvc.ViewFeatures.IFileVersionProvider fileVersionProvider, System.Text.Encodings.Web.HtmlEncoder htmlEncoder, Microsoft.AspNetCore.Mvc.Routing.IUrlHelperFactory urlHelperFactory) : base (default(Microsoft.AspNetCore.Mvc.Routing.IUrlHelperFactory), default(System.Text.Encodings.Web.HtmlEncoder)) { }
226+
[Microsoft.Extensions.DependencyInjection.ActivatorUtilitiesConstructorAttribute]
227+
public ImageTagHelper(Microsoft.AspNetCore.Mvc.ViewFeatures.IFileVersionProvider fileVersionProvider, System.Text.Encodings.Web.HtmlEncoder htmlEncoder, Microsoft.AspNetCore.Mvc.Routing.IUrlHelperFactory urlHelperFactory) : base (default(Microsoft.AspNetCore.Mvc.Routing.IUrlHelperFactory), default(System.Text.Encodings.Web.HtmlEncoder)) { }
225228
[Microsoft.AspNetCore.Razor.TagHelpers.HtmlAttributeNameAttribute("asp-append-version")]
226229
public bool AppendVersion { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } [System.Runtime.CompilerServices.CompilerGeneratedAttribute]set { } }
230+
[System.ObsoleteAttribute("This property is obsolete and will be removed in a future version.")]
227231
protected internal Microsoft.Extensions.Caching.Memory.IMemoryCache Cache { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
232+
[System.ObsoleteAttribute("This property is obsolete and will be removed in a future version.")]
228233
protected internal Microsoft.AspNetCore.Hosting.IWebHostEnvironment HostingEnvironment { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
229234
public override int Order { get { throw null; } }
230235
[Microsoft.AspNetCore.Razor.TagHelpers.HtmlAttributeNameAttribute("src")]

‎src/Mvc/Mvc.TagHelpers/src/AnchorTagHelper.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,9 @@ public AnchorTagHelper(IHtmlGenerator generator)
5252
/// <inheritdoc />
5353
public override int Order => -1000;
5454

55+
/// <summary>
56+
/// Gets the <see cref="IHtmlGenerator"/> used to generate the <see cref="AnchorTagHelper"/>'s output.
57+
/// </summary>
5558
protected IHtmlGenerator Generator { get; }
5659

5760
/// <summary>

‎src/Mvc/Mvc.TagHelpers/src/Cache/DistributedCacheTagHelperService.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,13 @@ public class DistributedCacheTagHelperService : IDistributedCacheTagHelperServic
3939
private readonly ILogger _logger;
4040
private readonly ConcurrentDictionary<CacheTagKey, Task<IHtmlContent>> _workers;
4141

42+
/// <summary>
43+
/// Creates a new <see cref="DistributedCacheTagHelperService"/>.
44+
/// </summary>
45+
/// <param name="storage">The <see cref="DistributedCacheTagHelper"/>'s <see cref="IDistributedCacheTagHelperStorage"/>.</param>
46+
/// <param name="formatter">The <see cref="IDistributedCacheTagHelperFormatter"/> for cache value serialization.</param>
47+
/// <param name="HtmlEncoder">The <see cref="HtmlEncoder"/> used to encode cache content.</param>
48+
/// <param name="loggerFactory">The <see cref="ILoggerFactory"/>.</param>
4249
public DistributedCacheTagHelperService(
4350
IDistributedCacheTagHelperStorage storage,
4451
IDistributedCacheTagHelperFormatter formatter,

‎src/Mvc/Mvc.TagHelpers/src/CacheTagHelperMemoryCacheFactory.cs

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,16 @@
66

77
namespace Microsoft.AspNetCore.Mvc.TagHelpers
88
{
9+
/// <summary>
10+
/// A factory for <see cref="IMemoryCache"/>s configured using <see cref="CacheTagHelperOptions"/>.
11+
/// <see cref="CacheTagHelper"/> uses this factory to set its <see cref="CacheTagHelper.MemoryCache"/>.
12+
/// </summary>
913
public class CacheTagHelperMemoryCacheFactory
1014
{
15+
/// <summary>
16+
/// Creates a new <see cref="CacheTagHelperMemoryCacheFactory"/>.
17+
/// </summary>
18+
/// <param name="options">The <see cref="CacheTagHelperOptions"/> to apply to the <see cref="Cache"/>.</param>
1119
public CacheTagHelperMemoryCacheFactory(IOptions<CacheTagHelperOptions> options)
1220
{
1321
Cache = new MemoryCache(new MemoryCacheOptions
@@ -22,6 +30,9 @@ internal CacheTagHelperMemoryCacheFactory(IMemoryCache cache)
2230
Cache = cache;
2331
}
2432

33+
/// <summary>
34+
/// Gets the <see cref="IMemoryCache"/>.
35+
/// </summary>
2536
public IMemoryCache Cache { get; }
2637
}
2738
}

‎src/Mvc/Mvc.TagHelpers/src/EnvironmentTagHelper.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,9 @@ public EnvironmentTagHelper(IWebHostEnvironment hostingEnvironment)
5959
/// </remarks>
6060
public string Exclude { get; set; }
6161

62+
/// <summary>
63+
/// Gets the <see cref="IWebHostEnvironment"/> for the application.
64+
/// </summary>
6265
protected IWebHostEnvironment HostingEnvironment { get; }
6366

6467
/// <inheritdoc />

‎src/Mvc/Mvc.TagHelpers/src/FormActionTagHelper.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,9 @@ public FormActionTagHelper(IUrlHelperFactory urlHelperFactory)
9898
[ViewContext]
9999
public ViewContext ViewContext { get; set; }
100100

101+
/// <summary>
102+
/// Gets the <see cref="IUrlHelperFactory"/> used to create an <see cref="IUrlHelper"/> to generate links.
103+
/// </summary>
101104
protected IUrlHelperFactory UrlHelperFactory { get; }
102105

103106
/// <summary>

‎src/Mvc/Mvc.TagHelpers/src/FormTagHelper.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,16 @@ public FormTagHelper(IHtmlGenerator generator)
4545
/// <inheritdoc />
4646
public override int Order => -1000;
4747

48+
/// <summary>
49+
/// Gets the <see cref="Rendering.ViewContext"/> of the executing view.
50+
/// </summary>
4851
[HtmlAttributeNotBound]
4952
[ViewContext]
5053
public ViewContext ViewContext { get; set; }
5154

55+
/// <summary>
56+
/// Gets the <see cref="IHtmlGenerator"/> used to generate the <see cref="FormTagHelper"/>'s output.
57+
/// </summary>
5258
protected IHtmlGenerator Generator { get; }
5359

5460
/// <summary>

‎src/Mvc/Mvc.TagHelpers/src/ImageTagHelper.cs

Lines changed: 30 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,31 @@ public class ImageTagHelper : UrlResolutionTagHelper
3232
/// <summary>
3333
/// Creates a new <see cref="ImageTagHelper"/>.
3434
/// </summary>
35-
/// <param name="hostingEnvironment">The <see cref="IHostingEnvironment"/>.</param>
36-
/// <param name="cacheProvider">The <see cref="TagHelperMemoryCacheProvider"/>.</param>
3735
/// <param name="fileVersionProvider">The <see cref="IFileVersionProvider"/>.</param>
3836
/// <param name="htmlEncoder">The <see cref="HtmlEncoder"/> to use.</param>
3937
/// <param name="urlHelperFactory">The <see cref="IUrlHelperFactory"/>.</param>
4038
// Decorated with ActivatorUtilitiesConstructor since we want to influence tag helper activation
4139
// to use this constructor in the default case.
40+
[ActivatorUtilitiesConstructor]
41+
public ImageTagHelper(
42+
IFileVersionProvider fileVersionProvider,
43+
HtmlEncoder htmlEncoder,
44+
IUrlHelperFactory urlHelperFactory)
45+
: base(urlHelperFactory, htmlEncoder)
46+
{
47+
FileVersionProvider = fileVersionProvider;
48+
}
49+
50+
/// <summary>
51+
/// Creates a new <see cref="ImageTagHelper"/>.
52+
/// This constructor is obsolete and will be removed in a future version.
53+
/// </summary>
54+
/// <param name="hostingEnvironment">The <see cref="IHostingEnvironment"/>.</param>
55+
/// <param name="cacheProvider">The <see cref="TagHelperMemoryCacheProvider"/>.</param>
56+
/// <param name="fileVersionProvider">The <see cref="IFileVersionProvider"/>.</param>
57+
/// <param name="htmlEncoder">The <see cref="HtmlEncoder"/> to use.</param>
58+
/// <param name="urlHelperFactory">The <see cref="IUrlHelperFactory"/>.</param>
59+
[Obsolete("This constructor is obsolete and will be removed in a future version.")]
4260
public ImageTagHelper(
4361
IWebHostEnvironment hostingEnvironment,
4462
TagHelperMemoryCacheProvider cacheProvider,
@@ -73,8 +91,18 @@ public ImageTagHelper(
7391
[HtmlAttributeName(AppendVersionAttributeName)]
7492
public bool AppendVersion { get; set; }
7593

94+
/// <summary>
95+
/// Gets the <see cref="IWebHostEnvironment"/> for the application.
96+
/// This property is obsolete and will be removed in a future version.
97+
/// </summary>
98+
[Obsolete("This property is obsolete and will be removed in a future version.")]
7699
protected internal IWebHostEnvironment HostingEnvironment { get; }
77100

101+
/// <summary>
102+
/// Gets the <see cref="IMemoryCache"/> used to store globbed urls.
103+
/// This property is obsolete and will be removed in a future version.
104+
/// </summary>
105+
[Obsolete("This property is obsolete and will be removed in a future version.")]
78106
protected internal IMemoryCache Cache { get; }
79107

80108
internal IFileVersionProvider FileVersionProvider { get; private set; }

‎src/Mvc/Mvc.TagHelpers/src/InputTagHelper.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,14 @@ public InputTagHelper(IHtmlGenerator generator)
7676
/// <inheritdoc />
7777
public override int Order => -1000;
7878

79+
/// <summary>
80+
/// Gets the <see cref="IHtmlGenerator"/> used to generate the <see cref="InputTagHelper"/>'s output.
81+
/// </summary>
7982
protected IHtmlGenerator Generator { get; }
8083

84+
/// <summary>
85+
/// Gets the <see cref="Rendering.ViewContext"/> of the executing view.
86+
/// </summary>
8187
[HtmlAttributeNotBound]
8288
[ViewContext]
8389
public ViewContext ViewContext { get; set; }

‎src/Mvc/Mvc.TagHelpers/src/LabelTagHelper.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,16 @@ public LabelTagHelper(IHtmlGenerator generator)
2929
/// <inheritdoc />
3030
public override int Order => -1000;
3131

32+
/// <summary>
33+
/// Gets the <see cref="Rendering.ViewContext"/> of the executing view.
34+
/// </summary>
3235
[HtmlAttributeNotBound]
3336
[ViewContext]
3437
public ViewContext ViewContext { get; set; }
3538

39+
/// <summary>
40+
/// Gets the <see cref="IHtmlGenerator"/> used to generate the <see cref="LabelTagHelper"/>'s output.
41+
/// </summary>
3642
protected IHtmlGenerator Generator { get; }
3743

3844
/// <summary>

‎src/Mvc/Mvc.TagHelpers/src/LinkTagHelper.cs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,12 +210,24 @@ public LinkTagHelper(
210210
[HtmlAttributeName(FallbackTestValueAttributeName)]
211211
public string FallbackTestValue { get; set; }
212212

213+
/// <summary>
214+
/// Gets the <see cref="IWebHostEnvironment"/> for the application.
215+
/// </summary>
213216
protected internal IWebHostEnvironment HostingEnvironment { get; }
214217

218+
/// <summary>
219+
/// Gets the <see cref="IMemoryCache"/> used to store globbed urls.
220+
/// </summary>
215221
protected internal IMemoryCache Cache { get; }
216222

223+
/// <summary>
224+
/// Gets the <see cref="System.Text.Encodings.Web.JavaScriptEncoder"/> used to encode fallback information.
225+
/// </summary>
217226
protected JavaScriptEncoder JavaScriptEncoder { get; }
218227

228+
/// <summary>
229+
/// Gets the <see cref="GlobbingUrlBuilder"/> used to populate included and excluded urls.
230+
/// </summary>
219231
// Internal for ease of use when testing.
220232
protected internal GlobbingUrlBuilder GlobbingUrlBuilder { get; set; }
221233

‎src/Mvc/Mvc.TagHelpers/src/Microsoft.AspNetCore.Mvc.TagHelpers.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
<PropertyGroup>
44
<Description>ASP.NET Core MVC default tag helpers. Contains tag helpers for anchor tags, HTML input elements, caching, scripts, links (for CSS), and more.</Description>
55
<TargetFramework>netcoreapp3.0</TargetFramework>
6-
<NoWarn>$(NoWarn);CS1591</NoWarn>
76
<GenerateDocumentationFile>true</GenerateDocumentationFile>
87
<PackageTags>aspnetcore;aspnetcoremvc;taghelper;taghelpers</PackageTags>
98
<IsAspNetCoreApp>true</IsAspNetCoreApp>

‎src/Mvc/Mvc.TagHelpers/src/OptionTagHelper.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,14 @@ public OptionTagHelper(IHtmlGenerator generator)
3232
/// <inheritdoc />
3333
public override int Order => -1000;
3434

35+
/// <summary>
36+
/// Gets the <see cref="IHtmlGenerator"/> used to generate the <see cref="OptionTagHelper"/>'s output.
37+
/// </summary>
3538
protected IHtmlGenerator Generator { get; }
3639

40+
/// <summary>
41+
/// Gets the <see cref="Rendering.ViewContext"/> of the executing view.
42+
/// </summary>
3743
[HtmlAttributeNotBound]
3844
[ViewContext]
3945
public ViewContext ViewContext { get; set; }

‎src/Mvc/Mvc.TagHelpers/src/PartialTagHelper.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@ public class PartialTagHelper : TagHelper
3232
private readonly ICompositeViewEngine _viewEngine;
3333
private readonly IViewBufferScope _viewBufferScope;
3434

35+
/// <summary>
36+
/// Creates a new <see cref="PartialTagHelper"/>.
37+
/// </summary>
38+
/// <param name="viewEngine">The <see cref="ICompositeViewEngine"/> used to locate the partial view.</param>
39+
/// <param name="viewBufferScope">The <see cref="IViewBufferScope"/>.</param>
3540
public PartialTagHelper(
3641
ICompositeViewEngine viewEngine,
3742
IViewBufferScope viewBufferScope)
@@ -91,6 +96,9 @@ public object Model
9196
/// </summary>
9297
public ViewDataDictionary ViewData { get; set; }
9398

99+
/// <summary>
100+
/// Gets the <see cref="Rendering.ViewContext"/> of the executing view.
101+
/// </summary>
94102
[HtmlAttributeNotBound]
95103
[ViewContext]
96104
public ViewContext ViewContext { get; set; }

‎src/Mvc/Mvc.TagHelpers/src/RenderAtEndOfFormTagHelper.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@ public class RenderAtEndOfFormTagHelper : TagHelper
2323
/// <inheritdoc />
2424
public override int Order => -900;
2525

26+
/// <summary>
27+
/// Gets the <see cref="Rendering.ViewContext"/> of the executing view.
28+
/// </summary>
2629
[HtmlAttributeNotBound]
2730
[ViewContext]
2831
public ViewContext ViewContext { get; set; }

‎src/Mvc/Mvc.TagHelpers/src/ScriptTagHelper.cs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,14 +176,26 @@ public ScriptTagHelper(
176176
[HtmlAttributeName(FallbackTestExpressionAttributeName)]
177177
public string FallbackTestExpression { get; set; }
178178

179+
/// <summary>
180+
/// Gets the <see cref="IWebHostEnvironment"/> for the application.
181+
/// </summary>
179182
protected internal IWebHostEnvironment HostingEnvironment { get; }
180183

184+
/// <summary>
185+
/// Gets the <see cref="IMemoryCache"/> used to store globbed urls.
186+
/// </summary>
181187
protected internal IMemoryCache Cache { get; private set; }
182188

183189
internal IFileVersionProvider FileVersionProvider { get; private set; }
184190

191+
/// <summary>
192+
/// Gets the <see cref="System.Text.Encodings.Web.JavaScriptEncoder"/> used to encode fallback information.
193+
/// </summary>
185194
protected JavaScriptEncoder JavaScriptEncoder { get; }
186195

196+
/// <summary>
197+
/// Gets the <see cref="GlobbingUrlBuilder"/> used to populate included and excluded urls.
198+
/// </summary>
187199
// Internal for ease of use when testing.
188200
protected internal GlobbingUrlBuilder GlobbingUrlBuilder { get; set; }
189201

‎src/Mvc/Mvc.TagHelpers/src/SelectTagHelper.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,14 @@ public SelectTagHelper(IHtmlGenerator generator)
3737
/// <inheritdoc />
3838
public override int Order => -1000;
3939

40+
/// <summary>
41+
/// Gets the <see cref="IHtmlGenerator"/> used to generate the <see cref="SelectTagHelper"/>'s output.
42+
/// </summary>
4043
protected IHtmlGenerator Generator { get; }
4144

45+
/// <summary>
46+
/// Gets the <see cref="Rendering.ViewContext"/> of the executing view.
47+
/// </summary>
4248
[HtmlAttributeNotBound]
4349
[ViewContext]
4450
public ViewContext ViewContext { get; set; }

‎src/Mvc/Mvc.TagHelpers/src/TextAreaTagHelper.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,14 @@ public TextAreaTagHelper(IHtmlGenerator generator)
2929
/// <inheritdoc />
3030
public override int Order => -1000;
3131

32+
/// <summary>
33+
/// Gets the <see cref="IHtmlGenerator"/> used to generate the <see cref="TextAreaTagHelper"/>'s output.
34+
/// </summary>
3235
protected IHtmlGenerator Generator { get; }
3336

37+
/// <summary>
38+
/// Gets the <see cref="Rendering.ViewContext"/> of the executing view.
39+
/// </summary>
3440
[HtmlAttributeNotBound]
3541
[ViewContext]
3642
public ViewContext ViewContext { get; set; }

‎src/Mvc/Mvc.TagHelpers/src/ValidationMessageTagHelper.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,21 @@ public ValidationMessageTagHelper(IHtmlGenerator generator)
3232
/// <inheritdoc />
3333
public override int Order => -1000;
3434

35+
/// <summary>
36+
/// Gets the <see cref="Rendering.ViewContext"/> of the executing view.
37+
/// </summary>
3538
[HtmlAttributeNotBound]
3639
[ViewContext]
3740
public ViewContext ViewContext { get; set; }
3841

42+
/// <summary>
43+
/// Gets the <see cref="IHtmlGenerator"/> used to generate the <see cref="ValidationMessageTagHelper"/>'s output.
44+
/// </summary>
3945
protected IHtmlGenerator Generator { get; }
4046

47+
/// <summary>
48+
/// Gets an expression to be evaluated against the current model.
49+
/// </summary>
4150
[HtmlAttributeName(ValidationForAttributeName)]
4251
public ModelExpression For { get; set; }
4352

‎src/Mvc/Mvc.TagHelpers/src/ValidationSummaryTagHelper.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,16 @@ public ValidationSummaryTagHelper(IHtmlGenerator generator)
3030
/// <inheritdoc />
3131
public override int Order => -1000;
3232

33+
/// <summary>
34+
/// Gets the <see cref="Rendering.ViewContext"/> of the executing view.
35+
/// </summary>
3336
[HtmlAttributeNotBound]
3437
[ViewContext]
3538
public ViewContext ViewContext { get; set; }
3639

40+
/// <summary>
41+
/// Gets the <see cref="IHtmlGenerator"/> used to generate the <see cref="ValidationSummaryTagHelper"/>'s output.
42+
/// </summary>
3743
[HtmlAttributeNotBound]
3844
protected IHtmlGenerator Generator { get; }
3945

‎src/Mvc/Mvc.TagHelpers/test/DefaultTagHelperActivatorTest.cs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -53,20 +53,6 @@ public void LinkTagHelper_DoesNotUseMemoryCacheInstanceFromDI()
5353
Assert.Same(FileVersionProvider, linkTagHelper.FileVersionProvider);
5454
}
5555

56-
[Fact]
57-
public void ImageTagHelper_DoesNotUseMemoryCacheInstanceFromDI()
58-
{
59-
// Arrange
60-
var activator = new DefaultTagHelperActivator(new TypeActivatorCache());
61-
var viewContext = CreateViewContext();
62-
63-
var imageTagHelper = activator.Create<ImageTagHelper>(viewContext);
64-
65-
Assert.Same(CacheProvider.Cache, imageTagHelper.Cache);
66-
Assert.Same(HostingEnvironment, imageTagHelper.HostingEnvironment);
67-
Assert.Same(FileVersionProvider, imageTagHelper.FileVersionProvider);
68-
}
69-
7056
private ViewContext CreateViewContext()
7157
{
7258
var services = new ServiceCollection()

‎src/Mvc/Mvc.TagHelpers/test/ImageTagHelperTest.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -264,8 +264,6 @@ private static ImageTagHelper GetHelper(
264264
var fileVersionProvider = new DefaultFileVersionProvider(hostingEnvironment, cacheProvider);
265265

266266
return new ImageTagHelper(
267-
hostingEnvironment,
268-
new TagHelperMemoryCacheProvider(),
269267
fileVersionProvider,
270268
new HtmlTestEncoder(),
271269
urlHelperFactory)

0 commit comments

Comments
 (0)