Enable normal Arcade publish infrastructure

- create manifests and artifacts as post-build expects

plus
- enable test signing in internal PRs

Author: dougbu

.azure/pipelines/ci.yml

@@ -33,7 +33,7 @@ variables:
 - ${{ if ne(variables['System.TeamProject'], 'internal') }}:
   - name: _BuildArgs
     value: ''
-  - name: _SigningArgs
+  - name: _PublishArgs
     value: ''
   - name: _SignType
     value: ''
@@ -50,9 +50,9 @@ variables:
     - name: _SignType
       value: real
 
-    # The following extra properties are not set when building on Linux or macOS but are needed on Windows.
-    - name: _SigningArgs
-      value: /p:DotNetSignType=$(_SignType)
+    # The following extra properties are not set when testing. Use with final build.[cmd,sh] of asset-producing jobs.
+    - name: _PublishArgs
+      value: /p:Publish=true
              /p:DotNetPublishBlobFeedKey=$(dotnetfeed-storage-access-key-1)
              /p:DotNetPublishBlobFeedUrl=https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json
              /p:DotNetPublishToBlobFeed=$(_DotNetPublishToBlobFeed)
@@ -63,8 +63,8 @@ variables:
       value: ''
     - name: _SignType
       valule: test
-    - name: _SigningArgs
-      value: /p:DotNetSignType=$(_SignType)
+    - name: _PublishArgs
+      value: ''
 
 stages:
 - stage: build
@@ -111,7 +111,6 @@ stages:
                 -buildNative
                 /bl:artifacts/log/build.x64.binlog
                 $(_BuildArgs)
-                $(_SigningArgs)
         displayName: Build x64
 
       # Build the x86 shared framework
@@ -127,7 +126,6 @@ stages:
                 /p:OnlyPackPlatformSpecificPackages=true
                 /bl:artifacts/log/build.x86.binlog
                 $(_BuildArgs)
-                $(_SigningArgs)
         displayName: Build x86
 
       # This is in a separate build step with -forceCoreMsbuild to workaround MAX_PATH limitations - https://github.com/Microsoft/msbuild/issues/53
@@ -136,7 +134,6 @@ stages:
                 -pack
                 -noBuildDeps
                 $(_BuildArgs)
-                $(_SigningArgs)
         displayName: Build SiteExtension
 
       # This runs code-signing on all packages, zips, and jar files as defined in build/CodeSign.targets. If https://github.com/dotnet/arcade/issues/1957 is resolved,
@@ -148,8 +145,8 @@ stages:
                 -noRestore
                 -sign
                 /bl:artifacts/log/build.codesign.binlog
+                /p:DotNetSignType=$(_SignType)
                 $(_BuildArgs)
-                $(_SigningArgs)
         displayName: Code sign packages
 
       # Windows installers bundle both x86 and x64 assets
@@ -158,8 +155,9 @@ stages:
                 -sign
                 -buildInstallers
                 /bl:artifacts/log/installers.msbuild.binlog
+                /p:DotNetSignType=$(_SignType)
                 $(_BuildArgs)
-                $(_SigningArgs)
+                $(_PublishArgs)
         displayName: Build Installers
 
       artifacts:
@@ -186,10 +184,11 @@ stages:
         -pack
         -noBuildNodeJS
         -noBuildJava
-        /p:OnlyPackPlatformSpecificPackages=true
         /bl:artifacts/log/build.win-arm.binlog
+        /p:DotNetSignType=$(_SignType)
+        /p:OnlyPackPlatformSpecificPackages=true
         $(_BuildArgs)
-        $(_SigningArgs)
+        $(_PublishArgs)
       installNodeJs: false
       installJdk: false
       artifacts:
@@ -215,6 +214,7 @@ stages:
         -p:OnlyPackPlatformSpecificPackages=true
         -bl:artifacts/log/build.macos.binlog
         $(_BuildArgs)
+        $(_PublishArgs)
       installNodeJs: false
       installJdk: false
       artifacts:
@@ -274,6 +274,7 @@ stages:
             -p:LinuxInstallerType=rpm \
             -bl:artifacts/log/build.rpm.binlog \
             $(_BuildArgs)
+            $(_PublishArgs)
         displayName: Build RPM installers
       installNodeJs: false
       installJdk: false
@@ -304,6 +305,7 @@ stages:
         -p:OnlyPackPlatformSpecificPackages=true
         -bl:artifacts/log/build.linux-arm.binlog
         $(_BuildArgs)
+        $(_PublishArgs)
       installNodeJs: false
       installJdk: false
       artifacts:
@@ -333,6 +335,7 @@ stages:
         -p:OnlyPackPlatformSpecificPackages=true
         -bl:artifacts/log/build.arm64.binlog
         $(_BuildArgs)
+        $(_PublishArgs)
       installNodeJs: false
       installJdk: false
       artifacts:
@@ -365,6 +368,7 @@ stages:
         -p:OnlyPackPlatformSpecificPackages=true
         -bl:artifacts/log/build.musl.binlog
         $(_BuildArgs)
+        $(_PublishArgs)
       installNodeJs: false
       installJdk: false
       artifacts:
@@ -397,6 +401,7 @@ stages:
         -p:OnlyPackPlatformSpecificPackages=true
         -bl:artifacts/log/build.musl.binlog
         $(_BuildArgs)
+        $(_PublishArgs)
       installNodeJs: false
       installJdk: false
       artifacts:

.azure/pipelines/jobs/codesign-xplat.yml

@@ -25,7 +25,8 @@ jobs:
       displayName: Code-sign .nupkg files
       inputs:
         solution: eng\tools\XplatPackageSigner\XplatPackageSigner.proj
-        msbuildArguments: $(_SigningArgs)
+        msbuildArguments: /p:SignType=$(_SignType)
+          $(_PublishArgs)
           /p:DirectoryToSign=$(Build.StagingDirectory)\deps\${{ parameters.inputName }}_Packages\
     artifacts:
     - name: ${{ parameters.inputName }}_Packages_Signed

Directory.Build.props

@@ -125,6 +125,11 @@
     <SymbolsOutputPath>$(ArtifactsDir)symbols\$(Configuration)\</SymbolsOutputPath>
   </PropertyGroup>
 
+  <!-- Include our "loose" PDBs when publishing. -->
+  <ItemGroup>
+    <FilesToPublishToSymbolServer Include="$(SymbolsOutputPath)**\*.pdb" />
+  </ItemGroup>
+
   <!-- Ensure these output paths exist. -->
   <ItemGroup>
     <CreateDirectory Include="$(InstallersOutputPath)" />