Skip to content

[Blazor][Fixes #15155] Clarifies the message to turn on detailed erro… #15156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2019
Merged

[Blazor][Fixes #15155] Clarifies the message to turn on detailed erro… #15156

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d209331
[Blazor][Fixes #15155] Clarifies the message to turn on detailed erro…
javiercn Oct 18, 2019
3a72997
Updated casing
javiercn Oct 18, 2019
78fe265
Update appSettings.Development.json
javiercn Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Components/Server/src/Circuits/CircuitHost.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@ private string GetClientErrorMessage(Exception exception, string additionalInfor
else
{
return $"There was an unhandled exception on the current circuit, so this circuit will be terminated. For more details turn on " +
$"detailed exceptions in '{typeof(CircuitOptions).Name}.{nameof(CircuitOptions.DetailedErrors)}'. {additionalInformation}";
$"detailed exceptions by setting 'detailedErrors: true' in 'appSettings.Development.json' or set '{typeof(CircuitOptions).Name}.{nameof(CircuitOptions.DetailedErrors)}'. {additionalInformation}";
}
}

Expand Down
6 changes: 3 additions & 3 deletions src/Components/test/E2ETest/ServerExecutionTests/ComponentHubInvalidEventTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public async Task DispatchingAnInvalidEventArgument_DoesNotProduceWarnings()
{
// Arrange
var expectedError = $"There was an unhandled exception on the current circuit, so this circuit will be terminated. For more details turn on " +
$"detailed exceptions in 'CircuitOptions.DetailedErrors'. Bad input data.";
$"detailed exceptions by setting 'detailedErrors: true' in 'appSettings.Development.json' or set 'CircuitOptions.DetailedErrors'. Bad input data.";

var eventDescriptor = Serialize(new WebEventDescriptor()
{
Expand All @@ -65,7 +65,7 @@ public async Task DispatchingAnInvalidEvent_DoesNotTriggerWarnings()
{
// Arrange
var expectedError = $"There was an unhandled exception on the current circuit, so this circuit will be terminated. For more details turn on " +
$"detailed exceptions in 'CircuitOptions.DetailedErrors'. Failed to dispatch event.";
$"detailed exceptions by setting 'detailedErrors: true' in 'appSettings.Development.json' or set 'CircuitOptions.DetailedErrors'. Failed to dispatch event.";

var eventDescriptor = Serialize(new WebEventDescriptor()
{
Expand Down Expand Up @@ -105,7 +105,7 @@ public async Task DispatchingAnInvalidRenderAcknowledgement_DoesNotTriggerWarnin
{
// Arrange
var expectedError = $"There was an unhandled exception on the current circuit, so this circuit will be terminated. For more details turn on " +
$"detailed exceptions in 'CircuitOptions.DetailedErrors'. Failed to complete render batch '1846'.";
$"detailed exceptions by setting 'detailedErrors: true' in 'appSettings.Development.json' or set 'CircuitOptions.DetailedErrors'. Failed to complete render batch '1846'.";


Client.ConfirmRenderBatch = false;
Expand Down
4 changes: 2 additions & 2 deletions src/Components/test/E2ETest/ServerExecutionTests/ComponentHubReliabilityTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ public async Task OnLocationChanged_ReportsDebugForExceptionInValidation()
{
// Arrange
var expectedError = "There was an unhandled exception on the current circuit, so this circuit will be terminated. " +
"For more details turn on detailed exceptions in 'CircuitOptions.DetailedErrors'. " +
"For more details turn on detailed exceptions by setting 'detailedErrors: true' in 'appSettings.Development.json' or set 'CircuitOptions.DetailedErrors'. " +
"Location change to 'http://example.com' failed.";

var rootUri = ServerFixture.RootUri;
Expand Down Expand Up @@ -245,7 +245,7 @@ public async Task OnLocationChanged_ReportsErrorForExceptionInUserCode()
{
// Arrange
var expectedError = "There was an unhandled exception on the current circuit, so this circuit will be terminated. " +
"For more details turn on detailed exceptions in 'CircuitOptions.DetailedErrors'. " +
"For more details turn on detailed exceptions by setting 'detailedErrors: true' in 'appSettings.Development.json' or set 'CircuitOptions.DetailedErrors'. " +
"Location change failed.";

var rootUri = ServerFixture.RootUri;
Expand Down