Skip to content

Quarantine dotnet-user-secrets InitCommandTests #21338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Quarantine dotnet-user-secrets InitCommandTests #21338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6651eb8
Quarantine dotnet-user-secrets InitCommandTests
halter73 Apr 29, 2020
de2a4c4
Review feedback
halter73 Apr 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Tools/dotnet-user-secrets/src/Internal/ProjectIdResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ public string Resolve(string project, string configuration)
{
_reporter.Verbose(outputBuilder.ToString());
_reporter.Verbose(errorBuilder.ToString());
_reporter.Error($"Exit code: {process.ExitCode}");
throw new InvalidOperationException(Resources.FormatError_ProjectFailedToLoad(projectFile));
}

Expand Down
5 changes: 5 additions & 0 deletions src/Tools/dotnet-user-secrets/test/InitCommandTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ public InitCommandTests(UserSecretsTestFixture fixture, ITestOutputHelper output
private CommandContext MakeCommandContext() => new CommandContext(null, new TestReporter(_output), _console);

[Fact]
[QuarantinedTest]
public void AddsSecretIdToProject()
{
var projectDir = _fixture.CreateProject(null);
Expand All @@ -44,6 +45,7 @@ public void AddsSecretIdToProject()
}

[Fact]
[QuarantinedTest]
public void AddsSpecificSecretIdToProject()
{
const string SecretId = "TestSecretId";
Expand All @@ -58,6 +60,7 @@ public void AddsSpecificSecretIdToProject()
}

[Fact]
[QuarantinedTest]
public void AddsEscapedSpecificSecretIdToProject()
{
const string SecretId = @"<lots of XML invalid values>&";
Expand All @@ -72,6 +75,7 @@ public void AddsEscapedSpecificSecretIdToProject()
}

[Fact]
[QuarantinedTest]
public void DoesNotGenerateIdForProjectWithSecretId()
{
const string SecretId = "AlreadyExists";
Expand Down Expand Up @@ -114,6 +118,7 @@ public void DoesNotRemoveBlankLines()
}

[Fact]
[QuarantinedTest]
public void OverridesIdForProjectWithSecretId()
{
const string SecretId = "AlreadyExists";
Expand Down