Skip to content

Commit 11d8020

Browse files
author
Swen Wenzel
committed
fix indentation and use unique consumergroup ids for tests
1 parent fa8af0c commit 11d8020

File tree

1 file changed

+25
-25
lines changed

1 file changed

+25
-25
lines changed

test/test_admin_integration.py

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -243,62 +243,62 @@ def consumer_thread(i, group_id):
243243
@pytest.mark.skipif(env_kafka_version() < (1, 1), reason="Delete consumer groups requires broker >=1.1")
244244
def test_delete_consumergroups(kafka_admin_client, kafka_consumer_factory, send_messages):
245245
send_messages(range(0, 100), partition=0)
246-
consumer1 = kafka_consumer_factory(group_id="group1")
246+
consumer1 = kafka_consumer_factory(group_id="test1-group1")
247247
next(consumer1)
248248
consumer1.close()
249249

250-
consumer2 = kafka_consumer_factory(group_id="group2")
250+
consumer2 = kafka_consumer_factory(group_id="test1-group2")
251251
next(consumer2)
252252
consumer2.close()
253253

254-
consumer3 = kafka_consumer_factory(group_id="group3")
254+
consumer3 = kafka_consumer_factory(group_id="test1-group3")
255255
next(consumer3)
256256
consumer3.close()
257257

258258
consumergroups = {group_id for group_id, _ in kafka_admin_client.list_consumer_groups()}
259-
assert "group1" in consumergroups
260-
assert "group2" in consumergroups
261-
assert "group3" in consumergroups
259+
assert "test1-group1" in consumergroups
260+
assert "test1-group2" in consumergroups
261+
assert "test1-group3" in consumergroups
262262

263263
delete_results = {
264264
group_id: error
265-
for group_id, error in kafka_admin_client.delete_consumer_groups(["group1", "group2"])
265+
for group_id, error in kafka_admin_client.delete_consumer_groups(["test1-group1", "test1-group2"])
266266
}
267-
assert delete_results["group1"] == NoError
268-
assert delete_results["group2"] == NoError
269-
assert "group3" not in delete_results
267+
assert delete_results["test1-group1"] == NoError
268+
assert delete_results["test1-group2"] == NoError
269+
assert "test1-group3" not in delete_results
270270

271271
consumergroups = {group_id for group_id, _ in kafka_admin_client.list_consumer_groups()}
272-
assert "group1" not in consumergroups
273-
assert "group2" not in consumergroups
274-
assert "group3" in consumergroups
272+
assert "test1-group1" not in consumergroups
273+
assert "test1-group2" not in consumergroups
274+
assert "test1-group3" in consumergroups
275275

276276

277277
@pytest.mark.skipif(env_kafka_version() < (1, 1), reason="Delete consumer groups requires broker >=1.1")
278278
def test_delete_consumergroups_with_errors(kafka_admin_client, kafka_consumer_factory, send_messages):
279279
send_messages(range(0, 100), partition=0)
280-
consumer1 = kafka_consumer_factory(group_id="group1")
280+
consumer1 = kafka_consumer_factory(group_id="test2-group1")
281281
next(consumer1)
282282
consumer1.close()
283283

284-
consumer2 = kafka_consumer_factory(group_id="group2")
284+
consumer2 = kafka_consumer_factory(group_id="test2-group2")
285285
next(consumer2)
286286

287287
consumergroups = {group_id for group_id, _ in kafka_admin_client.list_consumer_groups()}
288-
assert "group1" in consumergroups
289-
assert "group2" in consumergroups
290-
assert "group3" not in consumergroups
288+
assert "test2-group1" in consumergroups
289+
assert "test2-group2" in consumergroups
290+
assert "test2-group3" not in consumergroups
291291

292292
delete_results = {
293293
group_id: error
294-
for group_id, error in kafka_admin_client.delete_consumer_groups(["group1", "group2", "group3"])
294+
for group_id, error in kafka_admin_client.delete_consumer_groups(["test2-group1", "test2-group2", "test2-group3"])
295295
}
296296

297-
assert delete_results["group1"] == NoError
298-
assert delete_results["group2"] == NonEmptyGroupError
299-
assert delete_results["group3"] == GroupIdNotFoundError
297+
assert delete_results["test2-group1"] == NoError
298+
assert delete_results["test2-group2"] == NonEmptyGroupError
299+
assert delete_results["test2-group3"] == GroupIdNotFoundError
300300

301301
consumergroups = {group_id for group_id, _ in kafka_admin_client.list_consumer_groups()}
302-
assert "group1" not in consumergroups
303-
assert "group2" in consumergroups
304-
assert "group3" not in consumergroups
302+
assert "test2-group1" not in consumergroups
303+
assert "test2-group2" in consumergroups
304+
assert "test2-group3" not in consumergroups

0 commit comments

Comments
 (0)