Skip to content

Commit 983ada5

Browse files
author
Tyler Lubeck
committed
Add support for AlterConfigs API v1
1 parent 3f6d731 commit 983ada5

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed

kafka/admin/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -852,7 +852,7 @@ def alter_configs(self, config_resources):
852852
:return: Appropriate version of AlterConfigsResponse class.
853853
"""
854854
version = self._matching_api_version(AlterConfigsRequest)
855-
if version == 0:
855+
if version <= 1:
856856
request = AlterConfigsRequest[version](
857857
resources=[self._convert_alter_config_resource_request(config_resource) for config_resource in config_resources]
858858
)

kafka/protocol/admin.py

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -637,6 +637,13 @@ class AlterConfigsResponse_v0(Response):
637637
('resource_name', String('utf-8'))))
638638
)
639639

640+
641+
class AlterConfigsResponse_v1(Response):
642+
API_KEY = 33
643+
API_VERSION = 1
644+
SCHEMA = AlterConfigsResponse_v0.SCHEMA
645+
646+
640647
class AlterConfigsRequest_v0(Request):
641648
API_KEY = 33
642649
API_VERSION = 0
@@ -651,8 +658,14 @@ class AlterConfigsRequest_v0(Request):
651658
('validate_only', Boolean)
652659
)
653660

654-
AlterConfigsRequest = [AlterConfigsRequest_v0]
655-
AlterConfigsResponse = [AlterConfigsResponse_v0]
661+
class AlterConfigsRequest_v1(Request):
662+
API_KEY = 33
663+
API_VERSION = 1
664+
RESPONSE_TYPE = AlterConfigsResponse_v1
665+
SCHEMA = AlterConfigsRequest_v2.SCHEMA
666+
667+
AlterConfigsRequest = [AlterConfigsRequest_v0, AlterConfigsRequest_v1]
668+
AlterConfigsResponse = [AlterConfigsResponse_v0, AlterConfigsRequest_v1]
656669

657670

658671
class DescribeConfigsResponse_v0(Response):

0 commit comments

Comments
 (0)