Skip to content

Commit cc4ed74

Browse files
committed
conn: use api_version_auto_timeout_ms for timeout in version checking
1 parent 3a6ec74 commit cc4ed74

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

kafka/conn.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ class BrokerConnection(object):
171171
Default: None
172172
api_version_auto_timeout_ms (int): number of milliseconds to throw a
173173
timeout exception from the constructor when checking the broker
174-
api version. Only applies if api_version is None
174+
api version. Only applies if api_version is None. Default: 2000.
175175
selector (selectors.BaseSelector): Provide a specific selector
176176
implementation to use for I/O multiplexing.
177177
Default: selectors.DefaultSelector
@@ -217,6 +217,7 @@ class BrokerConnection(object):
217217
'ssl_password': None,
218218
'ssl_ciphers': None,
219219
'api_version': None,
220+
'api_version_auto_timeout_ms': 2000,
220221
'selector': selectors.DefaultSelector,
221222
'state_change_callback': lambda node_id, sock, conn: True,
222223
'metrics': None,
@@ -548,14 +549,14 @@ def _try_api_versions_check(self):
548549
# ((0, 10), ApiVersionsRequest[0]()),
549550
request = ApiVersionsRequest[0]()
550551
future = Future()
551-
response = self._send(request, blocking=True)
552+
response = self._send(request, blocking=True, request_timeout_ms=(self.config['api_version_auto_timeout_ms'] * 0.8))
552553
response.add_callback(self._handle_api_versions_response, future)
553554
response.add_errback(self._handle_api_versions_failure, future)
554555
self._api_versions_future = future
555556
elif self._check_version_idx < len(self.VERSION_CHECKS):
556557
version, request = self.VERSION_CHECKS[self._check_version_idx]
557558
future = Future()
558-
response = self._send(request, blocking=True)
559+
response = self._send(request, blocking=True, request_timeout_ms=(self.config['api_version_auto_timeout_ms'] * 0.8))
559560
response.add_callback(self._handle_check_version_response, future, version)
560561
response.add_errback(self._handle_check_version_failure, future)
561562
self._api_versions_future = future

0 commit comments

Comments
 (0)