Skip to content

Commit d032844

Browse files
authored
Fix flaky conn tests that use time.time (#1758)
1 parent d620703 commit d032844

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

test/test_conn.py

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -74,18 +74,21 @@ def test_connect_timeout(_socket, conn):
7474

7575

7676
def test_blacked_out(conn):
77-
assert conn.blacked_out() is False
78-
conn.last_attempt = time.time()
79-
assert conn.blacked_out() is True
77+
with mock.patch("time.time", return_value=1000):
78+
conn.last_attempt = 0
79+
assert conn.blacked_out() is False
80+
conn.last_attempt = 1000
81+
assert conn.blacked_out() is True
8082

8183

8284
def test_connection_delay(conn):
83-
conn.last_attempt = time.time()
84-
assert round(conn.connection_delay()) == round(conn.config['reconnect_backoff_ms'])
85-
conn.state = ConnectionStates.CONNECTING
86-
assert conn.connection_delay() == 0
87-
conn.state = ConnectionStates.CONNECTED
88-
assert conn.connection_delay() == float('inf')
85+
with mock.patch("time.time", return_value=1000):
86+
conn.last_attempt = 1000
87+
assert conn.connection_delay() == conn.config['reconnect_backoff_ms']
88+
conn.state = ConnectionStates.CONNECTING
89+
assert conn.connection_delay() == 0
90+
conn.state = ConnectionStates.CONNECTED
91+
assert conn.connection_delay() == float('inf')
8992

9093

9194
def test_connected(conn):

0 commit comments

Comments
 (0)