Add 'codec' parameter to Producer #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a codec parameter to Producer.__init__ that lets the user choose a compression codec to use for all messages sent by it.
Improve Tests, fix connection error timeout, other issues
|
I'm going to work on merging this and making the CI build pass. This was literally my next task at work. |
…ssion Conflicts: servers/0.8.0/kafka-src test/test_unit.py
|
Merged in your changes. I didn't work on any tests since I got a battery of failures when trying to run tox out of the box, but they appear to run now. |
Add function kafka.protocol.create_message_set() that takes a list of payloads and a codec and returns a message set with the desired encoding. Introduce kafka.common.UnsupportedCodecError, raised if an unknown codec is specified. Include a test for the new function.
|
I pulled the logic I added into a function in kafka.protocol and added a test. (Now that I can run tox :)) |
|
LGTM. |
|
+1, I'd like to see this merged. |
dpkp
added a commit
that referenced
this pull request
May 20, 2014
…ession Add 'codec' parameter to Producer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a codec parameter to Producer.init that lets the user choose
a compression codec to use for all messages sent by it.
This change technically breaks backwards compatibility if a user instantiated a Producer using positional arguments instead of keyword arguments. It's up to you all how to handle this concern.