Add pylint-3.1 code back in.

This re-adds the pylintrc and the `run lint` command so
that we can still run `pylint` (in addition to being able to run
`ruff check`.

Author: dpranke

json5/lib.py

@@ -122,7 +122,7 @@ def dictify(pairs):
     if not allow_duplicate_keys:
         _orig_dictify = dictify
 
-        def dictify(pairs):
+        def dictify(pairs):  # pylint: disable=function-redefined
             return _reject_duplicate_keys(pairs, _orig_dictify)
 
     parse_float = parse_float or float

pylintrc

@@ -0,0 +1,66 @@
+# Copyright 2014 Google Inc. All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This file is taken from the suggested pylint configuration in 
+# Google's Python Style Guide, specifically
+# https://github.com/google/styleguide/blob/28d10d1/pylintrc
+# The only changes are to comment out the disabling of no-self-use, to
+# get rid of the "useless option value" warning from pylint, and to
+# turn off the score message.
+[MAIN]
+
+persistent=yes
+
+[MESSAGES CONTROL]
+
+disable=
+    broad-except,
+    global-statement,
+    locally-disabled,
+    missing-docstring,
+    # no-self-use,  # Pylint generates a 'useless option value' warning for this
+    too-many-arguments,
+    too-few-public-methods,
+    too-many-branches,
+    too-many-instance-attributes,
+    too-many-locals,
+    too-many-public-methods,
+    too-many-return-statements,
+    unidiomatic-typecheck,
+
+[REPORTS]
+
+reports=no
+
+[SCORE]
+
+score=no  # Suppress the "score" message in the output.
+
+[BASIC]
+
+# By default, pylint wants method names to be at most 31 chars long,
+# but we want to allow up to 49 to allow for longer test names.
+method-rgx=[a-zA-Z_][a-zA-Z0-9_]{0,48}$
+
+# By default, pylint only allows UPPER_CASE constants, but we want to
+# allow snake_case as well in some situations.
+const-rgx=[a-zA-Z_][a-zA-Z0-9_]{0,30}$
+
+# By default, pylint wants all parameter names to be at least two chars long,
+# but we want to allow single-char parameter names as well.
+argument-rgx=[a-z_][a-z0-9_]{0,30}$
+
+# By default, pylint wants all variable names to be at least two chars long,
+# but we want to allow single-char variable names as well.
+variable-rgx=[a-z_][a-z0-9_]{0,30}$

run

@@ -24,7 +24,7 @@ def main(argv):
     subp = subps.add_parser('build', help='Build the package.')
     subp.set_defaults(func=run_build)
 
-    subp = subps.add_parser('check', help='Lint the source code.')
+    subp = subps.add_parser('check', help='Lint the source code w/ ruff.')
     subp.set_defaults(func=run_check)
 
     subp = subps.add_parser('clean', help='Remove any local files.')
@@ -60,6 +60,9 @@ def main(argv):
         ),
     )
 
+    subp = subps.add_parser('lint', help='Lint the source code w/ pylint.')
+    subp.set_defaults(func=run_lint)
+
     subp = subps.add_parser('tests', help='run the tests')
     subp.set_defaults(func=run_tests)
 
@@ -123,6 +126,11 @@ def run_install(args):
     call([sys.executable, 'setup.py', 'install'] + argv)
 
 
+def run_lint(args):
+    del args
+    call(sys.executable + ' -m pylint run */*.py', shell=True)
+
+
 def run_tests(args):
     del args
     call([sys.executable, '-m', 'unittest', 'discover', '-p', '*_test.py'])

tests/lib_test.py

@@ -135,17 +135,17 @@ def test_identifiers_unicode(self):
         self.check('{\xc3: 1}', {'\xc3': 1})
 
         # Latin small A with Ring above, category Ll (lowercase letter)
-        self.check('{\u00E5: 1}', {'\u00E5': 1})
+        self.check('{\u00e5: 1}', {'\u00e5': 1})
 
         # Modifier Letter small H, category Lm (modifier letter)
-        self.check('{\u02B0: 1}', {'\u02B0': 1})
+        self.check('{\u02b0: 1}', {'\u02b0': 1})
 
         # Latin Letter Two with Stroke, category Lo (other letter)
-        self.check('{\u01BB: 1}', {'\u01BB': 1})
+        self.check('{\u01bb: 1}', {'\u01bb': 1})
 
         # Latin Capital Letter L with Small Letter J
         # (category Lt, titlecase letter)
-        self.check('{\u01C8: 1}', {'\u01C8': 1})
+        self.check('{\u01c8: 1}', {'\u01c8': 1})
 
         # Roman Numeral One (category Nl, letter number)
         self.check('{\u2160: 1}', {'\u2160': 1})
@@ -154,13 +154,13 @@ def test_identifiers_unicode(self):
         self.check('{a\u0308o: 1}', {'a\u0308o': 1})
 
         # Rejang Virama (category Mc, spacing mark)
-        self.check('{a\uA953o: 1}', {'a\uA953o': 1})
+        self.check('{a\ua953o: 1}', {'a\ua953o': 1})
 
         # Arabic-Indic Digit Zero (category Nd, decimal number)
         self.check('{a\u0660: 1}', {'a\u0660': 1})
 
         # Undertie (category Pc, connector punctuation)
-        self.check('{a\u203Fb: 1}', {'a\u203Fb': 1})
+        self.check('{a\u203fb: 1}', {'a\u203fb': 1})
 
     def test_null(self):
         self.check('null', None)
@@ -412,17 +412,20 @@ def test_custom_numbers(self):
         # float.__repr__ in order to get legal JSON values when
         # people have custom subclasses with customer __repr__ methods.
         # (This is what JSON does and we want to match it).
+        # pylint: disable=no-self-argument
         class MyInt(int):
             def __repr__(other):  # pragma: no cover
                 del other
                 self.fail()
+                return ''
 
         self.assertEqual(json5.dumps(MyInt(5)), '5')
 
         class MyFloat(float):
             def __repr__(other):  # pragma: no cover
                 del other
                 self.fail()
+                return ''
 
         self.assertEqual(json5.dumps(MyFloat(0.5)), '0.5')