Remove unnecessary Array copy.

drodriguez · drodriguez · commit b9b6a35fc715 · 2019-07-17T16:07:33.000-07:00
Array.append(contentsOf:) supports any Sequence, and String.UTF8View is a sequence, so there's no need to create an Array from it to append it. From a post-merge feedback in swiftlang#2393.
diff --git a/Foundation/JSONSerialization.swift b/Foundation/JSONSerialization.swift
@@ -130,7 +130,7 @@ open class JSONSerialization : NSObject {
             sortedKeys: opt.contains(.sortedKeys),
             writer: { (str: String?) in
                 if let str = str {
-                    jsonStr.append(contentsOf: Array(str.utf8))
+                    jsonStr.append(contentsOf: str.utf8)
                 }
             }
         )

Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ open class JSONSerialization : NSObject {`
`130`	`130`	`sortedKeys: opt.contains(.sortedKeys),`
`131`	`131`	`writer: { (str: String?) in`
`132`	`132`	`if let str = str {`
`133`		`- jsonStr.append(contentsOf: Array(str.utf8))`
	`133`	`+ jsonStr.append(contentsOf: str.utf8)`
`134`	`134`	`}`
`135`	`135`	`}`
`136`	`136`	`)`